Received-SPF: pass (google.com: domain of linux-kernel+bounces-108889-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 20 Mar 2024 14:02:27 +0200 (EET)
To: Luke Jones <luke@ljones.dev>
cc: platform-driver-x86@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook
 GPU MUX
In-Reply-To: <fbd2dc65-33d9-447e-9edb-78df370778be@app.fastmail.com>
Message-ID: <c7e375df-e709-a348-a240-0d6d8bde1840@linux.intel.com>
References: <20240310055312.11293-1-luke@ljones.dev> <20240310055312.11293-2-luke@ljones.dev> <0f35beb8-5453-63cb-0570-752b2693f6ec@linux.intel.com> <fbd2dc65-33d9-447e-9edb-78df370778be@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-738845263-1710936147=:1037"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-738845263-1710936147=:1037
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 20 Mar 2024, Luke Jones wrote:

> On Wed, 20 Mar 2024, at 1:26 AM, Ilpo J=C3=A4rvinen wrote:
> > On Sun, 10 Mar 2024, Luke D. Jones wrote:
> >=20
> > > Adjust existing MUX support to select whichever MUX support is availa=
ble
> > > so that ASUS Vivobook MUX can also be used if detected.
> >=20
> > This description is a bit on the short side. It wouldn't have hurt to=
=20
> > first state that Vivobooks come with a GPU MUX WMI that has a different=
=20
> > WMI device ID. I can infer that after reading the diff but the descript=
ion=20
> > should not require reading the patch.
>=20
> Would you prefer I changed the commit message?

I kind of tried to give some leeway for you and not sound like I'm=20
enforcing you to do it but yes, I do prefer good commit messages myself
(I know that after reading this patch the reasons will be pretty obvious=20
to anyone so it's not a grave problem). So half it was said future=20
patches in mind, half you can do it if you want also for this patch.

But since you'll need to resend this anyway because of the=20
independent/series issue I mentioned in my reply to one of the other=20
patches, just cover this minor thing as well, it's one sentence after
all.

--=20
 i.

--8323328-738845263-1710936147=:1037--