Received-SPF: pass (google.com: domain of linux-kernel+bounces-109079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <578d0b55-c51a-49d1-8f54-989215a3a4b8@intel.com>
Date: Wed, 20 Mar 2024 08:20:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 11/13] selftests/resctrl: Convert ctrlgrp & mongrp to
 pointers
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, <linux-kernel@vger.kernel.org>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com>
 <20240311135230.7007-12-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240311135230.7007-12-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enVmNHdEWWZFNVVTa3FmK0lEYjFBTHRqSVhXa1FCVjdCeDVlcFBpVkV2VW16?=
 =?utf-8?B?bWI2M3I2T0hxakZRcEUwSEcwNFJ4NCtzeXZlQ0JOTjJhK2N1OTFaTVIxd0NF?=
 =?utf-8?B?ek1nMlZqbk5nKy84RUpjaGtISkpLc242eHlId28zVHZkcVdLNjJ6UUpPdmdq?=
 =?utf-8?B?RnM5MVExOFZXZW5YbWx2Vng4MjVZSWZKUFltc09ncnZOZ0dIRWVOV0RZRXVL?=
 =?utf-8?B?aC80RWVOZCt5Mlo0S2NOVmJ2amFleGNsR1p0cUpoZ09HWERwMHZsY3Y2NU90?=
 =?utf-8?B?SDMxQ2J3Z2o0a0RRQW5kY0NFZFpmdkJBTHBkQnlXbEM2QktJOStubE8wWCtY?=
 =?utf-8?B?a2VmUWJtUjhYOEdqUFJPcHh6VTFrT0QrTVQ2eXBIb3Z1ejMvRU82b2ZZQmdS?=
 =?utf-8?B?TzJ5S2MvazdHWERPZEliWEhtWkxLZC9yZVQ0WURvNVFhTEZoTHU3R1Z2cUxm?=
 =?utf-8?B?cU5zTXMwUzVreG5jOTRra1BKcEk5K3BiRkpVKzhEMmlPWGc1U2piOGZxOVRt?=
 =?utf-8?B?SlJaTkwzOWdMdkM0eFFVTlkrYldoS2Mrd3FCVjVTR1VwZVlzMGtOVHlzaFNl?=
 =?utf-8?B?aUdGR20wUDgxdXdWcGtGUTBiYWdmdzJMSnJCRVNuekR1N1hHcGdjc3JYVkZq?=
 =?utf-8?B?SFJhaUoyYWR1NGZzdStOTStBU0RxaGZwUVI5SmdLV2NaKy9lQ1lXZ1hLNnVa?=
 =?utf-8?B?aHpSYlR1cHlSM0c0d3U0c3RUZHZlZU1XUnVIZm9mWnQvWUswdGdaN0owcEMw?=
 =?utf-8?B?NlVvNVRic2pDR2IwcVMzZ3VZbERqL1pwQlZsZHlOMlVuczEzMEdZcXc4elJG?=
 =?utf-8?B?bU1oZm1Nb0c5ZVhuaEFadkRlekd1ZTRIMTJVUXh4RllPRUMvcDdJSXVjVnF4?=
 =?utf-8?B?R2hmRWdvQUgxLytEaC83S25rc0lGMzNmRHdXZXcyb1UrQUtsT0pBY3E4eGNz?=
 =?utf-8?B?dUVBdmdLTGdsYlpENG5CdkNYemRZRmJoL1A3Wkd3Uk1ZUGlpMGZIR2FhRVRW?=
 =?utf-8?B?cjZHNlJPS24yQ1B1d2RYb0d6MUtVU1FsNm9RZllnNHJIaFhhU1ZSR0xTZHB5?=
 =?utf-8?B?aHlYSE5NRXMvM2RCamJXMHRKT2dScklRTzBQSzBDZ05CWmlzN1V4RjhROGZn?=
 =?utf-8?B?RWNqV0dLMFJjMGJxWjJ6NnJHZ054L0c2N1JXNlgyT2lzZmMrU01ldE15L2RF?=
 =?utf-8?B?Q2RROWJLVHhST25CSUVwbHF4UXVqS1pSU0x2SHNMdXhXekJPZHNIY1lBMS80?=
 =?utf-8?B?TlZ4cHNXckNyelFzTFFsYUtmMWVOSDBCdXl2UzE0QmJpdks0a3VQV1J1WDBQ?=
 =?utf-8?B?djRNaG9CR1QwUzBHMThxYXAwajZIQnhybjJJVHU4SEhEMDV6bWpVN09pMWRr?=
 =?utf-8?B?UTRpclJuOTBubXBxZFRJUE5YV1BSSkVMRWUrRjJjbk16ckR0VEQvanNRSHhN?=
 =?utf-8?B?OWtsaVBrVXJKdmEyRzlScnVRMTA5NmYyaXpaRDlIY0IrcjluUXpRS0ZvQ0p1?=
 =?utf-8?B?ckFwc29HYjJCeWJOcG5nR2J6azk5eHh6TFJtWm1TcGtad1poRlYxRjV2M0U4?=
 =?utf-8?B?dmZ1c0QrbmZQQUFKNjdwSFNTUDU0Mi9ydnpLWldlSU9BcFE1aDZDYUxXaFp4?=
 =?utf-8?B?eWk4MHh6NlU3cmpuNG5qbGN1ZlNDa1NWRE9WMlhWVmV0MCtMY1g1alZkZS82?=
 =?utf-8?B?UmtXL0IxOStOK2Y4RHByaHZ0dllzTFhQdWs5OE1RaW5BOHoyUW5xcG5rWUY0?=
 =?utf-8?B?b0dzZUlIdDFlb3JPc0hIN3liMG5NT25UTzdTNElGZDVhamR4QzNQb3NFbFd0?=
 =?utf-8?B?dlRKL1MybXB3N25Qa2Q0VUlOazBIbVcybVNyMzdLWHh4VTlhdHp4eGxueGUz?=
 =?utf-8?B?dUErNTVacU55NzlHVnJmcWhlMWtFZytld1FzSFU1OEVrQ2J0TklJWUJNNytt?=
 =?utf-8?B?RVBnOVF5MzNWcitMKzVsUW02SklaNlZZdytwaGoyNU9OYkRsRE91RGluc3ZG?=
 =?utf-8?B?UGdQbVFralJyOHJaSlVEUFF2LzFtcHJ4YVAvYSswVlNZYzMvUGo5V2pFMTB1?=
 =?utf-8?B?Kzh0N2lpZmpsSjJ0emtDY3lvc24vemw1MWRTR205a3pMS3NXYkw2NVlQTlRM?=
 =?utf-8?B?TkJBRjNrQ013T1IzT2NsazVKaGkzVWVXWU5zYk1tQUMrNEIvclBJdzBrME5w?=
 =?utf-8?B?VXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 917a589c-2fa4-47e8-9af9-08dc48f1472b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 15:20:29.9725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MQNetYwoFsZKt6sSy/E9raVtGE5PoRkfQld0HuH1LyqsxbY1q3JjK1QMNRAcRgK6NYJ38TUaXecTgsVpwOb0mDwhi1cOKEv4cFbBPQhLloM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8516
X-OriginatorOrg: intel.com

Hi Ilpo,

On 3/11/2024 6:52 AM, Ilpo Järvinen wrote:
> The struct resctrl_val_param has control and monitor groups as char
> arrays but they are not supposed to be mutated within resctrl_val().
> 
> Convert the ctrlgrp and mongrp char array within resctrl_val_param to
> plain const char pointers and adjust the strlen() based checks to
> check NULL instead.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/resctrl.h   | 4 ++--
>  tools/testing/selftests/resctrl/resctrlfs.c | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 52769b075233..54e5bce4c698 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -89,8 +89,8 @@ struct resctrl_test {
>   */
>  struct resctrl_val_param {
>  	char		*resctrl_val;
> -	char		ctrlgrp[64];
> -	char		mongrp[64];
> +	const char	*ctrlgrp;
> +	const char	*mongrp;
>  	char		filename[64];
>  	unsigned long	mask;
>  	int		num_of_runs;
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 79cf1c593106..dbe0cc6d74fa 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -469,7 +469,7 @@ static int create_grp(const char *grp_name, char *grp, const char *parent_grp)
>  	 * length of grp_name == 0, it means, user wants to use root con_mon
>  	 * grp, so do nothing
>  	 */

Could you please confirm that the comments are still accurate?

> -	if (strlen(grp_name) == 0)
> +	if (!grp_name)
>  		return 0;
>  


Reinette