Received-SPF: pass (google.com: domain of linux-kernel+bounces-109102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240204122003.53795-1-masahiroy@kernel.org>
In-Reply-To: <20240204122003.53795-1-masahiroy@kernel.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Thu, 21 Mar 2024 00:30:33 +0900
Message-ID: <CAK7LNASH+vfoXhTtPWqwHYgkhUaLfemB+xPfo=SM-rbg2rrhnQ@mail.gmail.com>
Subject: Re: [PATCH] x86: select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAME_POINTER=y
To: x86@kernel.org
Cc: Josh Poimboeuf <jpoimboe@kernel.org>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>, 
	Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Ping?


On Sun, Feb 4, 2024 at 9:20=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.or=
g> wrote:
>
> It took me some time to understand the purpose of the tricky code at
> the end of arch/x86/Kconfig.debug.
>
> Without it, the following would be shown:
>
>   WARNING: unmet direct dependencies detected for FRAME_POINTER
>
> because commit 81d387190039 ("x86/kconfig: Consolidate unwinders into
> multiple choice selection") removed 'select ARCH_WANT_FRAME_POINTERS'.
>
> The correct and more straightforward approach should have been to move
> it where 'select FRAME_POINTER' is located.
>
> Several architectures properly handle the conditional selection of
> ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER'
> in arch/arm/Kconfig.debug.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  arch/x86/Kconfig.debug | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index c5d614d28a75..74777a97e394 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -248,6 +248,7 @@ config UNWINDER_ORC
>
>  config UNWINDER_FRAME_POINTER
>         bool "Frame pointer unwinder"
> +       select ARCH_WANT_FRAME_POINTERS
>         select FRAME_POINTER
>         help
>           This option enables the frame pointer unwinder for unwinding ke=
rnel
> @@ -271,7 +272,3 @@ config UNWINDER_GUESS
>           overhead.
>
>  endchoice
> -
> -config FRAME_POINTER
> -       depends on !UNWINDER_ORC && !UNWINDER_GUESS
> -       bool
> --
> 2.40.1
>


--=20
Best Regards
Masahiro Yamada