Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1597866lqt; Wed, 20 Mar 2024 08:32:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVtKSi4SO6Hc+MbZBjgWHoifNKkoHezQDyhUhd26p+zhCD2QYJPBxNABgEImV1rqcEb0h8Tz3VcND3HjHNqR4jTmvzb1POMFzGYYbK4Yg== X-Google-Smtp-Source: AGHT+IGPnH+u+7b7G2zKsRwMneQF7xdoy0l/9uy2nXp1ZyzJ5qjP+n1m7GfGNcy8xk70GNYaXhTt X-Received: by 2002:a05:6214:e64:b0:691:8306:7367 with SMTP id jz4-20020a0562140e6400b0069183067367mr173536qvb.30.1710948776566; Wed, 20 Mar 2024 08:32:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710948776; cv=pass; d=google.com; s=arc-20160816; b=gK8JdiBPwMCokmHzxQ6ak+6pe7qrNzr8gcdFld57+lJSTugMAP8LCD1KvBxcz+kjJZ 7w1x6zekhBf4mVOobQr3xjcr8q1OLIGyHIrSjzHM7NL7WTmOSIQX/ENdUAlyawUFagS5 lut7hD/gPf3fUuPmRXy8AABbEgs3eHqaT1suVlAYkaVWMFaGoZldCXabfd/LD8oqzxSb 5kYeY6Lqa7Ii3RFKFaE9XKVEi1BIYbe09te8Bs6X/Jmu/nJT+FRIGIBP7uWECVY/d12U jG7WHpP8MN0JmDdkuqdTZ2Fr6aEyku/5X913+ca8I4wcDRbVzQGit9/JK4r8NWlbvw91 1bYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=avXVf16FINM0rqRkwpmxZR53/b4zWauzNUq2vqatig4=; fh=PHq4OuhOUUP7V1I+gDdMCZNzaT4vH9shSoLBu78e8bA=; b=lIoAgVBAlyZoleEr6iZ71x8rSyECVRieNtdxfk+ee9x6P/IQ1r3S7qyvGNHHv4iNNE blXeX9UFWI4c+rRVziZo/Gebv+3oXPf/8pyRjc6CQ6WEK0HzWqpjLPfTRQ+TVwmhu+Kn bcEBMW360SukhLYtPQAZYPfizcvN1KvkU4z5qih9jbeGYkk5BF6lb8AzjabGFGWmbzmB OYDEt5YgRUnj/KjgDtGdE/4wCxtArDBOc2oU39S1mv+oeMAUz9z1MZdT1Br5miuHLixw dBQr28aWJDGZ3rekDMCCZbmpF90GXaYM9gsHQGX2gpgiuJKb3UUrhn6YUpHysTfj7nD2 VOwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rJgTYUAM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q8-20020a056214194800b0068c6fa95b48si12917085qvk.466.2024.03.20.08.32.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 08:32:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rJgTYUAM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109103-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109103-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4006C1C20FD9 for ; Wed, 20 Mar 2024 15:32:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18D27524D7; Wed, 20 Mar 2024 15:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rJgTYUAM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 409672746B for ; Wed, 20 Mar 2024 15:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710948771; cv=none; b=g4yDX6dqSvchY1lmRfOWDiQY/b7QqiAS6HRwlSjs1o8n2eQMSnQJ8kWtX2AtNHVtpMe2POViQNJGjzrFrHz/37W3lFx0F34ZQySfkTnYcS4shvlFutD3lNnlDmeEw28RsMbmH4pd50A+VyYIai/1dMTwQp6uckMIZEf2g4Ddw2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710948771; c=relaxed/simple; bh=TaikWDcEy/eefAipbr1kYwtCPCWVVRe3j3L/5KQxH1U=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=U6+ERvCVvP3CTaNQ/K5yha+NuK3WeuSi4erWNnfR86tjJmBEH8HD9k3p+bGIpOYFSfOX2pR+c34mrxmrwgUgigm4jlZ3oG2RnpPUZ9idRgrnp0S9f9RAA2vniv/f1/Nw8UN1fKial/nOEId5zkxCx8XLJtsXWYDtdpfjXjgURmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rJgTYUAM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10D7AC433F1; Wed, 20 Mar 2024 15:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710948770; bh=TaikWDcEy/eefAipbr1kYwtCPCWVVRe3j3L/5KQxH1U=; h=Date:Subject:To:References:From:In-Reply-To:From; b=rJgTYUAMR7xYxJsPKBou+wq/ZRPnjUILoEIQiUEj23b+KwRKKbWdbww5tNcZ6S0Il E2hNlh6t3miLoTtYJ7MXRb+dh6I3BlG3j3AYE2Ei48O80n8ZQz8LUwu1/GMGhAGnvO FnPQ4V/jsDDWNM6vO0Yy/0cPuX7v7nogavI5EWmRmydDMeGZfn4Zny736w1NF5HWSx FwueHuw80fNP7R6BSbX/29l+0kXRMirpDtQuIFEaaXv3JJkJKWAI++dIeOHOsZkb5o xmAdVHq5dgU6DxI4By7zdLy7pV06FbEDRtKn1a0UjxEH49mqYvoX/hMWQIhBuDf1SP gbNMEge9pB8SQ== Message-ID: Date: Wed, 20 Mar 2024 23:32:46 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid the deadlock case when stopping discard thread To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20240320001442.497813-1-jaegeuk@kernel.org> Content-Language: en-US From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: <20240320001442.497813-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/20 8:14, Jaegeuk Kim wrote: > f2fs_ioc_shutdown(F2FS_GOING_DOWN_NOSYNC) issue_discard_thread > - mnt_want_write_file() > - sb_start_write(SB_FREEZE_WRITE) > - sb_start_intwrite(SB_FREEZE_FS); > - f2fs_stop_checkpoint(sbi, false, : waiting > STOP_CP_REASON_SHUTDOWN); > - f2fs_stop_discard_thread(sbi); > - kthread_stop() > : waiting > > - mnt_drop_write_file(filp); > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,