From: Junio C Hamano <junio@pobox.com>
To: Andi Kleen <andi@firstfloor.org>
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
References: <20080108164015.GC31504@one.firstfloor.org>
	<20080108185255.GA4627@martell.zuzino.mipt.ru>
	<20080108191843.GA1004@one.firstfloor.org>
	<200801090140.58864.arnd@arndb.de>
	<20080109004748.GI2117@one.firstfloor.org>
cc: Arnd Bergmann <arnd@arndb.de>, Alexey Dobriyan <adobriyan@gmail.com>,
       linux-kernel@vger.kernel.org, apw@shadowen.org
Date: Wed, 09 Jan 2008 02:00:21 -0800
In-Reply-To: <20080109004748.GI2117@one.firstfloor.org> (Andi Kleen's message
	of "Wed, 9 Jan 2008 01:47:48 +0100")
Message-ID: <7vir23jp3e.fsf@gitster.siamese.dyndns.org>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1016
Lines: 33

Andi Kleen <andi@firstfloor.org> writes:

> I imagined it would check for 
>
> +struct file_operations ... = { 
> +      ...
> +	.ioctl = ...
>
> That wouldn't catch the case of someone adding only .ioctl to an 
> already existing file_operations which is not visible in the patch context, 
> but that should be hopefully rare. The more common case is adding
> completely new operations.

Because "diff -p" format used by the kernel mailing list takes
the most recent line that begins with an identifier letter and
put that on the hunk header line, even in such a case, you will
see:

	@@ -l,k +m,n @@ struct file_operations ... = {
		...
		...
	+	...
	+	.ioctl = ...
	+	...
		...

which would be a good enough cue that the new .ioctl member is
added to file_operations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/