Received-SPF: pass (google.com: domain of linux-kernel+bounces-109137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 20 Mar 2024 17:02:19 +0100
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: "Jan Kratochvil (Azul)" <jkratochvil@azul.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v4] cgroup2: New memory.max.effective like cgroup1
 hierarchical_memory_limit
Message-ID: <cah72hewsmrrzyo3tm2eipaw4mrxnncqv4zbbzz35x7ghjxred@lhdtiobg3bjm>
References: <ZcvlhOZ4VBEX9raZ@host1.jankratochvil.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="obcvqv52hinoclhy"
Content-Disposition: inline
In-Reply-To: <ZcvlhOZ4VBEX9raZ@host1.jankratochvil.net>


--obcvqv52hinoclhy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

I have some advise about patch desription and only nitpick about
implementation.

On Wed, Feb 14, 2024 at 05:56:20AM +0800, "Jan Kratochvil (Azul)" <jkratoch=
vil@azul.com> wrote:
> which are useful for userland to easily and performance-wise find out the
> effective cgroup limits being applied.

I think this is a weak reasoning for in-kernel implementation.
It may be faster but how often do you need to read that limit?

> Otherwise userland has to

Userland is at loss when running inside cgroupns with limited ancestors
out of the cgroupns. Thus I think this is the reason why kernel can
provide such an effective value. (And be subject line of the commit, I
think bringing up cgroup1 is misleading.)

> For cgroup1 it was implemented by:
> 	memcg: show real limit under hierarchy mode
> 	https://github.com/torvalds/linux/commit/fee7b548e6f2bd4bfd03a1a45d3afd5=
93de7d5e9
> 	Date:   Wed Jan 7 18:08:26 2009 -0800

FTR, commits are usually referenced more concisely like
	fee7b548e6f2 ("memcg: show real limit under hierarchy mode")=20
(the document Waiman linked previously has some tips how to get this
=66rom git).

> +static int memory_max_effective_show(struct seq_file *m, void *v)
> +{
> +	unsigned long memory;
> +	struct mem_cgroup *mi;
> +
> +	/* Hierarchical information */
> +	memory =3D PAGE_COUNTER_MAX;
> +	for (mi =3D mem_cgroup_from_seq(m); mi; mi =3D parent_mem_cgroup(mi))
> +		memory =3D min(memory, READ_ONCE(mi->memory.max));

root_mem_cgroup is never charged (thus limited), so you can terminate
the iteration on !mem_cgroup_is_root(mi), one level earlier

> +static int swap_max_effective_show(struct seq_file *m, void *v)
> +{
> +	unsigned long swap;
> +	struct mem_cgroup *mi;
> +
> +	/* Hierarchical information */
> +	swap =3D PAGE_COUNTER_MAX;
> +	for (mi =3D mem_cgroup_from_seq(m); mi; mi =3D parent_mem_cgroup(mi))
> +		swap =3D min(swap, READ_ONCE(mi->swap.max));

ditto

HTH,
Michal

--obcvqv52hinoclhy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZfsIiAAKCRAGvrMr/1gc
jjPaAP0UpgJnAoQuiyGpfv2ygAkpZ8Tv5wAS6zlt3p6Kti91cAEAw4Wb0RH30luT
hhBwGAntr1Pz6mUyND/ds2Ff8CoOGwY=
=Zh6c
-----END PGP SIGNATURE-----

--obcvqv52hinoclhy--