Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1678436lqt; Wed, 20 Mar 2024 10:40:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWeA/i9XWjMM5LHhZ5A3tFUfO681SBISdrGArVtMB6PXf3v38bHDFKxbqFhwA2P9suGhPikMbG/93UCCl3L6ggllDmDR8f1jR3x0kvW1w== X-Google-Smtp-Source: AGHT+IE2y45aoG51hjIWFnO+YIv9G7PI64HzfoPim/Fa46D1E3xgJzF2zdC9uBfRi8UeDXTiP1Ek X-Received: by 2002:a17:902:ec92:b0:1dd:c93c:580c with SMTP id x18-20020a170902ec9200b001ddc93c580cmr8638287plg.4.1710956401984; Wed, 20 Mar 2024 10:40:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710956401; cv=pass; d=google.com; s=arc-20160816; b=wO7PoBt/c6VTUIsxHBVMwJceTtujGUI0DWAxr2Wd5miLZddU3jpDZNORcbUb+QbOuy g6Zvdxlpf2eN16ksA9/auSSFWJglBSm/no8j3Idiy5YdPiLwO4TbYMaID+O9F8YHu3Em LhMZzEqyRtM1fRxZY8k2XQWHNzNlD6SiOPrZIgtMIhljaiy0F24FSq3Lz2wYUOGnfEp8 d+IvbEvcWMiRkuXlIvMmaD40I/lHPXvQrtVoX8kYkPpPSmHrFxQTpaaVsyDE/MGRKpoH 5N2YJKCc4THMlD5obsXirUo6P5or1yn9Nn8COjsasFsKmsxNX+LeVu80iVthPML+wtiW hhaA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zwds+PUmHoPgnDi+PEIYetNOxztzo31SSfgCEWJ8EK0=; fh=qcWbi6arO9o/m6x1alFmJYd8Hzs2L2zktqSio+PVGF8=; b=EiVnkfDiMPCPRCG0XyvnInWpRWAI3xH3XDDejqhSWoFAPrUtp9SKfB5TJcpVHMcWUw AfbpOqbbmi/sfJk1eRxdKk1UwVykeXT/Klt1iONNCzlk7SStY9IOUYXLn/jBRjuq2XLF YrOY5odeOzJYYHayyoWKcTPeFBP8tKdJXG9dEY3N3jMcNU+emBySl9tvNfDPaH0otSpL kRW36qC+HKZ25cFEM3LViOr30dk61KpuuZMMzLTnydHZMx6JG7lD4z3XK1xr4DLBGhWq g4JIJpoMPszPO27HKekxfM43UGh+vbIM2cR00tTIkrTTJoFWoPdBdQ7Dwph1rsdbQdDg pETA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GC+QjOLg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j9-20020a170903024900b001db45912e79si13921488plh.594.2024.03.20.10.40.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 10:40:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GC+QjOLg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 64680286EC9 for ; Wed, 20 Mar 2024 17:39:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 417666A355; Wed, 20 Mar 2024 17:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GC+QjOLg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62CBD1DFC6; Wed, 20 Mar 2024 17:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710956359; cv=none; b=KDuJjOXuy7SVeNiGssaB/ni8Go/AJeQNR/YYVkN4byLZwQ/OVQkkHnf9xF1aHiKUhhctk25TtfGdHVYF4Eeq22/4aJbGDgR/jwgxuDhn8qJDHvoxrQkU/hNtR/Icly0HPwbjBiQJiBvtFYil8nsg2JiVIcE9zJRgDf76B7DNN1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710956359; c=relaxed/simple; bh=+I4HwwOXGb4OTVbce2LLwgvNTP55VKW3XPSef7uX2qU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oLwBvoavBLUkH22j+ASMWlatlw8683ysi9w8Crzj8A2OOIRaIXJ8fkhnQ76dWKzLnMCkWSutzO1eS0aDECuJsebNHbhhdE5mMg3l1duiC3qmQkGS7iORhUA9G6h1sWTKWbUsWIaeSCrZPaNctAx5PHHaLBbuPcu6Rnsmkzs1H0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GC+QjOLg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C0D2C43390; Wed, 20 Mar 2024 17:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710956359; bh=+I4HwwOXGb4OTVbce2LLwgvNTP55VKW3XPSef7uX2qU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GC+QjOLgCWd2xCHOfgGMVLPcEchWO055AePCNCuub4yNELWCDEJ2LXQ3wPuRdpWbW 6zS68GkufurAmzHXJlPukCgGffKZAKhn+BvCVZPh1uGOc1x/3fGAaUBVf43pX1j12a 6PPBA0loQz+7M3ep5XFYftdWyRq5doQVVKGb7R71FC339a0qTOT9MOPScoxWDvAfk2 mILf4BeGvDnmqNZXxVxGIiGFRJgVPwP6t2c+jtrls1bi9cFsjEw4+GmojQkAcACnx9 fBXDs4BFv+7RtocNzFtYxn/akzVicQYhk6V0cEuODsLqzVhR+WkurDG9G1dCMjxzED FOi9lFYlChCtA== Date: Wed, 20 Mar 2024 17:39:14 +0000 From: Conor Dooley To: Yangyu Chen Cc: Conor Dooley , Guo Ren , linux-riscv@lists.infradead.org, Damien Le Moal , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/7] riscv: Kconfig.socs: Split ARCH_CANAAN and SOC_CANAAN_K210 Message-ID: <20240320-ideology-pasty-d3aea07cc519@spud> References: <20240306-scowling-mortify-9b427c80e8ab@wendy> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7hxDktwiGEbdrYmU" Content-Disposition: inline In-Reply-To: --7hxDktwiGEbdrYmU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 06, 2024 at 04:14:33PM +0800, Yangyu Chen wrote: >=20 >=20 > > On Mar 6, 2024, at 16:01, Conor Dooley wro= te: > >=20 > > On Wed, Mar 06, 2024 at 07:38:52AM +0800, Guo Ren wrote: > >=20 > >> On Wed, Mar 6, 2024 at 7:04=E2=80=AFAM Yangyu Chen = wrote: > >>>=20 > >>> Since we have Canaan Kendryte K230 with MMU now. The use of SOC_CANAAN > >>> is no longer only referred to K210. Split them and add _K210 suffix > >>> to the name for old SOC_CANAAN. And allows ARCH_CANAAN to be selected > >>> for other Canaan SoCs. > >>>=20 > >>> Signed-off-by: Yangyu Chen > >>> --- > >>> arch/riscv/Kconfig.socs | 8 +++++--- > >>> arch/riscv/Makefile | 2 +- > >>> arch/riscv/configs/nommu_k210_defconfig | 3 ++- > >>> arch/riscv/configs/nommu_k210_sdcard_defconfig | 3 ++- > >>> drivers/clk/Kconfig | 4 ++-- > >>> drivers/pinctrl/Kconfig | 4 ++-- > >>> drivers/reset/Kconfig | 4 ++-- > >>> drivers/soc/Makefile | 2 +- > >>> drivers/soc/canaan/Kconfig | 4 ++-- > >>> 9 files changed, 19 insertions(+), 15 deletions(-) > >=20 > >> This patch cross so many subsystems, I am not sure about it. If I were > >> you, I would keep SOC_CANAAN and just add SOC_CANAAN_K230. > >=20 > > Right. That is why I didn't try to rename the symbol, and just left it > > as SOC_CANAAN, but if the relevant people ack it, the chances of a > > significant conflict are low. > >=20 >=20 > Maybe I should split this patch into different subsystems for better > review. I think at least drivers/soc/Makefile should changed to use > ARCH_CANAAN. Because we need some SoC drivers for K230 in the future. > And arch/riscv/Makefile should use SOC_CANAAN_K210 instead of > ARCH_CANAAN. Because we should avoid the M-Mode loader build for > other Canaan SoCs except for K210. It seems like what Damien requested is pretty much what's done here. Can you resend this CCing the maintainers for clk pinctrl and reset? If you leave a note under the --- line in this patch about wanting acks to take this via riscv, I don't mind picking up this treewide patch if the individual maintainers ack it. I don't think there's likely to be a significant conflict caused by it going through one tree. I got a k230 board (the canmv one) so I should be able to test this myself before picking stuff up. Cheers, Conor. --7hxDktwiGEbdrYmU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZfsfQgAKCRB4tDGHoIJi 0qhpAP0bH5dwSrdhtgZy8odymGeXP5Eu/mXODpURg5Zun0lG/AD9Fuz5Yc320STN idBImdOU5uB7YmUXP6mjgPn82j0uvwY= =j7D0 -----END PGP SIGNATURE----- --7hxDktwiGEbdrYmU--