Received-SPF: pass (google.com: domain of linux-kernel+bounces-109254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e9b6be31-567d-47c2-9cfa-282c8cbcdcf7@quicinc.com>
Date: Wed, 20 Mar 2024 23:21:28 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/4] interconnect: qcom: icc-rpmh: Add QoS
 configuration support
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Georgi
 Djakov" <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>
CC: Kees Cook <keescook@chromium.org>, <cros-qcom-dts-watchers@chromium.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>, <quic_rlaggysh@quicinc.com>,
        <quic_mdtipton@quicinc.com>
References: <20240306073016.2163-1-quic_okukatla@quicinc.com>
 <20240306073016.2163-2-quic_okukatla@quicinc.com>
 <e7105dd7-68ff-4af6-b91e-56b6e50ff949@linaro.org>
From: Odelu Kukatla <quic_okukatla@quicinc.com>
In-Reply-To: <e7105dd7-68ff-4af6-b91e-56b6e50ff949@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 3/6/2024 2:01 PM, Krzysztof Kozlowski wrote:
> On 06/03/2024 08:30, Odelu Kukatla wrote:
>> It adds QoS support for QNOC device and includes support for
>> configuring priority, priority forward disable, urgency forwarding.
>> This helps in priortizing the traffic originating from different
>> interconnect masters at NoC(Network On Chip).
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
>> ---
>>  drivers/interconnect/qcom/icc-rpmh.c | 105 +++++++++++++++++++++++++++
>>  drivers/interconnect/qcom/icc-rpmh.h |  32 ++++++++
>>  2 files changed, 137 insertions(+)
> 
>>  
>> +	if (desc->config) {
>> +		struct resource *res;
>> +		void __iomem *base;
>> +
>> +		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +		if (!res) {
>> +			dev_warn(dev, "Skipping QoS, failed to get resource\n");
> 
> Why is this a warning? If the MMIO is not required, your driver should
> not spawn warnings.
> 

Right, it should not be a warning, will clean it up.

> 
>> +			goto skip_qos_config;
>> +		}
>> +
>> +		base = devm_ioremap(dev, res->start, resource_size(res));
> 
> Combine these two (there's a helper for that).
> 

I will address this in v4.

>> +		if (IS_ERR(base)) {
>> +			dev_warn(dev, "Skipping QoS, ioremap failed: %ld\n", PTR_ERR(base));
>> +			goto skip_qos_config;
>> +		};
>> +
>> +		qp->regmap = devm_regmap_init_mmio(dev, base, desc->config);
>> +
> 
> Drop blank line.
> 
>> +		if (IS_ERR(qp->regmap)) {
>> +			dev_warn(dev, "Skipping QoS, regmap failed; %ld\n", PTR_ERR(qp->regmap));
>> +			goto skip_qos_config;
>> +		}
>> +
>> +		qp->num_clks = devm_clk_bulk_get_all(qp->dev, &qp->clks);
>> +		if (qp->num_clks < 0) {
>> +			dev_warn(dev, "Skipping QoS, failed to get clk: %d\n", qp->num_clks);
> 
> dev_info(), because current binding sais clocks are not required and you
> are not allowed to affect ABI. While ABI here does not look broken,
> spawning new warnings to proper users is not welcomed.
> 

I will convert it to dev_info() in next version. But qp->num_clks = 0 if clock property is not added, so it does not spawn warning.
will move all other dev_warn() to dev_info().

> Best regards,
> Krzysztof
> 

Thanks,
Odelu