Received-SPF: pass (google.com: domain of linux-kernel+bounces-109261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <2c33751e-5995-4be2-a15e-ddca6a6ab4fe@linux.microsoft.com>
Date: Wed, 20 Mar 2024 10:59:22 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] hv/hv_kvp_daemon: Handle IPv4 and Ipv6 combination for
 keyfile format
Content-Language: en-CA
To: Shradha Gupta <shradhagupta@linux.microsoft.com>,
 linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
 Haiyang Zhang <haiyangz@microsoft.com>, Wei Liu <wei.liu@kernel.org>,
 Dexuan Cui <decui@microsoft.com>, Long Li <longli@microsoft.com>,
 Olaf Hering <olaf@aepfle.de>, Ani Sinha <anisinha@redhat.com>,
 Shradha Gupta <shradhagupta@microsoft.com>
References: <1710933451-6312-1-git-send-email-shradhagupta@linux.microsoft.com>
From: Easwar Hariharan <eahariha@linux.microsoft.com>
In-Reply-To: <1710933451-6312-1-git-send-email-shradhagupta@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/20/2024 4:17 AM, Shradha Gupta wrote:
> If the network configuration strings are passed as a combination of IPv4
> and IPv6 addresses, the current KVP daemon does not handle processing for
> the keyfile configuration format.
> With these changes, the keyfile config generation logic scans through the
> list twice to generate IPv4 and IPv6 sections for the configuration files
> to handle this support.
> 
> Testcases ran:Rhel 9, Hyper-V VMs
>               (IPv4 only, IPv6 only, IPv4 and IPv6 combination)
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> ---
>  Changes in v4
>  * Removed the unnecessary memset for addr in the start
>  * Added a comment to describe how we erase the last comma character
>  * Fixed some typos in the commit description
>  * While using strncat, skip copying the '\0' character.
> ---
>  tools/hv/hv_kvp_daemon.c | 181 ++++++++++++++++++++++++++++++---------
>  1 file changed, 140 insertions(+), 41 deletions(-)
> 

<snip>
LGTM

Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>

- Easwar