Received-SPF: pass (google.com: domain of linux-kernel+bounces-109286-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <95045552-dd6c-49b1-ac39-e2d6151e171c@quicinc.com>
Date: Wed, 20 Mar 2024 23:35:32 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Georgi Djakov <djakov@kernel.org>, Rob Herring
	<robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC: Kees Cook <keescook@chromium.org>, <cros-qcom-dts-watchers@chromium.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>, <quic_rlaggysh@quicinc.com>,
        <quic_mdtipton@quicinc.com>
References: <20240306073016.2163-1-quic_okukatla@quicinc.com>
 <20240306073016.2163-3-quic_okukatla@quicinc.com>
 <3bace619-46fc-4f9f-bfb3-4c55cb4d8408@linaro.org>
From: Odelu Kukatla <quic_okukatla@quicinc.com>
In-Reply-To: <3bace619-46fc-4f9f-bfb3-4c55cb4d8408@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 3/6/2024 9:55 PM, Konrad Dybcio wrote:
> 
> 
> On 3/6/24 08:30, Odelu Kukatla wrote:
>> Enable QoS for the master ports with predefined values
>> for priority and urgency.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
>> ---
>>   drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
>>   1 file changed, 332 insertions(+)
>>
>> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
>> index 7d33694368e8..1e1002c4d3d8 100644
>> --- a/drivers/interconnect/qcom/sc7280.c
>> +++ b/drivers/interconnect/qcom/sc7280.c
>> @@ -1,6 +1,7 @@
>>   // SPDX-License-Identifier: GPL-2.0
>>   /*
>>    * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>>    *
>>    */
>>   
>> @@ -16,29 +17,53 @@
>>   #include "icc-rpmh.h"
>>   #include "sc7280.h"
>>   
>> +static const struct qcom_icc_qosbox qhm_qspi_qos = {
>> +	.num_ports = 1,
>> +	.port_offsets = { 0x7000 },
>> +	.prio = 2,
>> +	.urg_fwd = 0,
>> +};
>> +
>>   static struct qcom_icc_node qhm_qspi = {
>>   	.name = "qhm_qspi",
>>   	.id = SC7280_MASTER_QSPI_0,
>>   	.channels = 1,
>>   	.buswidth = 4,
>> +	.qosbox = &qhm_qspi_qos,
> 
> 	.qosbox = &(const struct qcom_icc_qosbox) {
> 		.num_ports = 1,
> 		...
> 	},
>

I would like to keep as it is, it provides better readability for QoS parameters.
 
> 
> 
> Looks sensible otherwise
> 
> Konrad

Thanks,
Odelu