Received-SPF: pass (google.com: domain of linux-kernel+bounces-109320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
To: <dlemoal@kernel.org>, <cassel@kernel.org>, <Markus.Elfring@web.de>
CC: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<git@amd.com>, Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error code
Date: Thu, 21 Mar 2024 00:21:05 +0530
Message-ID: <1710960665-1391654-1-git-send-email-radhey.shyam.pandey@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: None (SATLEXMB04.amd.com: radhey.shyam.pandey@amd.com does not
 designate permitted sender hosts)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 18:51:23.1865
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5724e175-f00e-42c4-c735-08dc490ebd34
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SA2PEPF000015CD.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5627

In the ahci_ceva_probe() error path instead of returning -EINVAL for all
of_property_read_u8_array() failure types return the actual error code.
It removes the redundant -EINVAL assignment at multiple places and
improves the error handling path.

Reported-by: Markus Elfring <Markus.Elfring@web.de>
Closes: https://lore.kernel.org/all/9427c0fd-f48a-4104-ac7e-2929be3562af@web.de/
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 drivers/ata/ahci_ceva.c | 48 ++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
index 11a2c199a7c2..b54ee80c068f 100644
--- a/drivers/ata/ahci_ceva.c
+++ b/drivers/ata/ahci_ceva.c
@@ -274,62 +274,62 @@ static int ceva_ahci_probe(struct platform_device *pdev)
 		cevapriv->flags = CEVA_FLAG_BROKEN_GEN2;
 
 	/* Read OOB timing value for COMINIT from device-tree */
-	if (of_property_read_u8_array(np, "ceva,p0-cominit-params",
-					(u8 *)&cevapriv->pp2c[0], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p0-cominit-params",
+				       (u8 *)&cevapriv->pp2c[0], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p0-cominit-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
-	if (of_property_read_u8_array(np, "ceva,p1-cominit-params",
-					(u8 *)&cevapriv->pp2c[1], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p1-cominit-params",
+				       (u8 *)&cevapriv->pp2c[1], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p1-cominit-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
 	/* Read OOB timing value for COMWAKE from device-tree*/
-	if (of_property_read_u8_array(np, "ceva,p0-comwake-params",
-					(u8 *)&cevapriv->pp3c[0], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p0-comwake-params",
+				       (u8 *)&cevapriv->pp3c[0], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p0-comwake-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
-	if (of_property_read_u8_array(np, "ceva,p1-comwake-params",
-					(u8 *)&cevapriv->pp3c[1], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p1-comwake-params",
+				       (u8 *)&cevapriv->pp3c[1], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p1-comwake-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
 	/* Read phy BURST timing value from device-tree */
-	if (of_property_read_u8_array(np, "ceva,p0-burst-params",
-					(u8 *)&cevapriv->pp4c[0], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p0-burst-params",
+				       (u8 *)&cevapriv->pp4c[0], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p0-burst-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
-	if (of_property_read_u8_array(np, "ceva,p1-burst-params",
-					(u8 *)&cevapriv->pp4c[1], 4) < 0) {
+	rc = of_property_read_u8_array(np, "ceva,p1-burst-params",
+				       (u8 *)&cevapriv->pp4c[1], 4);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p1-burst-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
 	/* Read phy RETRY interval timing value from device-tree */
-	if (of_property_read_u16_array(np, "ceva,p0-retry-params",
-					(u16 *)&cevapriv->pp5c[0], 2) < 0) {
+	rc = of_property_read_u16_array(np, "ceva,p0-retry-params",
+					(u16 *)&cevapriv->pp5c[0], 2);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p0-retry-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
-	if (of_property_read_u16_array(np, "ceva,p1-retry-params",
-					(u16 *)&cevapriv->pp5c[1], 2) < 0) {
+	rc = of_property_read_u16_array(np, "ceva,p1-retry-params",
+					(u16 *)&cevapriv->pp5c[1], 2);
+	if (rc < 0) {
 		dev_warn(dev, "ceva,p1-retry-params property not defined\n");
-		rc = -EINVAL;
 		goto disable_resources;
 	}
 
-- 
2.34.1