Received-SPF: pass (google.com: domain of linux-kernel+bounces-109374-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240320180302.143707-1-arnd@kernel.org> <65fb3fee96ec7_aa222949b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
In-Reply-To: <65fb3fee96ec7_aa222949b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 20 Mar 2024 21:00:55 +0100
Message-ID: <CAJZ5v0ivpUuKGx9pW+QeQPSSXNWSSbJwN2oN9p_hmE-nV5VQKA@mail.gmail.com>
Subject: Re: [PATCH] acpi: EINJ: mark remove callback as non-__exit
To: Dan Williams <dan.j.williams@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, 
	Jonathan Cameron <Jonathan.Cameron@huawei.com>, Ben Cheatham <Benjamin.Cheatham@amd.com>, 
	Arnd Bergmann <arnd@arndb.de>, Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>, 
	Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>, Avadhut Naik <Avadhut.Naik@amd.com>, 
	Shuai Xue <xueshuai@linux.alibaba.com>, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024 at 8:58=E2=80=AFPM Dan Williams <dan.j.williams@intel.=
com> wrote:
>
> Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The remove callback of a device is called whenever it is unbound,
> > which may happen during runtime e.g. through sysfs, so this is not
> > allowed to be dropped from the binary:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0=
x8 (section: .data) -> einj_remove (section: .exit.text)
> > ERROR: modpost: Section mismatches detected.
> >
> > Remove that annotation.
>
> Looks good, not sure why the build robots missed this while this was
> sitting in -next. Yes, this was a side effect of reusing the former
> einj_exit() as the device remove callback.
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Rafael, can you pick this up?

I will, thanks!