Received-SPF: pass (google.com: domain of linux-kernel+bounces-109385-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i5ec1447f:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940
Precedence: bulk
MIME-Version: 1.0
Message-Id: <1006a1d3-86f2-4770-9cf2-4f7e3e12a787@app.fastmail.com>
In-Reply-To: <ebe48668-dfca-775c-880e-dfa333b7e562@linux.intel.com>
References: <20240310233722.30884-1-luke@ljones.dev>
 <ebe48668-dfca-775c-880e-dfa333b7e562@linux.intel.com>
Date: Thu, 21 Mar 2024 09:11:43 +1300
From: "Luke Jones" <luke@ljones.dev>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
 "Hans de Goede" <hdegoede@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: store a min default for ppt options
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable


On Thu, 21 Mar 2024, at 2:13 AM, Ilpo J=C3=A4rvinen wrote:
> On Mon, 11 Mar 2024, Luke D. Jones wrote:
>=20
> > Laptops with any of the ppt or nv tunables default to the minimum se=
tting
> > on boot so we can safely assume a stored value is correct.
> >=20
> > This patch adds storing of those values in the local struct, and ena=
bles
> > reading of those values back.
> >=20
> > Secondary to the above it renames some internal variables to be more
> > consistent (which makes code grepping show all related parts)
> >=20
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
> >  drivers/platform/x86/asus-wmi.c | 141 +++++++++++++++++++++++++----=
---
> >  1 file changed, 111 insertions(+), 30 deletions(-)
> >=20
> > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/=
asus-wmi.c
> > index e4341abb71e0..482e23b55e1e 100644
> > --- a/drivers/platform/x86/asus-wmi.c
> > +++ b/drivers/platform/x86/asus-wmi.c
> > @@ -272,12 +272,19 @@ struct asus_wmi {
> > =20
> >  /* Tunables provided by ASUS for gaming laptops */
> >  bool ppt_pl2_sppt_available;
> > + u32 ppt_pl2_sppt;
> >  bool ppt_pl1_spl_available;
> > + u32 ppt_pl1_spl;
> >  bool ppt_apu_sppt_available;
> > - bool ppt_plat_sppt_available;
> > + u32 ppt_apu_sppt;
> > + bool ppt_platform_sppt_available;
> > + u32 ppt_platform_sppt;
> >  bool ppt_fppt_available;
> > - bool nv_dyn_boost_available;
> > - bool nv_temp_tgt_available;
> > + u32 ppt_fppt;
> > + bool nv_dynamic_boost_available;
> > + u32 nv_dynamic_boost;
> > + bool nv_temp_target_available;
> > + u32 nv_temp_target;
> > =20
> >  bool kbd_rgb_mode_available;
> >  u32 kbd_rgb_dev;
>=20
> Can you check with pahole if this structure is now full of 31-bit hole=
s?
>=20
> The benefit of keeping bool & u32 doesn't seem that big to begin with=20
> (in visual sense because of the 1 char variation in column).

I don't really understand what you mean here. I do most of this stuff wh=
en I have time, so because my time is limited I usually don't have oppor=
tunity to learn much more than the minimum.