Received-SPF: pass (google.com: domain of linux-kernel+bounces-109436-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Vasileios Amoiridis <vassilisamir@gmail.com>
Date: Wed, 20 Mar 2024 22:31:39 +0100
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>, jic23@kernel.org,
	lars@metafoo.de, ang.iglesiasg@gmail.com, mazziesaccount@gmail.com,
	ak@it-klinger.de, petre.rodan@subdimension.ro, phil@raspberrypi.com,
	579lpy@gmail.com, linus.walleij@linaro.org,
	semen.protsenko@linaro.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] iio: pressure: Add timestamp and scan_masks for
 BMP280 driver
Message-ID: <20240320213139.GA52721@vamoiridPC>
References: <20240319002925.2121016-1-vassilisamir@gmail.com>
 <20240319002925.2121016-6-vassilisamir@gmail.com>
 <ZfrDW1ESxnFg__od@smile.fi.intel.com>
 <20240320184516.GB36450@vamoiridPC>
 <ZftJK3cqFNU9-dCG@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZftJK3cqFNU9-dCG@smile.fi.intel.com>

On Wed, Mar 20, 2024 at 10:38:03PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 20, 2024 at 07:45:16PM +0100, Vasileios Amoiridis wrote:
> > On Wed, Mar 20, 2024 at 01:07:07PM +0200, Andy Shevchenko wrote:
> > > On Tue, Mar 19, 2024 at 01:29:24AM +0100, Vasileios Amoiridis wrote:
> 
> ...
> 
> > > > +enum bmp280_scan {
> > > > +	BMP280_TEMP,
> > > > +	BMP280_PRESS,
> > > > +	BME280_HUMID
> > > 
> > > The last is not a terminator, please leave trailing comma.
> > > 
> > > > +};
> > 
> > What do you mean it is not a terminator? In general with the enum
> > variables I would write:
> > 
> > 	enum var { a, b, c };
> 
> This example is different to what you used. I.o.w. _this_ example is okay.
> 
> > Why in this case there is a comma needed after the BME280_HUMID element?
> 
> It's pure style issue that helps to avoid the unneeded churn in the future in
> case the list is getting expanded. You can easily imagine what I mean.
> 

Ok, that definitely makes sense, thank you! In general, should this be applied
to structs as well?

> -- 
> With Best Regards,
> Andy Shevchenko
> 
>