Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp112123lqp; Wed, 20 Mar 2024 15:35:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVniPk+GoivJ4X1hSAgofs8mQOFtQVNB/x29qA++SK9/FW+tgDWFGEAcFwFM6QPA3xHmBOMBUYd0eSkqHiXXEzP3R3+Hx9A4eXXIYALhw== X-Google-Smtp-Source: AGHT+IHQscngEeuofE1Uh92dZw5C0yyxhhrW4RILwjbfVOsusVP9H0SiPg+hSaYUPDs5OR9h01nN X-Received: by 2002:ae9:c206:0:b0:789:e9c1:72a5 with SMTP id j6-20020ae9c206000000b00789e9c172a5mr14501111qkg.7.1710974136966; Wed, 20 Mar 2024 15:35:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710974136; cv=pass; d=google.com; s=arc-20160816; b=U19rIDuINz8owLebN/NqAL/ozAChLcqHlAQGkhvMcAKa4QRY4qZHrlwgIxjN7781hs KihXItZxN2zdIxNwS5GR+uwr1W94Mc437iBbam2yrdkIic01QVFmz2jt0mx/YGImA65s kO73zFTKU5W8E1Dk1CfqDtWeN7FrKQHYp20PQKlOhpV+xhpQ6C7ng9gDHqK/P2n53RKR 7iY4d+d8bOnF1X+3zgYh1DTjOTu9ck0kwH1WJnoQLTUkdnAjFSpMmZw7M/zMlyppkVKl 9Qu0FpKGBwc0sri8QexNMARAJxv0x38a26GlStv9fX48lsVllQCFNClUIxfJqt0nTe1n iZcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=E7i4Ih95/AYaHh8sYn8scPJ9xcj4zGqhtLHoX6z4xCk=; fh=F32RJvPgkm/dNU5Q060LfTFTc35YkDIPw0QV+VJcWH0=; b=zwrYhTIC2nlyF6L0ZewcflMsxC0T2HF0zuMT+vp8ajxyBMXSeusxiyH0et2IGWWURa WNNISIc82EVQpYizBvjF9PlhuL/z95i7NhQ4qGkKerUSZDO3VdRL+OyIMtfqt4fJgbw8 5dT0/oPOJIU+8E9SCRBVDvSRgkqU/OTYTxMR5WSl9Dte9NqQCffsumDapo3/4tMOhiON S03Wjt51M86ribfjv8+XKieHpkF2MIM6C70XS4VvyfXCGpIRJtHRpG0keqVSeIiLyXKw k9YC0tYctlR1ZtqYA7UzE52vWRYaTHUH+gf1RR41gM49d+Yr510Jb1IwNdL2Y2xFaqOv GoQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=uAZ8jKkL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id cx18-20020a05620a51d200b00789f328f40dsi9321991qkb.385.2024.03.20.15.35.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 15:35:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=uAZ8jKkL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AC8141C211F1 for ; Wed, 20 Mar 2024 22:35:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 293AD8615E; Wed, 20 Mar 2024 22:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="uAZ8jKkL" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62AD117562; Wed, 20 Mar 2024 22:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710974113; cv=none; b=kTGxFSNPnfDIGu1WCT5/DtQPQsuTjJZlX5U1HBMkv6ZCwBAGt5A3koGNRPfXUo8f0J33D4I61TT/V6cI/w69y0AyHF9qFhA+ZLEU8nLsdNa/6V8Ai1LUFgSV7wUzomXLzNMyevi41M4dcekswi1vnFs9lAh5DBzHn/SPA+d8ARw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710974113; c=relaxed/simple; bh=rQ9ayU8h3vbhmp2fjgE+N6j3VApmNmtzYBgCEM8r62Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QqB6OMyIORn/aqqftkj/iz7rdCY5yM4oVpJasWgWSeFHwyQ5tJCyu8p4dFUNwDlDgl2QAYGUOdmPrJ+SM8Tp09scIhMICqPWlcJI5OKggICDgNr2ypal+UUUe0KUvjWVEjbqTHG+Yi02LFwOVuibISOJ8BuCrJGUTJ86uuemwjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=uAZ8jKkL; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=E7i4Ih95/AYaHh8sYn8scPJ9xcj4zGqhtLHoX6z4xCk=; b=uAZ8jKkLhRdROnRWFFtuTTT+y4 ABPZrO+Senebtu53YCh8jhIGFSGhz50P90JAEtcdvup+f2UPvpsoKkP6IeaSPOkMuwXrLNnFzRF7P XwPJEvFao/H5w8AXsF33gfVt34ItfGhJbtKdp2gC4TkCQKOzZ3ltGBJaizeRkp8SHhRs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rn4WO-00Aop5-Rj; Wed, 20 Mar 2024 23:34:56 +0100 Date: Wed, 20 Mar 2024 23:34:56 +0100 From: Andrew Lunn To: David Thompson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, u.kleine-koenig@pengutronix.de, leon@kernel.org, asmaa@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths Message-ID: <9e21ceae-e889-4177-8397-9df250ba558d@lunn.ch> References: <20240320193117.3232-1-davthompson@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320193117.3232-1-davthompson@nvidia.com> On Wed, Mar 20, 2024 at 03:31:17PM -0400, David Thompson wrote: > The mlxbf_gige_open() routine starts the PHY as part of normal > initialization. The mlxbf_gige_open() routine must stop the > PHY during its error paths. > > Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver") > Signed-off-by: David Thompson > Reviewed-by: Asmaa Mnebhi Reviewed-by: Andrew Lunn Andrew