Received-SPF: pass (google.com: domain of linux-kernel+bounces-109478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6059f7e5-fd2c-493f-a1dd-acfc7e9e7701@gmail.com>
Date: Wed, 20 Mar 2024 15:59:59 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net V2 2/2] net: lan743x: support WOL in MAC even when PHY
 does not
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>,
 Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
 pabeni@redhat.com, edumazet@google.com, linux-kernel@vger.kernel.org,
 bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com
References: <20240320042107.903051-1-Raju.Lakkaraju@microchip.com>
 <20240320042107.903051-3-Raju.Lakkaraju@microchip.com>
 <22089299-a3e2-4cbd-942a-65ea070657b8@lunn.ch>
From: Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <22089299-a3e2-4cbd-942a-65ea070657b8@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/20/24 15:53, Andrew Lunn wrote:
>> +	if (netdev->phydev) {
>> +		ret = phy_ethtool_set_wol(netdev->phydev, wol);
>> +		if (ret != -EOPNOTSUPP && ret != 0)
>> +			return ret;
> 
> I'm not sure this condition is correct.
> 
> If there is an error, and the error is not EOPNOTSUPP, you want to
> report that error. However, if the PHY can support the WoL
> configuration, it will return 0, and this function should exit, WoL in
> the MAC is not needed. And doing WoL in the PHY consumes less power
> since you can suspend the MAC.
> 
> So i think it should simply be:
> 
>> +		if (ret != -EOPNOTSUPP)
>> +			return ret;

Agreed, that's what I did for bcmgenet_wol.c.
-- 
Florian