Received-SPF: pass (google.com: domain of linux-kernel+bounces-109481-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240319050302.1085006-1-josef@netflix.com> <Zfr1jQ6W6yaLsHID@mtj.duckdns.org>
In-Reply-To: <Zfr1jQ6W6yaLsHID@mtj.duckdns.org>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Wed, 20 Mar 2024 16:05:38 -0700
Message-ID: <CAADnVQJV83CB+ENhRzwNyFbA8rdq3ZGtx6A8Jm7d+Wx9p2rgow@mail.gmail.com>
Subject: Re: [PATCH V3 bpf-next 1/2] bpf: add bpf_task_get_cgroup kfunc
To: Tejun Heo <tj@kernel.org>
Cc: Jose Fernandez <josef@netflix.com>, Alexei Starovoitov <ast@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, 
	Martin KaFai Lau <martin.lau@linux.dev>, Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>, 
	Yonghong Song <yonghong.song@linux.dev>, John Fastabend <john.fastabend@gmail.com>, 
	KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, 
	Jiri Olsa <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@vger.kernel.org>, Tycho Andersen <tycho@tycho.pizza>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024 at 7:41=E2=80=AFAM Tejun Heo <tj@kernel.org> wrote:
>
> On Mon, Mar 18, 2024 at 11:03:01PM -0600, Jose Fernandez wrote:
> > This patch enhances the BPF helpers by adding a kfunc to retrieve the
> > cgroup v2 of a task, addressing a previous limitation where only
> > bpf_task_get_cgroup1 was available for cgroup v1. The new kfunc is
> > particularly useful for scenarios where obtaining the cgroup ID of a
> > task other than the "current" one is necessary, which the existing
> > bpf_get_current_cgroup_id helper cannot accommodate. A specific use
> > case at Netflix involved the sched_switch tracepoint, where we had to
> > get the cgroup IDs of both the prev and next tasks.
> >
> > The bpf_task_get_cgroup kfunc acquires and returns a reference to a
> > task's default cgroup, ensuring thread-safe access by correctly
> > implementing RCU read locking and unlocking. It leverages the existing
> > cgroup.h helper, and cgroup_tryget to safely acquire a reference to it.
> >
> > Signed-off-by: Jose Fernandez <josef@netflix.com>
> > Reviewed-by: Tycho Andersen <tycho@tycho.pizza>
> > Acked-by: Yonghong Song <yonghong.song@linux.dev>
> > Acked-by: Stanislav Fomichev <sdf@google.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> but some questions below
>
> > +__bpf_kfunc struct cgroup *bpf_task_get_cgroup(struct task_struct *tas=
k)
> > +{
> > +     struct cgroup *cgrp;
> > +
> > +     rcu_read_lock();
> > +     cgrp =3D task_dfl_cgroup(task);
> > +     if (!cgroup_tryget(cgrp))
> > +             cgrp =3D NULL;
> > +     rcu_read_unlock();
> > +     return cgrp;
> > +}
>
> So, as this is a lot easier in cgroup2, the above can probably be written
> directly in BPF (untested and not sure the necessary annotations are in
> place, so please take it with a big grain of salt):
>
>         bpf_rcu_read_lock();
>         cgrp =3D task->cgroups->dfl_cgrp;
>         cgrp =3D bpf_cgroup_from_id(cgrp->kn.id);
>         bpf_rcu_read_unlock();
>
> If all you need is ID, it's even simpler:
>
>         bpf_rcu_read_lock();
>         cgrp_id =3D task->cgroups->dfl_cgrp->kn.id;
>         bpf_rcu_read_unlock();

Good point.
Looks like this kfunc isn't really needed.

We even have the following in one of the selftests:
        /* simulate bpf_get_current_cgroup_id() helper */
        bpf_rcu_read_lock();
        cgroups =3D task->cgroups;
        if (!cgroups)
                goto unlock;
        cgroup_id =3D cgroups->dfl_cgrp->kn->id;
unlock:
        bpf_rcu_read_unlock();


> In the first example, it's not great that we go from task pointer to cgro=
up
> pointer to ID and then back to acquired cgroup pointer. I wonder whether
> what we really want is to support something like the following:
>
>         bpf_rcu_read_lock();
>         cgrp =3D bpf_cgroup_tryget(task->cgroups->dfl_cgrp);
>         bpf_rcu_read_unlock();

this one should work already.
that's existing bpf_cgroup_acquire().

pw-bot: cr