Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754503AbYAIMUo (ORCPT ); Wed, 9 Jan 2008 07:20:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752032AbYAIMUe (ORCPT ); Wed, 9 Jan 2008 07:20:34 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:37902 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbYAIMUd (ORCPT ); Wed, 9 Jan 2008 07:20:33 -0500 Date: Wed, 9 Jan 2008 12:20:28 +0000 From: Christoph Hellwig To: Jan Engelhardt Cc: Nikanth Karthikesan , grant@torque.net, tim@cyberelk.net, Christoph Hellwig , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Message-ID: <20080109122027.GA13254@infradead.org> References: <4785B7BC.5040106@suse.de> <20080109080620.GE32560@infradead.org> <1199955347.6203.6.camel@nikanth-laptop.blr.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 13 On Wed, Jan 09, 2008 at 01:14:25PM +0100, Jan Engelhardt wrote: > I wonder why a simple copy_from_user() requires the BKL.. if pt > does need locking, then probably some mutex inside pt. Given this is a janitorial project where the people don't even have the hardware to test it's best to do a 1:1 conversion instead of making it more complex. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/