Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp148394lqp; Wed, 20 Mar 2024 17:10:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW5ym8kEhtcLrQbAgBf+E2JybYmZXR9bvhQeq4Qh9afpeyNkyQogWSBfs7vTv1gVcsaAZUshbPeJX25fHBXJ5mOMdDD7b1d/+Y2WMLDUA== X-Google-Smtp-Source: AGHT+IEtN6QhIDemxSBuc9kJdthVTHL77Ze7C6rFsDPFzf0NGKJjoAgN3UAveu2pru50ZY833QuP X-Received: by 2002:ac8:5cc3:0:b0:431:2306:6149 with SMTP id s3-20020ac85cc3000000b0043123066149mr86399qta.57.1710979848312; Wed, 20 Mar 2024 17:10:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710979848; cv=pass; d=google.com; s=arc-20160816; b=nTZcS6jkG3iyM+gBgTSJiE3r+7cILw1OwaEk9RcxuG8/xT+tIROnJ9Jrq3aJ1kuuCM CRhET+RTXrS7d/opSKT0fwWIx8cVW1cE6StGUvMWB16FMcu4OplIVo9BqxtOYKw0DzeJ 1FeFPt0Oi8sfl5TA9+TFB3F/8PzAgrL0RK+SYtH3PqPNdj4EU3GVQQxuUsZrHU+LhQfv bGBWt3XwvWUym7vcJmfkW1W8W2OXg6cluoQs5UUnuX7jxSGFkRLl0ZBdpFE+Opu7uuIm m42btSw/KxEYumFLejVWvdQ+m1jN7NB8CoHQ7MrORW9y3MtRBGNWATjEvtCcjcacF8Bx u2pQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qYTfryt6uzT4gEzIjPEXIhCxudEshHluSopJ4l+iWUY=; fh=dK5q1+5K3h6mWoDEa7jl8dYP3xDFhMYF5vZ9uVV0gSI=; b=QXkjK/mzYBH+z9jGtZEtLQ4VdzQd+p+q8Fi9rZg4yez2eQ8+86WXPkHkL/bmaixL7C RcYm4qtARR2RkwEIkCYE933L2CZ746VTYjAbaDdZI00gDwMmmN34CZUf2+fbYAgF9nCQ ielwVrhRj14uK8WUQE4oxXyxwiHIR+w9xgM1v/T0yQ1dLOrLQM41dbTY923LZvgWE930 bHvPTnJqhOBhgYFpk7P9bU2rbO7jfvLVcp1IUUfMCmGxJXsTXV65a1QYpldWMETqmD9Z 5EFUnXy37jlivhxlJ4fHsKS/5noIcBfqTWScIuFahu119cCe33XjfNUEBx/CmwduVxoX YRVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1M21YGue; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id n7-20020ac85a07000000b00430b0d12efbsi12507370qta.6.2024.03.20.17.10.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 17:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1M21YGue; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0BF961C21262 for ; Thu, 21 Mar 2024 00:10:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9091617CD; Thu, 21 Mar 2024 00:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1M21YGue" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2001063C; Thu, 21 Mar 2024 00:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710979838; cv=none; b=OpKWK1cgqhN38iWQJeqbKylp1aRRPm74EQwLeizPJ46lxIsCFIUKKS/hmgObIijsT071dOMLgKU5R/dM5iF1bv+O2k75+s6Fx0ryyPpLAqfbSkrbADar9DWbDPNQETVf8Qd3tWljBjrHziGni10y6srsSL36RPMpVrDA+g4me/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710979838; c=relaxed/simple; bh=XF+QbRwExUSVDbOeZC0JJnQAl1pkZTUOdsQR3pkmSpI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W7eHCiZ+siglkHINTQxYNr5r6+NMpk+nPI8PZKnH/s1VXKXzeF8QksIy90uTaCm4e4rHhtZF+rcUyGMOUKrpnUBNhxDdBCaDzLUdWfBdEhqotn552rLKzh1EhXX/5IftaEq7Koowd69EVwNI53MRRKUsyiwaAKUmpbVd08IqjNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=1M21YGue; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=qYTfryt6uzT4gEzIjPEXIhCxudEshHluSopJ4l+iWUY=; b=1M21YGueS2/3kQUt04LM3AquuH xFt8tOZY9vJd4QGqlsHqHTpZ4i0eeGvpb46l+8dzE/idVmoAFThGhkyoGyXyoG4pcRsFiFP9hCm0e 7fm5nbXbnJfZZ1dSecPrO8t+G3HxDYMqNuEtkzBtfJ7YmWBSeslnCy4B/8IQ2vForgp8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rn60k-00ApEo-DT; Thu, 21 Mar 2024 01:10:22 +0100 Date: Thu, 21 Mar 2024 01:10:22 +0100 From: Andrew Lunn To: Elad Nachman Cc: taras.chornyi@plvision.eu, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kory.maincent@bootlin.com, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, przemyslaw.kitszel@intel.com, dkirjanov@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] net: marvell: prestera: enlarge fw restart time Message-ID: <259379aa-e9b9-4524-a092-5338314791d4@lunn.ch> References: <20240320172008.2989693-1-enachman@marvell.com> <20240320172008.2989693-3-enachman@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320172008.2989693-3-enachman@marvell.com> On Wed, Mar 20, 2024 at 07:20:05PM +0200, Elad Nachman wrote: > From: Elad Nachman > > Increase firmware restart timeout, as current timeout value of 5 seconds > was too small, in actual life it can take up to 30 seconds for firmware > to shutdown and for the firmware loader to shift to the ready to receive > firmware code state. So this means the probe can be waiting 30 seconds? This seems like a really good reason not to reset the hardware during -EPROBE_DEFER. Andrew