Received-SPF: pass (google.com: domain of linux-kernel+bounces-109512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 21 Mar 2024 01:13:09 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Elad Nachman <enachman@marvell.com>
Cc: taras.chornyi@plvision.eu, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, kory.maincent@bootlin.com,
	thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com,
	przemyslaw.kitszel@intel.com, dkirjanov@suse.de,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] net: marvell: prestera: force good base mac
Message-ID: <d58e8059-66b7-4545-896a-6194b98000ef@lunn.ch>
References: <20240320172008.2989693-1-enachman@marvell.com>
 <20240320172008.2989693-5-enachman@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240320172008.2989693-5-enachman@marvell.com>

On Wed, Mar 20, 2024 at 07:20:07PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
> 
> The switching ASIC router HW unit MAC Source Address is configured with
> 40-bits of MAC base address in its registers (done in the firmware code),
> requiring all ports doing L3 routing in HW to have the same upper 40-bit
> MAC address.
> 
> Since each switchport MAC address uses the switch base mac address and
> then adds the physical port number to it, Force the last byte of the
> switch base mac address to be at most 127, so when adding to it, we
> will not wrap around the previous (more significant) mac address byte,
> resulting in a warning message.
> 
> Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
> Signed-off-by: Elad Nachman <enachman@marvell.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew