Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp149665lqp; Wed, 20 Mar 2024 17:14:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNeOEQPpVk5TNyWN73gpQ+tsUxWUtDOLhOvTEzU7wSDZfgK0rAFZ500VBbrHiU8OcamCRJFTv4qcR1YUGmowA33EV42dKaPYoUeMknAg== X-Google-Smtp-Source: AGHT+IGK6c3FniYGoyFuEfyi08Vt71KPqfoCez1jcqH3NIJnX8cswg04tzfCzQdujNSlgBPLvyxB X-Received: by 2002:a17:902:e9cc:b0:1df:f8a4:5485 with SMTP id 12-20020a170902e9cc00b001dff8a45485mr552242plk.57.1710980053393; Wed, 20 Mar 2024 17:14:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710980053; cv=pass; d=google.com; s=arc-20160816; b=FC4RYXMkGpwjynR0spKkujtAyV/dVK7lBWD2wxAGDOUc9sDJ6XxfhSnz/VtcqBmR2V uipu0y6VD74F02IIYvtmFovNuYD9h9x3m9Wu6aEwefwc0YqLYMmL+Y/LigVEUmyv5siA mKR4U3k0ag4FUxJ2tPvLForsbGEC26ywS3KigqqZOXgoqhpfBz1WcOAIhWrPyKg/3BNI FrRq0WixiV4WjC+WM58RZi1g3tx+/uHBcUVAWalS5DdRVZaVGK+DcZnmroi5uSyMXPCD dcij0fgbR0ONz7Pygv7bLN/QUAvFhoDRKXhpp6QgqtlHIWkih7t+iSV1oLRWM4KPbHOv 8tLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YxRIA795DUfjJPHRguMNE/KtiSNi+tYHAEz8Wqm1/Ws=; fh=dK5q1+5K3h6mWoDEa7jl8dYP3xDFhMYF5vZ9uVV0gSI=; b=eerG4zubpoS2DQJVRWO7mw7vzI29L3+XMges6pIWR5qqUiQgY5ZHniRah6TbPkTbQi sz0Cua/JqfvMleL+kxpuW7/S4HtNe2+7sdyEc77GGtfGG8d1ORa0YLgCEXcutgjUArc0 HV7RXGiKsWWySQAmFxZuNR46qQNlx9ppw7C4WERZm/Z7k404O6sDyN0V3m7k2Iha5tm5 b7h2oRDDiZzBJAjv/Q93nisg7uM1dDFiMIk4J1GV5bwJAeD3LQeysTcoT6F7kTyGcfxq Xx3myFK8ujXgsvPYTJjzvC8MSVpoDWIAGy2FsCljEgfMVM+sbc/uxvyHerqEsub9Wuu2 FKBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KEOMcEn3; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109513-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109513-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v11-20020a170902f0cb00b001dddcb9aaacsi13272188pla.622.2024.03.20.17.14.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 17:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109513-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KEOMcEn3; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-109513-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109513-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 154CB2836D5 for ; Thu, 21 Mar 2024 00:14:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6844D17F7; Thu, 21 Mar 2024 00:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KEOMcEn3" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AEE1370; Thu, 21 Mar 2024 00:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710980043; cv=none; b=OcxfTTp2n9yuXytV2Q1jGP3+sIniSw+OhC663Q8/tiCLlBH06q5mLdf6xFV+EWyoMBdj21YCYtDtzaCnhSa6fK8dVG/MkAaRUr/qI8IuUvaLQw0tdFo3tK5IFqdgWAOSDY5Q53S9OMWQwx+VNHc55H7Me1RiArwQp1cN5CTfQjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710980043; c=relaxed/simple; bh=EoA8/0mAlNhT0TMql29QIH/To0Z4Mj6i7EIGx21gk2Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PaVby27W8n0fE3ZVzhkaxTz97ikbT8XE0xZ+B+UYnMH16R5HxuotNO2DBwHdMy5A00yULZ2wasjmoytVEVHw2+9uUaFLdVbdWIgGQcDXHkeyvjXInJtNGytVq7quumqP1AftF4JNyhV0wrlPUhrS03+aZNqaPMjoUu1Pm2F67YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=KEOMcEn3; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=YxRIA795DUfjJPHRguMNE/KtiSNi+tYHAEz8Wqm1/Ws=; b=KE OMcEn31ptc7LQKoPC+shqiRuiNN4+L3t3CKqJJguSWQhmXin0TiD5sJfBRI1KQQeV1RDd3DRnfmKm 58aDt3Y75wmo9WLt5AdSmDat2vyH5dE2ZX6FjsZ8zUj8syq3/8WF4lnwO8Qhkvi9nuyEVRWuCoOLG IXaR398SB1DTc7s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rn647-00ApHH-UA; Thu, 21 Mar 2024 01:13:51 +0100 Date: Thu, 21 Mar 2024 01:13:51 +0100 From: Andrew Lunn To: Elad Nachman Cc: taras.chornyi@plvision.eu, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kory.maincent@bootlin.com, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, przemyslaw.kitszel@intel.com, dkirjanov@suse.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] net: marvell: prestera: unbind sfp port on exit Message-ID: References: <20240320172008.2989693-1-enachman@marvell.com> <20240320172008.2989693-6-enachman@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240320172008.2989693-6-enachman@marvell.com> On Wed, Mar 20, 2024 at 07:20:08PM +0200, Elad Nachman wrote: > From: Elad Nachman > > Call unbinding of the sfp port when ports are released, This will call > phylink_destroy() to cleanup and destroy the phylink instance, needed > to unregister SFP and free used memory, which will otherwise leak. > > Reported-by: K?ry Maincent > Closes: https://lore.kernel.org/lkml/20240312164526.4a0e242a@kmaincent-XPS-13-7390/ > Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices") > Signed-off-by: Elad Nachman Reviewed-by: Andrew Lunn Andrew