Received-SPF: pass (google.com: domain of linux-kernel+bounces-109536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 21 Mar 2024 09:30:12 +0800
From: Chao Gao <chao.gao@intel.com>
To: <isaku.yamahata@intel.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
Subject: Re: [PATCH v19 043/130] KVM: TDX: create/free TDX vcpu structure
Message-ID: <ZfuNpI1fiUr4h27+@chao-email>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <51c4203e844159451f5a78fb18cc5bebcc38a76e.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <51c4203e844159451f5a78fb18cc5bebcc38a76e.1708933498.git.isaku.yamahata@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KolWOErI0WCDeMfTPNuZcbDVDcHb4eabfTZWg1sYB/DQb+/pEMToGa0/c0Q2?=
 =?us-ascii?Q?xYiOvDsQkjIpJzN0gsRi+QJ+utd6yMYt+yZZxDHpQ29/dR1enybqZjRUrJO/?=
 =?us-ascii?Q?iS1jX0PIp2F9kIUM24gwit7za3qtydgXm0jWA2eUVOmF/7vkcBUKezA20cw1?=
 =?us-ascii?Q?kA3IUwsJ209bgWxb1vT96Ya6Gsv7xvq1cFgzXgaCildfQe4B1fMrCJ0/pAsH?=
 =?us-ascii?Q?PWYHyjh+uiW89bGrzLa+75hW8bAxRj3nG70j06vqwhf1oUyvYgvNs4w4m6Ow?=
 =?us-ascii?Q?s5DftVQekJfMYR3cmMFcxasm13nacCeQhlz6J1yLolUAm0/MfGFnoFUN8DIq?=
 =?us-ascii?Q?Iw5tyqKYM3o2a0I1PnrJonzLK9JQCWPGhbs8NuBOkyuX5oiM14g/4u3utwp9?=
 =?us-ascii?Q?2lVbP+R4Fa8i4owXgANUFmG7H6MQKlnwjJE6mYvvycnrRrLzXq2/lGNzBdAA?=
 =?us-ascii?Q?5Xp1DIZYEkMMtzb7HQ1DbWwa0Q/k/FJd/njfRbqHTb+ylYOCWqy8KfqmOeWO?=
 =?us-ascii?Q?pJF9pf5mQcJBjxpb7VKGctZpE707kX7ofcKF2JGmdY/id0vKq0Q2J8zvY6HH?=
 =?us-ascii?Q?TWGT1wzIdL/xcyLpAwDJxfg3LVLH22IYiGoW+vaYQGW/xTzspKKbEucnXcpR?=
 =?us-ascii?Q?Kx2p7/NYHn4xL0guFtMChvS9BiuxfXvnKkocLkPLLC4EQ8y18TV2q2RTwvfp?=
 =?us-ascii?Q?lVQzfUEOq505hlMK1Pmln+xaO5lMlF0dQGA7YEdVs+aFprTig+YJHKgY9HFF?=
 =?us-ascii?Q?qOtc8VOFKtj6+ebJRt13akZE5J/xSMoMzurpXrxrdg/OTvvXA13x4usImr4+?=
 =?us-ascii?Q?u6qmHISOFBlW4OLr6NsNossPsWD0GOdHzL428HJWEWzGhXfrE1Jy6H5lS5ZK?=
 =?us-ascii?Q?WlJ/e8fkvYEEAb1IjehaQWIv3FmDN2he+o++0v5o57HT5VZ9eivJjvkVU89j?=
 =?us-ascii?Q?WeM2fGEjrsaMT8UVchWJK2u5N4bDEipn8k/h7RI5USm3LLZPyllXb/OamE8d?=
 =?us-ascii?Q?8Wmplt8/v3hxLK+75M2ACAcnhAFL1fdELmxGtxBpUWmxXML4ExKXJkWx9Rbn?=
 =?us-ascii?Q?CEOU4Dfs7krOZYQpTtNqlEM667cddDr3DV1ttWkndU82jqbHKFH6CVCYWxO+?=
 =?us-ascii?Q?UvHI5KsYp+YzbNFeTU9LFMmLJR8fKoRnNWsCGdaFtLcMfNvD6IuOniN5CeeP?=
 =?us-ascii?Q?IChyxXs82sRqnwAS6gch69AwTH6aS4uC0d2nXK07aXF41/3L3TomrzK/5PBi?=
 =?us-ascii?Q?PShlyf+krmGeMW9YJ8lPccQTjWDwxtFtLEy1GAJ2SbDqfWfVOgNwh6ALnZHo?=
 =?us-ascii?Q?bxtJJd2XuXpy6ZhZXMi2N8GY9g/WDBzVjqiAS+Sj9J5sXJNdkkdCmpWIroDC?=
 =?us-ascii?Q?hLpP37gff66uKU0i4SYvFv9lf62XZl6LsEOnnbSZWRPlCtLy18l7H5ayO6qH?=
 =?us-ascii?Q?P9v0Q9DVS+WyHq9+CCby6B46OwD1oetdiJb13JaxJW2H65qNuAGyC5dzIo+p?=
 =?us-ascii?Q?cq7dZPRpJXCQKwgZPWuhonUyJ5MN8xBn8Yc6C0AxIjZTyxN4KMZKoxZOfLpy?=
 =?us-ascii?Q?whq/EA/kkea7Em1Mf7nlX4zvpcGLB9NqapqudaV8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25186bc7-cec1-43be-37c9-08dc49467991
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 01:30:21.8964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9ZlUjsSfde7jBgRMqy3qmTMz68ZGzPSwvAewVm+Jp2SOatn/qr4ZxwKtkMiGFzWKQJ8pL13CqjjNzn37h/MBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4516
X-OriginatorOrg: intel.com

>+int tdx_vcpu_create(struct kvm_vcpu *vcpu)
>+{
>+	struct kvm_tdx *kvm_tdx = to_kvm_tdx(vcpu->kvm);
>+
>+	WARN_ON_ONCE(vcpu->arch.cpuid_entries);
>+	WARN_ON_ONCE(vcpu->arch.cpuid_nent);
>+
>+	/* TDX only supports x2APIC, which requires an in-kernel local APIC. */

Cannot QEMU emulate x2APIC? In my understanding, the reason is TDX module always
enables APICv for TDs. So, KVM cannot intercept every access to APIC and forward
them to QEMU for emulation.

>+	if (!vcpu->arch.apic)

will "if (!irqchip_in_kernel(vcpu->kvm))" work? looks this is the custome for such
a check.

>+		return -EINVAL;
>+
>+	fpstate_set_confidential(&vcpu->arch.guest_fpu);
>+
>+	vcpu->arch.efer = EFER_SCE | EFER_LME | EFER_LMA | EFER_NX;
>+
>+	vcpu->arch.cr0_guest_owned_bits = -1ul;
>+	vcpu->arch.cr4_guest_owned_bits = -1ul;
>+
>+	vcpu->arch.tsc_offset = to_kvm_tdx(vcpu->kvm)->tsc_offset;

kvm_tdx->tsc_offset;

>+	vcpu->arch.l1_tsc_offset = vcpu->arch.tsc_offset;
>+	vcpu->arch.guest_state_protected =
>+		!(to_kvm_tdx(vcpu->kvm)->attributes & TDX_TD_ATTRIBUTE_DEBUG);

!(kvm_tdx->attributes & TDX_TD_ATTRIBUTE_DEBUG);

>+
>+	if ((kvm_tdx->xfam & XFEATURE_MASK_XTILE) == XFEATURE_MASK_XTILE)
>+		vcpu->arch.xfd_no_write_intercept = true;
>+
>+	return 0;
>+}