Received-SPF: pass (google.com: domain of linux-kernel+bounces-109543-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1c8e6fbc-ef1b-49fb-9d3e-b163a58cee10@gmail.com>
Date: Thu, 21 Mar 2024 09:47:26 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 09/11] mm/ksm: Convert stable_tree_search to use folio
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>, alexs@kernel.org
Cc: Izik Eidus <izik.eidus@ravellosystems.com>,
 Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>,
 Chris Wright <chrisw@sous-sol.org>, kasong@tencent.com,
 Andrew Morton <akpm@linux-foundation.org>,
 "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240320074049.4130552-1-alexs@kernel.org>
 <20240320074049.4130552-10-alexs@kernel.org>
 <ZfsAEl5nipppfeLx@casper.infradead.org>
From: Alex Shi <seakeel@gmail.com>
In-Reply-To: <ZfsAEl5nipppfeLx@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 3/20/24 11:26 PM, Matthew Wilcox wrote:
> On Wed, Mar 20, 2024 at 03:40:45PM +0800, alexs@kernel.org wrote:
>> @@ -1820,28 +1820,30 @@ static struct page *stable_tree_search(struct page *page)
>>  	struct rb_node *parent;
>>  	struct ksm_stable_node *stable_node, *stable_node_dup, *stable_node_any;
>>  	struct ksm_stable_node *page_node;
>> +	struct folio *folio;
>>  
>> -	page_node = page_stable_node(page);
>> +	folio = (struct folio *)page;
> 
> These casts make me nervous.  Remember that we're heading towards a
> future where struct page and struct folio don't point to the same
> memory, and part of that will be finding all these casts and removing
> them.  Please, unless there's a good reason, just use page_folio().
> 

Hi willy,

Thanks a lot for all comments. Yes，all of them are very right. I will rewrite and send the patchset.

Best Regards!
Alex