Received-SPF: pass (google.com: domain of linux-kernel+bounces-109553-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240320193115.811899-1-acme@kernel.org> <20240320193115.811899-6-acme@kernel.org>
In-Reply-To: <20240320193115.811899-6-acme@kernel.org>
From: Ian Rogers <irogers@google.com>
Date: Wed, 20 Mar 2024 18:50:50 -0700
Message-ID: <CAP-5=fWw9n=b02KOvh=OuWrSx0KgUikPdnhs70DHNqNsG6mWPA@mail.gmail.com>
Subject: Re: [PATCH 5/5] perf trace: Fix 'newfstatat'/'fstatat' argument
 pretty printing
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org, 
	linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024 at 12:31=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> There were needless two entries, one for 'newfstatat' and another for
> 'fstatat', keep just one and pretty print its 'flags' argument using the
> fs_at_flags scnprintf that is also used by other FS syscalls such as
> 'stat', now:
>
>   root@number:~# perf trace -e newfstatat --max-events=3D5
>        0.000 ( 0.010 ms): abrt-dump-jour/1400 newfstatat(dfd: 7, filename=
: "", statbuf: 0x7fff0d127000, flag: EMPTY_PATH) =3D 0
>        0.020 ( 0.003 ms): abrt-dump-jour/1400 newfstatat(dfd: 9, filename=
: "", statbuf: 0x55752507b0e8, flag: EMPTY_PATH) =3D 0
>        0.039 ( 0.004 ms): abrt-dump-jour/1400 newfstatat(dfd: 19, filenam=
e: "", statbuf: 0x557525061378, flag: EMPTY_PATH) =3D 0
>        0.047 ( 0.003 ms): abrt-dump-jour/1400 newfstatat(dfd: 20, filenam=
e: "", statbuf: 0x5575250b8cc8, flag: EMPTY_PATH) =3D 0
>        0.053 ( 0.003 ms): abrt-dump-jour/1400 newfstatat(dfd: 22, filenam=
e: "", statbuf: 0x5575250535d8, flag: EMPTY_PATH) =3D 0
>   root@number:~#
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-trace.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index ef0dfffd99fdf3cc..d3ec244e692a415e 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -978,7 +978,6 @@ static const struct syscall_fmt syscall_fmts[] =3D {
>                    [1] =3D { .scnprintf =3D SCA_FILENAME,     /* path */ =
},
>                    [2] =3D { .scnprintf =3D SCA_FSPICK_FLAGS, /* flags */=
 }, }, },
>         { .name     =3D "fstat", .alias =3D "newfstat", },
> -       { .name     =3D "fstatat", .alias =3D "newfstatat", },
>         { .name     =3D "futex",
>           .arg =3D { [1] =3D { .scnprintf =3D SCA_FUTEX_OP, /* op */ },
>                    [5] =3D { .scnprintf =3D SCA_FUTEX_VAL3, /* val3 */ },=
 }, },
> @@ -1060,8 +1059,10 @@ static const struct syscall_fmt syscall_fmts[] =3D=
 {
>           .arg =3D { [0] =3D { .scnprintf =3D SCA_FDAT, /* dfd */ }, }, }=
,
>         { .name     =3D "nanosleep",
>           .arg =3D { [0] =3D { .scnprintf =3D SCA_TIMESPEC,  /* req */ },=
 }, },
> -       { .name     =3D "newfstatat",
> -         .arg =3D { [0] =3D { .scnprintf =3D SCA_FDAT, /* dfd */ }, }, }=
,
> +       { .name     =3D "newfstatat", .alias =3D "fstatat",
> +         .arg =3D { [0] =3D { .scnprintf =3D SCA_FDAT,         /* dirfd =
*/ },
> +                  [1] =3D { .scnprintf =3D SCA_FILENAME,     /* pathname=
 */ },
> +                  [3] =3D { .scnprintf =3D SCA_FS_AT_FLAGS, /* flags */ =
}, }, },
>         { .name     =3D "open",
>           .arg =3D { [1] =3D { .scnprintf =3D SCA_OPEN_FLAGS, /* flags */=
 }, }, },
>         { .name     =3D "open_by_handle_at",
> --
> 2.44.0
>