Received-SPF: pass (google.com: domain of linux-kernel+bounces-109608-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <tencent_BF745A1543ABB0579DFC20480AA1A4456307@qq.com>
From: linke li <lilinke99@qq.com>
To: chengming.zhou@linux.dev
Cc: 42.hyeyoo@gmail.com,
	akpm@linux-foundation.org,
	cl@linux.com,
	iamjoonsoo.kim@lge.com,
	lilinke99@qq.com,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	penberg@kernel.org,
	rientjes@google.com,
	roman.gushchin@linux.dev,
	vbabka@suse.cz
Subject: Re: [PATCH] mm/slub: mark racy accesses on slab->slabs
Date: Thu, 21 Mar 2024 10:48:11 +0800
In-Reply-To: <8bc1aebf-8395-416f-8c23-53cbd25d0eef@linux.dev>
References: <8bc1aebf-8395-416f-8c23-53cbd25d0eef@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Sorry for a late reply, I just found this because of my bad email client.

> There is another unmarked access of "slab->slabs" in the show_slab_objects(),
> which you can change too.

Yes, I think show_slab_objects() has a similar situation. Should I
consider to submit a V2 patch for this?

> I'm not sure that it's really safe to access "slab->slabs" here without any protection?
> Although it should be no problem in practice, alternative choice maybe putting partial
> slabs count in the kmem_cache_cpu struct.

I think it is ok, because it seems that slab->slabs in slub_percpu_partial
and show_slab_objects() are just used for showing some infomation.

I noticed Paul summarized some of these strategies in access-marking.txt[1]

Quote from it:

"Use of the data_race() Macro
----------------------------

Here are some situations where data_race() should be used instead of
READ_ONCE() and WRITE_ONCE():

1.	Data-racy loads from shared variables whose values are used only
	for diagnostic purposes.

2.	Data-racy reads whose values are checked against marked reload.

3.	Reads whose values feed into error-tolerant heuristics.

4.	Writes setting values that feed into error-tolerant heuristics.
"

Thanks,
Linke

[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/memory-model/Documentation/access-marking.txt