Received-SPF: pass (google.com: domain of linux-kernel+bounces-109617-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <62b4dd34-bf05-4da6-94ea-cb85ac48bbeb@linux.dev>
Date: Thu, 21 Mar 2024 11:12:20 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] mm/slub: mark racy accesses on slab->slabs
Content-Language: en-US
To: linke li <lilinke99@qq.com>
Cc: 42.hyeyoo@gmail.com, akpm@linux-foundation.org, cl@linux.com,
 iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev,
 vbabka@suse.cz
References: <8bc1aebf-8395-416f-8c23-53cbd25d0eef@linux.dev>
 <tencent_BF745A1543ABB0579DFC20480AA1A4456307@qq.com>
From: Chengming Zhou <chengming.zhou@linux.dev>
In-Reply-To: <tencent_BF745A1543ABB0579DFC20480AA1A4456307@qq.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/3/21 10:48, linke li wrote:
> Sorry for a late reply, I just found this because of my bad email client.
> 
>> There is another unmarked access of "slab->slabs" in the show_slab_objects(),
>> which you can change too.
> 
> Yes, I think show_slab_objects() has a similar situation. Should I
> consider to submit a V2 patch for this?

Yes, I think so.

> 
>> I'm not sure that it's really safe to access "slab->slabs" here without any protection?
>> Although it should be no problem in practice, alternative choice maybe putting partial
>> slabs count in the kmem_cache_cpu struct.
> 
> I think it is ok, because it seems that slab->slabs in slub_percpu_partial
> and show_slab_objects() are just used for showing some infomation.
> 
> I noticed Paul summarized some of these strategies in access-marking.txt[1]

Ok, thanks.

> 
> Quote from it:
> 
> "Use of the data_race() Macro
> ----------------------------
> 
> Here are some situations where data_race() should be used instead of
> READ_ONCE() and WRITE_ONCE():
> 
> 1.	Data-racy loads from shared variables whose values are used only
> 	for diagnostic purposes.
> 
> 2.	Data-racy reads whose values are checked against marked reload.
> 
> 3.	Reads whose values feed into error-tolerant heuristics.
> 
> 4.	Writes setting values that feed into error-tolerant heuristics.
> "
> 
> Thanks,
> Linke
> 
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/memory-model/Documentation/access-marking.txt
>