Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp214630lqp; Wed, 20 Mar 2024 20:39:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWUOiTeHzvAlSgAFxYymgv0yTGf0Pz3ArRP3s7nHK+YnMT0AP5jLCg3eaO40T2hpHQ5Y2FXXT1oovAJyWEQzla4KzICNCYHO5aR23h+ng== X-Google-Smtp-Source: AGHT+IEZyb0hFsQFKmS/wGJ6UkZmP5aPs40UhrxPAgZaro2Kib4Yyb11+b5Y71hxdiQtN+2sdc1G X-Received: by 2002:a05:6a00:1888:b0:6e8:ad8d:555d with SMTP id x8-20020a056a00188800b006e8ad8d555dmr4146871pfh.20.1710992391884; Wed, 20 Mar 2024 20:39:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710992391; cv=pass; d=google.com; s=arc-20160816; b=prM4RjZODVo6QDpGX5ivBFfsGjOWWCjjzyldC/EDQSYe4s74ltY9fAS9As+CZN59Wv JfkDgjakLGz+4ReQMDosbtNSD8+UrehsKopOpsrOOq1P+vLDGzGUvJrSORrEG63qAoXu cZrYU0tagCp4nWk30HlSIDHddGt8p1ANdJYtGDW6lRiPGBrS8huZSWUWMVMp5EuAPALl muhq1JHdNe+JuOMc48Ua5i3MMdopTC85GaH5qHcg4Z1rlpf7zJgKPviu9lhfxhtsLmpJ 2+jTm8G9fKGLMsXDcdoK2SkTJ3MyrEzjp4EdNl+vQuvFfAyUlGy7HtNKDhL5aX41N8wY KiBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=F/jUSqUwwSLsnS6naYcHAWxwzilQGJ4Hx4vEAYIHYFo=; fh=Zo93N/+uWamhDsiEX2Ys8dnaGjwdAfDKtHmarLfbD2I=; b=EHAQfuYrOVRNCs+1co6eicjGDQ4ex2cn9EX/FBGqWYRm+Q1LNZA6oDobj+lUyBIs6Q lheqxtvmssp2N5iOJ1ybExi4RYCJdh+j8TKTb3gqSHmClfDflI3MUA+PlAFGIoGMbsxA 58pe60itL983xJ1C4S4QYi6CJz9ivdQjnoLK3j9BYXEQ7kHsGKVYuQYwnhOZIE3ms6zW NoBu2XXroi9fSqfWrj3ue5kkwnExiqI72ZvmQXmot0sKsH9IS5bXKTDc5Fw1TZpBWFfo 8s1FVFz4yr7CYJ5mN5hYAa6aMA0Rz7LNOVHwm/B1ltPV3pDYy1j/rQSarWzauDlqPtOE Vs8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WO0sjH0V; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109626-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a15-20020a056a000c8f00b006e73f884194si5614803pfv.325.2024.03.20.20.39.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 20:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WO0sjH0V; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109626-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8E162283BEC for ; Thu, 21 Mar 2024 03:39:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F912BA45; Thu, 21 Mar 2024 03:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WO0sjH0V" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFE26D39; Thu, 21 Mar 2024 03:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710992382; cv=none; b=U3OYtAYfOM107XsGUQeHlLUBiBgkGaSIGMg3+jKnaBXbO6CEFhq5Cz8+PDzzof2kQu4i5nuE9RkY1akdSR+l8rTA26YrMhq5vI3liFjAXTBEwAib1UDEvys/48sGhqbf+MkIT/hCbs7D9U10pFpS8CG+ThsVG6fSItCvCk9Vl0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710992382; c=relaxed/simple; bh=NgxJz8/GSPa4b2iJMDM324FgVNSenq+WPseRkTzNdB4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cqQaSneZkvgQFkMsZbHVZumiosHNf+1WMsIDXNnu9XZgs7Bynsba7jUMujmxqaUVnMALEYEvRfKy487vbwmLjDlEgA7BsViPRQnAChfSpIv7ZgdEBBjCdwht3QcAa/1+oAK5/iVjK4QBbcsXZvbO7ZVLa4H9g5CFUiSy+9mqLaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WO0sjH0V; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11CF7C433C7; Thu, 21 Mar 2024 03:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710992382; bh=NgxJz8/GSPa4b2iJMDM324FgVNSenq+WPseRkTzNdB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WO0sjH0Vx1fxUpvANddcEPbuwbR5R7WVdXvtLu7J4iz/mOoOWiC+YTwZuwFessUx4 PMJvmYtGnczzaTFdpvkxHDBxAwKVVZvBHhRF75zU6HRytv27TUFrnCqCXy7dcAGsDf pNzE5k4bfBlJHk2U750GvZTwKOi1QR2YmU5m6XEb7wBjZE4MsEWaNC+pVQYQwjZWnA vcpeFizWoXOYHQpBFVeyhFHHIV30/KpJ/r1cCzQlKT5PxFf2KQ1Ol7bscPk9vX6Omi K6ifnJuMeqx0ICSc42T4L2tymHMIOFvi0t7iR/Pv94N9wqNh/JqdtPQMvpnqGxF/7+ lzhe549sbEefA== Date: Wed, 20 Mar 2024 20:39:41 -0700 From: Jakub Kicinski To: Nicolas Cavallari Cc: "David S. Miller" , David Ahern , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: delay procfs initialization after the ipv6 structs are ready Message-ID: <20240320203941.70facba3@kernel.org> In-Reply-To: <20240320171858.2671-1-nicolas.cavallari@green-communications.fr> References: <20240320171858.2671-1-nicolas.cavallari@green-communications.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Mar 2024 18:17:36 +0100 Nicolas Cavallari wrote: > procfs files are created before the structure they reference are > initialized. For example, if6_proc_init() creates procfs files that > access structures initialized by addrconf_init(). > > If ipv6 is compiled as a module and a program manages to open an ipv6 > procfs file during the loading of the module, it can oops the kernel. > > It appears that we were unlucky enough to reproduce this problem > multiple times already, out of maybe 100 boots: I haven't investigated too closely but looks like this breaks all selftests. Please run all net/forwarding selftests before posting v2?