Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbYAIN1R (ORCPT ); Wed, 9 Jan 2008 08:27:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752008AbYAIN0o (ORCPT ); Wed, 9 Jan 2008 08:26:44 -0500 Received: from twin.jikos.cz ([213.151.79.26]:51121 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbYAIN0l (ORCPT ); Wed, 9 Jan 2008 08:26:41 -0500 Date: Wed, 9 Jan 2008 14:26:26 +0100 (CET) From: Jiri Kosina To: Matthew Wilcox cc: Nikanth Karthikesan , grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl In-Reply-To: <20080109123311.GP16309@parisc-linux.org> Message-ID: References: <4785B7BC.5040106@suse.de> <4785C7D8.2020808@suse.de> <20080109123311.GP16309@parisc-linux.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 26 On Wed, 9 Jan 2008, Matthew Wilcox wrote: > > default: > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > > + unlock_kernel(); > > return -EINVAL; > Surely a bug ... shouldn't this return -ENOTTY? What POSIX states [1]: [EINVAL] The request or arg argument is not valid for this device. [ENOTTY] The fildes argument is not associated with a STREAMS device that accepts control functions. [1] http://www.opengroup.org/onlinepubs/009695399/functions/ioctl.html -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/