Date: Wed, 9 Jan 2008 14:33:23 +0100
From: Andre Noll <maan@systemlinux.org>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org, paolo.ciarrocchi@gmail.com,
       gorcunov@gmail.com
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Message-ID: <20080109133323.GD16462@skl-net.de>
References: <20080108164015.GC31504@one.firstfloor.org> <20080109103459.GC16462@skl-net.de> <4784C96D.5030805@student.ltu.se>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XvKFcGCOAo53UbWW"
Content-Disposition: inline
In-Reply-To: <4784C96D.5030805@student.ltu.se>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1153
Lines: 49


--XvKFcGCOAo53UbWW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14:17, Richard Knutsson wrote:

> Would had preferred:
>=20
> if (x) {
>    result =3D -Exxxx;
>    goto out;
> }
>=20
> then:
>=20
> result =3D -Exxxx;
> if (x)
>    goto out;
>=20

AFAIK, the second form is preferred in Linux because it is better
readable and it generates slightly better code.

Thanks for the review.
Andre
--=20
The only person who always got his work done by Friday was Robinson Crusoe

--XvKFcGCOAo53UbWW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFHhM0jWto1QDEAkw8RAhw8AJ4x2Jt2rknSfKQRxn8+4/t1ly+WAgCfZNRr
vBjDHDAL+TsEaBbDDD6ZnHQ=
=n25R
-----END PGP SIGNATURE-----

--XvKFcGCOAo53UbWW--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/