Received-SPF: pass (google.com: domain of linux-kernel+bounces-109752-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Mar 2024 09:09:00 +0100
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, Alison Schofield <alison.schofield@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-cxl@vger.kernel.org, Derick Marks <derick.w.marks@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 1/3] x86/numa: Fix SRAT lookup of CFMWS ranges with
 numa_fill_memblks()
Message-ID: <ZfvrHAQ9GMQ9aJlk@rric.localdomain>
References: <20240319120026.2246389-1-rrichter@amd.com>
 <20240319120026.2246389-2-rrichter@amd.com>
 <65f9f2741e607_7702a294f7@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65f9f2741e607_7702a294f7@dwillia2-xfh.jf.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?T2KNd4ZaHc1lwaFbxm+b2U5kqWvqvZBRYavw3oUo3AOWiKUoFudcJbsBwGHs?=
 =?us-ascii?Q?lv5nGnwXnW6pPcrMx8w+0RKnUt+KkcYLlj0xEb21Fr3t1pa3fEOZtb/6HPDn?=
 =?us-ascii?Q?gAO+gZSaxIYGSjhIpCKJXzLelO+lKqCI3s4JmlyNlM+414teWvtvZ6PNH6UH?=
 =?us-ascii?Q?fq8gJGpIlalTmiibt366CI1oBOjVsUVDqguO0QpDlJXrx0FbHmm/DTYNW/ct?=
 =?us-ascii?Q?iPxa9G8K3w3RwtpPrIhWnDUgBfRGzaK/baz2YQfmcaYWbcCmqB57GMhgNPYy?=
 =?us-ascii?Q?L8VGUYqIHZjusatQYN+E+d/j5fpHXSuIbl4iaEFKUMMEoQnssaCkhtJrgchJ?=
 =?us-ascii?Q?IsE4d7RzLHUHHOg1fxYZcAcs7Dd73TNHcQkNYNWFWCkgrjIMaCLZNUkWwJ05?=
 =?us-ascii?Q?BINAfoPwGislVimdM61hHXlGO0PP0bh38D4p4t42cekS744wKJyPaaa5S2M+?=
 =?us-ascii?Q?9vwfIsRUaV917J9MzldjWLzKExxRc4/idpSSSXpd3l+BRqDaK212VbjcK4do?=
 =?us-ascii?Q?53v7sPuNHPnj1ZmtNd+RUdiUMIzB3qexKRzLzafqxDV0/jW+HuuhRLO69sJI?=
 =?us-ascii?Q?yN9MfMhF+4FuBsoRjnvEuoewJy+uGcrnI5P3Tvw2Cf0tSlSLPzUrz4dKD7vP?=
 =?us-ascii?Q?wC6We4xGkpN87UPV/Ktsn+oem4uX2n3NQDwA4Y4IeNjyjyRadKBNciFWIxz1?=
 =?us-ascii?Q?FTqLoYkY8x7EqdUoZg9t4MtrGCWtIsawfMcvrC2okyFXVUqkIGxE+Bntr1lf?=
 =?us-ascii?Q?xK+5sASH6I7X5PGPy+m1PvI9YOF/3B3qHVy16RFgZqnKyJm80YWNPiRD7Hor?=
 =?us-ascii?Q?FfRtMMA0nNYsJwAS/FfqTJpvUmYcWsK0k7pw/3emhtc0kvkVGP5Xj0ekQk3M?=
 =?us-ascii?Q?Zc74ogEcBTg+XoBWEdr9EgSA1gPOQRab+zvH6saNxcYe3eOPtyBynYLTCBXF?=
 =?us-ascii?Q?F/9zGISyUITbpLMEDW9sxyhGNL+7OgjbpqDsXr37ptgohKc8yBVo4nHs1PCb?=
 =?us-ascii?Q?CTOBrZ6eyAxNkXUFJ8Td+EQ5sbpJRojP+leQR+P3GfSdjQ3HbwASG91TqQGJ?=
 =?us-ascii?Q?ZfGR5e6XDpkMBe+NqH3pTwxNqrRhPKs/yNPmiem4gqTSf8EigVK4C+ZMqwc+?=
 =?us-ascii?Q?fsXElJgZcwztIpHYb00lXPRU0PROLCADoJdaeE7n1CUoyrO8z1idPcMXYne8?=
 =?us-ascii?Q?K8wYNGgyduqjOXGy9TPVwPr8pc52Iyyyl3O+hclX0E7jiZILfdaAHr1neC6y?=
 =?us-ascii?Q?WB2M0NcGTRgoMTEk8ptaeg9sLVdE159XbmyfIe5K9Dp5vcQXs8itb33jsyAs?=
 =?us-ascii?Q?BaqGiN+A6AXj0ByVUVjj525KnFwO4UDCtRzxnkIzbrXBaKOATb4GWt2DWxIg?=
 =?us-ascii?Q?Acep/RZ+ikxRk2pUzQ81wHKY2tJkPwO2BUsTTiP+rsBFmxlGf3v7qXawBmJ/?=
 =?us-ascii?Q?/8OqBxvczBOHq81UhqcjajcmRPEIxYl4jQxqTRC46TxUFnb5Mlp3cXts/QyD?=
 =?us-ascii?Q?2VIj6WeQ1R0Os4YQjtqTgmPmDgyTLeP1v2EK5pvQp+mUaDfyK5O34ocgcj2N?=
 =?us-ascii?Q?6XzuK4WZXdFGJzAxq/uQ07xC3N7MaJ8HX12hwlin?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f86f83-22b7-4cb2-9fd4-08dc497e2e6c
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 08:09:07.4535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UvEoLcDUEbTa/ttJHEADphskGi6D5oTE/p+gx5urxi7SRPpznbsVtvkmVmlv+w1BaOBthyjC1ndLE+PsdfvNnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8129

Dan,

On 19.03.24 13:15:48, Dan Williams wrote:
> Does this achieve the goal without an additional hunk like this?
> 
> diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparsemem.h
> index 1be13b2dfe8b..1aaa447ef24b 100644
> --- a/arch/x86/include/asm/sparsemem.h
> +++ b/arch/x86/include/asm/sparsemem.h
> @@ -37,9 +37,9 @@ extern int phys_to_target_node(phys_addr_t start);
>  #define phys_to_target_node phys_to_target_node
>  extern int memory_add_physaddr_to_nid(u64 start);
>  #define memory_add_physaddr_to_nid memory_add_physaddr_to_nid
> +#endif
>  extern int numa_fill_memblks(u64 start, u64 end);
>  #define numa_fill_memblks numa_fill_memblks
> -#endif
>  #endif /* __ASSEMBLY__ */
>  
>  #endif /* _ASM_X86_SPARSEMEM_H */

right, there are some build issues that need to be fixed in this
patch. Sorry for that.

Thanks,

-Robert