Received-SPF: pass (google.com: domain of linux-kernel+bounces-109806-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3afdba54-2a85-46a6-a0f1-a61b4d0d8930@arm.com>
Date: Thu, 21 Mar 2024 08:44:46 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] thermal: devfreq_cooling: Fix perf state when
 calculate dfc res_util
Content-Language: en-US
To: =?UTF-8?B?5byg54Oo?= <ye.zhang@rock-chips.com>
Cc: "tao.huang" <tao.huang@rock-chips.com>, heiko <heiko@sntech.de>,
 "rui.zhang" <rui.zhang@intel.com>, "finley.xiao"
 <finley.xiao@rock-chips.com>,
 linux-rockchip <linux-rockchip@lists.infradead.org>,
 linux-pm <linux-pm@vger.kernel.org>,
 linux-kernel <linux-kernel@vger.kernel.org>,
 "daniel.lezcano" <daniel.lezcano@linaro.org>, rafael <rafael@kernel.org>
References: <fb9b21f6-4c73-4a85-93cc-56e7c44359cb@arm.com>
 <ANIAEAAdHuSn9iPJ6HkLiaq2.3.1711010230402.Hmail.ye.zhang@rock-chips.com>
From: Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <ANIAEAAdHuSn9iPJ6HkLiaq2.3.1711010230402.Hmail.ye.zhang@rock-chips.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 3/21/24 08:37, 张烨 wrote:
> 
> Hi Lukasz,
> 
> Regarding your question about how I triggered the issue andifI have a 
> driver that provides the get_real_power() callback:
> 
> I encountered thisissue whilecalculating the GPU power consumption onthe 
> Rockchip RK3399 platform. The GPU model isMali T860, which isan ARM 
> Midgard GPU. The driver version isr18p0-01rel0, andit provides the 
> get_real_power() callback.Best regards, Ye Zhang

Yes that would trigger the issue. Thank you Ye for
sharing that.

BTW, I also use RK3399 for my mainline kernel development.
I use the Rock Pi 4SE with the mainline GPU driver
'panfrost'. That GPU driver doesn't support the get_real_power()
callback, but maybe it would be worth to add it...

Please send the v2 and I will add my reviewed-by tag for it.

Regards,
Lukasz