Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp334071lqp; Thu, 21 Mar 2024 02:41:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXh59jJmq49luLZLeZ/0sx6NpI2YfIBKmdSUWP4G6RGl+opPggbMzxU2VJ+omvKS0CFk2o4toq5Sit4MDkaQAozdAG2bCrXUXLhQw4p5Q== X-Google-Smtp-Source: AGHT+IHX2z8eMQRd6zoKYcE9+4ddxw356RUtVszTqaFsNsK1VmJJCYpLKBDKVciI2pTNZv2T5gE6 X-Received: by 2002:a17:907:2da8:b0:a46:8c40:7a3a with SMTP id gt40-20020a1709072da800b00a468c407a3amr14355106ejc.26.1711014113966; Thu, 21 Mar 2024 02:41:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711014113; cv=pass; d=google.com; s=arc-20160816; b=h7Vv7XrxfsqVLdxgi1mSVxzTL5jYngdYkJs6M3rJ/Ujoe/JHah1Z1JrgBHp4dq0fwM fvE19VK4k4CePpPEyluaBlnA10nt9ko8CpdNIPHz/SBYOiJDMyFMwkRNRIXBxjKDAaA2 B+7hq5buav2wWaiH1ISTRUq5lwv85Z4Oai0nm7JwZjiXTn1d3yQthn1fDH5j4QOWnVcw GIfS/e+wxcmQu2zRhRqFXwOBfDSkKGd326gnhHK264B4yv06v+/GuLUlZZyZCwmbwcKT kpFt5SoHA2+harvkSy/1QJ7g+rhXcdw4T8N/bk/OX0OIECrCeVTeuuPj2tExvw6yR1CT g//w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=webeErP71bGrCtrnKMl3CyhYpAF0y0SlAUiPvCaWPVw=; fh=MV1Ul2+czKpx2nfsyrvtHzS1SftNjfGS8wTh4Y3FEW4=; b=AC6oVIutbMZinnpJQaeAOa490OnTkqCQxWZiHhOddYKZsCnBL4nklK8+bySBIn0m/j JUg98tnm6xT5c/1lPlXP6PtsfIkAgx8ppyt9lA1XE4pssJx666uc3dFtKg855mUwzwNz z1HcRFEMPbTw1OTsYu4h/rPA3RijtBb7FtOdJR2KO6FyRPIQETALU9NS097RH4gKDcu2 5VsHnJ8BFvhLXwEXKlmW+vItWnxM/lsVd7eV2TJ3dU0iQmf1bi93/fdrPgsQpL9mrPvm AtfNzqSjPvcDQVlK3+/sV7brELe8hw6SFZ5Qsv56vL4vI7n0kW7DtAQ22UGNhGkF7rDi iEGQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Oc2UNrB6; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-109856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109856-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d26-20020a17090648da00b00a465fd6b411si7152077ejt.925.2024.03.21.02.41.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 02:41:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Oc2UNrB6; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-109856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109856-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A75261F23BDC for ; Thu, 21 Mar 2024 09:33:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5715A53E0D; Thu, 21 Mar 2024 09:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Oc2UNrB6" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C705579A; Thu, 21 Mar 2024 09:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711013587; cv=none; b=mtxOuKzP0dl8u8GQ0/gTzB+bHJjmXZZDMFAJMfHeh+tlPLL2S1TnSIsfPuM19IKkoxSa3vSW0yLWfp8y5RkI+rLnZyG9BUYbOggc86zYl73s7EUkvMvsD9NdoH5V0P5cIAHqlBrmcXqmnoTTe3KuHp9OR9cpou3PfiZ9B0PqZEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711013587; c=relaxed/simple; bh=XicOA/rd5rXSwjpSJrCdlLs6Mlqt1T3aAFaf41e77ks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oDq/k2sMdK5GJtCrrkcFfc49inkcxmBXQEwqaHHfuWF73+bR9q2JGAf/D1T0QrAKYuKCDqNOJpTwnloV/tMj8jvlO5rT+ghCWA+Cvi5q9bVicrZ3GJzH0kFdKGXTusMhFtd8cumM2AlqP9KU0wvKVgJpGr6izypu1wuj3qCqMNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Oc2UNrB6; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=webeErP71bGrCtrnKMl3CyhYpAF0y0SlAUiPvCaWPVw=; b=Oc2UNrB6E4lFSOnZpA7d1IatjG W6hsUIFRGF6ZFdsUcV+Adz6oXUqJdPj+7cEAaWcSBjDWNgoRuI2o27QS02PykktSaeAZdv749sCRa GdhddvtLxLuV4PC7ecOpTa1Y/35qamO+DvRbrZCenbBNBj3ZolBVbDPH/6oOyDG9UQpmYYsgMTitk keK7SpcRac5G2tKjYbEz4qh0FgAbUW/zsobZ/WBh/npQDKa63ho3GLNifaGtQM7cc1/VHRA70bpV0 wrvzKP3/QqHx02S0Azo0b9GZC6bYxv2ww0qOEcALXPKWsZBEKrHBF6rbKfJCMZt3IeZ48LE5HcH0T OTZF9h8g==; Received: from fpd2fa7e2a.ap.nuro.jp ([210.250.126.42] helo=[192.168.1.8]) by casper.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnEmp-00000006Qam-3O3a; Thu, 21 Mar 2024 09:32:36 +0000 Message-ID: Date: Thu, 21 Mar 2024 18:32:25 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage To: Geert Uytterhoeven , Arnd Bergmann Cc: Michael Ellerman , Nathan Chancellor , Paul Mackerras , Geert Uytterhoeven , Arnd Bergmann , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Nick Desaulniers , Bill Wendling , Justin Stitt , Kevin Hao , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20240320180333.151043-1-arnd@kernel.org> Content-Language: en-US From: Geoff Levand In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geert, On 3/21/24 17:32, Geert Uytterhoeven wrote: >> static int ps3_probe_thread(void *data) >> { >> - struct ps3_notification_device dev; >> + static struct ps3_notification_device dev; >> int res; >> unsigned int irq; >> u64 lpar; > > Making it static increases kernel size for everyone. So I'd rather > allocate it dynamically. The thread already allocates a buffer, which > can be replaced at no cost by allocating a structure containing both > the ps3_notification_device and the buffer. This seems like a much better solution. -Geoff