Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp366453lqp; Thu, 21 Mar 2024 04:00:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUiqnoqoH4ocMuk6+ITu/KZ9xpXngX3ekMkvJ3/9EJEQ/XDESRIKFLv1Zixm/OrbLOSKrlEnpKeOyTRdnCPivLYfQSJR63TAKOOmAX+5g== X-Google-Smtp-Source: AGHT+IF/8XKQcxRoxV7kkjEgHoK5QX8U5MPAERhNY8x0/gjUCYEjd/06iU3+yyn1t/QDXLCnDwWs X-Received: by 2002:a05:6358:2799:b0:17e:68fb:8669 with SMTP id l25-20020a056358279900b0017e68fb8669mr22506185rwb.23.1711018839677; Thu, 21 Mar 2024 04:00:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711018839; cv=pass; d=google.com; s=arc-20160816; b=PKBtJNRB/hZqdRlUX6XtgMmZD87nv9D7roYMziyVPlzL23OUv6DwBPu0EPB1z9cpY5 /8T7d6NwNtfK/CXF5vl5LlJTdQlzxTqSb+2HaFqA0bIIMhprx63lUpB/lz3g9TKnjZEz gjZtx/6TXFi0EHmHF0Z6oLVDwWiCL7geKpDqB6JwjP4lbfPEtKH94/MuIb5NV/gcoePp XTgMZvY+/C7tLOMX4/EVxVXGDdFp63PlZVj+ZiqWpWD/ZHUnJhdFHozg+u6aSCknuzbT cofnc8aZ0KN0T/3+OWMC24muPBZd/0cPc5MbqOi9QfLDqStg99MySlZy5p59+lRZhwAF GSeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=SEC3LZxJaLM045KxKAM5DOaUvlzhnZ2i359HIi4btDI=; fh=EUtgz3FuqaeLLmMr2p3+Y2JjTOFclcLns/TqtsTXTGo=; b=TDJnqq1ZhEiMbbDyKVmoWlHrJaSkBNTXdCf3frztMJoCubzOiYdtAHU/yhjzLZMC8U WkLay9BSpuIPbKVlmRtKIL+mA3Q53nYE1btiydt/p3UxrVD/3IO4GmwQPv8nZcZjOLrs 9tjkaQxrGSELqCOXdt0RgyfJvvri6rW60GABQL9uclF/Q3xbJESYuA0nS4fT87vvnIqt +b0EKWxq4lD7W5yI9ZWZrkkRlgZKPj0X+1Kl+IQatRRa7Fe+LboCWsZPN2c6g1BiXg8F Z8O7gwx9ZMTbm1JK2LvrOXQu+j06GwXyqcxPKLkEZBzsTDDKuNvW1r/J9FaeT6tzH/QD CvjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ut7WX7Cx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109914-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109914-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id by39-20020a056a0205a700b005dc89163894si16095275pgb.442.2024.03.21.04.00.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 04:00:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109914-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ut7WX7Cx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-109914-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109914-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 30AC62841BF for ; Thu, 21 Mar 2024 11:00:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B6C358100; Thu, 21 Mar 2024 11:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ut7WX7Cx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C74457311; Thu, 21 Mar 2024 11:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711018827; cv=none; b=QpAActWO2fXOsN9VdkokJSeEjAuzMGn2GdzbE7CVRRgZdiE/0QPpPgY0EliDopADnLCmdVNu7D2qUh/HVStyDhBLPok/I4lMpmYcJE4kuUn1yGj41+OzW5uC8/UhBIo7no2ido4tGV945xPHHWCUMGqjMrwlNbjRBDR2SrLgQpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711018827; c=relaxed/simple; bh=JZ/uFKf0RYrnnxw9jJlX5wLrQamwRfdSTn6ZmoyBLug=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=oiKE2ea628i8Yf6Yre7GJFrEw3OSSfiR52/j9t2ypOf+K4FZ9cbBV31EdX3D6VBoIn4HN4TBbSSuPW9L+ABcMOHR65eT1seSovQ4mxNr8K44jquRpjw3rMnvvnTjJha0TrxFkbLFpEHF+T7CDzhwwdJZaoNZyOqSXfEHgblcRNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ut7WX7Cx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id D58ACC433F1; Thu, 21 Mar 2024 11:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711018826; bh=JZ/uFKf0RYrnnxw9jJlX5wLrQamwRfdSTn6ZmoyBLug=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Ut7WX7CxUr7mAOvAi8yA1jqWL8pgL9mqvy6e6+Pd4AGyf9nqdcGO+9FYFn6BDEzFX mJ/y8qj7sYpI7R6pYKFE34hE7CaVyufzNGty5bJK4Y44w3qPfwEDM3+NXKaAXMjsou JQ6fUN3130aq6ZiiYQHenZOOeERvYhalEoWHlVAzLiV8DqzQyguOKN4iHcBHp/skVs TQj/tD8EXUiYjLYcyYMuP07upJkT/PbauP1OoVzH0dCCie0tBvLbz+JIvFzSGXwVHN p3ACx7X2nDmcdlDYwg9oWDNoJ2TD9W/Y4wtT77L6E1bMiXHyZPJPu7WaHLqUc6IiWT v5FBEGf93o4KA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id C3726D84BA6; Thu, 21 Mar 2024 11:00:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf-next v2] arm64: bpf: fix 32bit unconditional bswap From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171101882679.21551.11136604027550877391.git-patchwork-notify@kernel.org> Date: Thu, 21 Mar 2024 11:00:26 +0000 References: <20240321081809.158803-1-asavkov@redhat.com> In-Reply-To: <20240321081809.158803-1-asavkov@redhat.com> To: Artem Savkov Cc: xukuohai@huawei.com, xi.wang@gmail.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, puranjay12@gmail.com Hello: This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov : On Thu, 21 Mar 2024 09:18:09 +0100 you wrote: > In case when is64 == 1 in emit(A64_REV32(is64, dst, dst), ctx) the > generated insn reverses byte order for both high and low 32-bit words, > resuling in an incorrect swap as indicated by the jit test: > > [ 9757.262607] test_bpf: #312 BSWAP 16: 0x0123456789abcdef -> 0xefcd jited:1 8 PASS > [ 9757.264435] test_bpf: #313 BSWAP 32: 0x0123456789abcdef -> 0xefcdab89 jited:1 ret 1460850314 != -271733879 (0x5712ce8a != 0xefcdab89)FAIL (1 times) > [ 9757.266260] test_bpf: #314 BSWAP 64: 0x0123456789abcdef -> 0x67452301 jited:1 8 PASS > [ 9757.268000] test_bpf: #315 BSWAP 64: 0x0123456789abcdef >> 32 -> 0xefcdab89 jited:1 8 PASS > [ 9757.269686] test_bpf: #316 BSWAP 16: 0xfedcba9876543210 -> 0x1032 jited:1 8 PASS > [ 9757.271380] test_bpf: #317 BSWAP 32: 0xfedcba9876543210 -> 0x10325476 jited:1 ret -1460850316 != 271733878 (0xa8ed3174 != 0x10325476)FAIL (1 times) > [ 9757.273022] test_bpf: #318 BSWAP 64: 0xfedcba9876543210 -> 0x98badcfe jited:1 7 PASS > [ 9757.274721] test_bpf: #319 BSWAP 64: 0xfedcba9876543210 >> 32 -> 0x10325476 jited:1 9 PASS > > [...] Here is the summary with links: - [bpf-next,v2] arm64: bpf: fix 32bit unconditional bswap https://git.kernel.org/bpf/bpf/c/a51cd6bf8e10 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html