Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp374570lqp; Thu, 21 Mar 2024 04:13:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWuiuWPeyQdfjJ/jbRliiE40v+yomDd+5YQc8iHgubewDj7FmhB6hkiMCeB442g76OKavXOav7e+WS/U8j+tisgmIB00b9kBTNnqkkBtg== X-Google-Smtp-Source: AGHT+IFeaYPYzmZk/E1ddN+oAtkqqQhyILt5q+zEuTBbExgB5HQ+hYvTipANt+CZMWXNfvrPtSpw X-Received: by 2002:ac2:5b9e:0:b0:513:b90f:f4dd with SMTP id o30-20020ac25b9e000000b00513b90ff4ddmr3642661lfn.49.1711019603244; Thu, 21 Mar 2024 04:13:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711019603; cv=pass; d=google.com; s=arc-20160816; b=RYHQ3EmE7bOVrBbRD+h0N91IOEr/PXYC6hLjApiKmlTmx1WlvKf2wfsx2vZSkhiKTR hwYQt9fnEq5NLKzNPUTbaKWyRdT80QORTRxHEjAHcZAfEnOjbU3tJaOfMXNjE9DmWjGD V2AS/IAAY3gH+M0AzKUyBBKFKFtNXyUBOBzBzXXlFLw2yPEAKyUIW6AMs64wkEuSjQvB 68peGZbWuq7AxC1W05RHmDoB8psZK6KI/U6Nw16fhrpIbDa8zqkVf4N36PYE86bX3dUI ftEc4TPsQ9owvUl0YVuwhgVJhQnbNVncTxE9SWMqC5dxYOwe9mn1ef5q9QECSbXFd7a6 A3pA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NUUkr8yZSobBLabz/skEjYE2cV1VS59Krz2TXGU382Q=; fh=DWHwbS5Yyu2YPKgQVzoJ2mSisvAGFA+fe6r0qCfhors=; b=m+9syGcLUHxzh/07UXLb1Ely+U4T1krF/qiXd96cilvHC29DSA5onQWpKwezi5sqR/ 8nKjr/Pq55uqB3KZwjoGLd289r19P19aTH8p6c7BZKEK7ld7CkuxY+3Ao+CCytadsa6y QhA+Z2qLcS9klN2h+UeRCUqWIX3y62RU68gqSYt6DD4eeDfdu50UgUt15Lg6sy1FaVMT TTaBNhHaQjhaN2vjT0T4n9lZqu7l0XzC4V643wMpFLhBeuuZyRn6tyXBmMx7v7Ne5SlY j/cZvZEXmiOZFS/s5uxGzZr4QRXtuqe36J347nYwWp/c4d0Zwgnl7cFQE88rk4g3fOcH IeUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=jtintMTF; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-109925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109925-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y3-20020a170906448300b00a46d5bb1e80si2854308ejo.6.2024.03.21.04.13.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 04:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=jtintMTF; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-109925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109925-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F01981F21423 for ; Thu, 21 Mar 2024 11:13:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 91A2958ABC; Thu, 21 Mar 2024 11:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jtintMTF" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 212E05822B; Thu, 21 Mar 2024 11:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711019580; cv=none; b=c1cGOUfZKDlIYExPDTVIhFFQRdOaAG1Rdh61bIhyCTVniEypKVAejTXDAQoTG58DALwh4YT3oJurJ5FfGAiOe2JCKBwfFVMkZslqQO4vKTebiIkqF6BCZdf6Rsja0C6x2i7qLglv8ZSAopKtr3Xfr7sA4SZK/ePzy7goETAET+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711019580; c=relaxed/simple; bh=CKkaIB1VMOnmqCrBsV70ZTXEjY9urL8LUoJA5O5CNOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sB6CRLCp6OomHfudJdxVzimS2jVaUVc8APuEkeEmpv22W0h62dtkQiI+YCTQN1JVRhK2zAVkIjmM41JpQLk6gR3Hdj1ci4yKJrhPa/A4tebuixvPDp4zv8SmJhmu8MTFVzCadQxHRCly9OiApqgiY6rs/Cxr5/rhAnW/34SO3OU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=jtintMTF; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.86.18.138]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F358A8CC; Thu, 21 Mar 2024 12:12:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711019549; bh=CKkaIB1VMOnmqCrBsV70ZTXEjY9urL8LUoJA5O5CNOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jtintMTF/W31s6QjQeqr7YkpLAgc2ItlIh8C/tcIODu0wII/61o0dAMBD2Obu8S1e p339pJrvffGGGCqf1Qd4zu28o3Z1gLao6W3jGkSSU4XzvUOknSkmsUh35/GAlmHB/3 nKTLclbz9O9Wni+p6IoH3jXDsrPOGCXmpuH34QfA= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Sakari Ailus , Kieran Bingham , open list , Umang Jain , Tommaso Merciai Subject: [PATCH v3 1/6] media: imx335: Support 2 or 4 lane operation modes Date: Thu, 21 Mar 2024 16:42:34 +0530 Message-ID: <20240321111239.808735-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240321111239.808735-1-umang.jain@ideasonboard.com> References: <20240321111239.808735-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kieran Bingham The IMX335 can support both 2 and 4 lane configurations. Extend the driver to configure the lane mode accordingly. Update the pixel rate depending on the number of lanes in use. Signed-off-by: Kieran Bingham Signed-off-by: Umang Jain Reviewed-by: Tommaso Merciai --- drivers/media/i2c/imx335.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index dab6d080bc4c..c633ea1380e7 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -21,6 +21,11 @@ #define IMX335_MODE_STANDBY 0x01 #define IMX335_MODE_STREAMING 0x00 +/* Data Lanes */ +#define IMX335_LANEMODE 0x3a01 +#define IMX335_2LANE 1 +#define IMX335_4LANE 3 + /* Lines per frame */ #define IMX335_REG_LPFR 0x3030 @@ -147,6 +152,7 @@ struct imx335_mode { * @exp_ctrl: Pointer to exposure control * @again_ctrl: Pointer to analog gain control * @vblank: Vertical blanking in lines + * @lane_mode Mode for number of connected data lanes * @cur_mode: Pointer to current selected sensor mode * @mutex: Mutex for serializing sensor controls * @link_freq_bitmap: Menu bitmap for link_freq_ctrl @@ -171,6 +177,7 @@ struct imx335 { struct v4l2_ctrl *again_ctrl; }; u32 vblank; + u32 lane_mode; const struct imx335_mode *cur_mode; struct mutex mutex; unsigned long link_freq_bitmap; @@ -936,6 +943,11 @@ static int imx335_start_streaming(struct imx335 *imx335) return ret; } + /* Configure lanes */ + ret = imx335_write_reg(imx335, IMX335_LANEMODE, 1, imx335->lane_mode); + if (ret) + return ret; + /* Setup handler will write actual exposure and gain */ ret = __v4l2_ctrl_handler_setup(imx335->sd.ctrl_handler); if (ret) { @@ -1096,7 +1108,14 @@ static int imx335_parse_hw_config(struct imx335 *imx335) if (ret) return ret; - if (bus_cfg.bus.mipi_csi2.num_data_lanes != IMX335_NUM_DATA_LANES) { + switch (bus_cfg.bus.mipi_csi2.num_data_lanes) { + case 2: + imx335->lane_mode = IMX335_2LANE; + break; + case 4: + imx335->lane_mode = IMX335_4LANE; + break; + default: dev_err(imx335->dev, "number of CSI2 data lanes %d is not supported\n", bus_cfg.bus.mipi_csi2.num_data_lanes); -- 2.43.0