Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp386934lqp; Thu, 21 Mar 2024 04:39:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWV3INnb3U99hQbqdw8AOJFLqKQ0WJm5IDaoGq675AJ2ap/Zouv+D7xDAX9PUIVEx16xIx2kaWM2JE3OJvVvAynyfPLtrTF88Fxi2E32A== X-Google-Smtp-Source: AGHT+IHWJ6yNwjZTkIjF8iB0LFmQXKbACjx9eVCWqikSEazC2f7PCwI83+KIjs61NHr55TRYl2Tm X-Received: by 2002:a05:6a20:9f47:b0:1a3:78a2:2bc2 with SMTP id ml7-20020a056a209f4700b001a378a22bc2mr9126384pzb.40.1711021155173; Thu, 21 Mar 2024 04:39:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711021155; cv=pass; d=google.com; s=arc-20160816; b=k4GKMPiCrXdjd1KCn3xjxWs2ZfE1OXseacQZqzbFmBN0Vz6ZTixA0ukj8WgpZ7GZnT 5I7WSaRoGz/d6qSuF0YwT6Mxhjl5qz9M/X3NpqX4GWhfaD56t0/A5nLJbM/IK3BMls6u xr5cOctglDjleoUd/KCjPteeU80z2cEaNR0G6lmDw0CV29OusOpzCuX2XeeW0h1hO9i6 /qZ7bva4nKS3yETSkn98J26Ftgv0IsK2ThNZYBEmgwZfYYu9aVs9FTop+OdPO3jrjGZ/ X41xDOYU+ebjvSlQdN7JbSC9m89jsFz4ft0wLau+HSlLwDegFdqygIg3h5wsYjNk/FLz WEQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=Pt3+2/nDTFR616tg5a69R25p8gHMQ8L45m+oyGrsQFM=; fh=x9a283RG1NHInbKEI6hOM352XYzCV8hyHxk93HLqIIs=; b=QathMwewc6LEKlu28uzIaQUQzPVIarevpl/eBJC6vXlWsfcZrjhut8gbAVjmSpD0hr mwpCS2qoAIQCCmqszw6FsiOZQF6hbxfrn/0fM1zuG4ckZcPddRwda+tBUvzMFY3BHwTT T3Ic9kY+SYcMIOSSK5wH1mTlVSSLMcgJpIJd+OnRwfTxgg6TaRs5+NLlaCnJLhd5CX/r 6uonxl7UZlIx1PkZwHyANHelEZM7gMdlsWzImuyF8d/aUYA/J0cveDTBM4yZBx1j4bYr j6Vf0J+wD42ayzARe7lspuOKWNBNQ/X6mQbRR9ZjzuFzwpgWa4oU5xFa7/UBVzusHCzC fa+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=ymD8F85R; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=wuaX50Yn; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=zBpTmHrT; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-109976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109976-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d15-20020a170902654f00b001dcfadb02bcsi14991641pln.406.2024.03.21.04.39.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 04:39:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-109976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=ymD8F85R; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=wuaX50Yn; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=zBpTmHrT; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-109976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-109976-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1451AB21251 for ; Thu, 21 Mar 2024 11:39:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 94F3359B79; Thu, 21 Mar 2024 11:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="ymD8F85R"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="wuaX50Yn"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="zBpTmHrT"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="/XrvFpRf" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E1E59148 for ; Thu, 21 Mar 2024 11:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711021141; cv=none; b=WkK5tkWQs52iqxWrNdVaTk0jeZ1Y5tz339glsiWwl0My0HLYk+Fdzb1rJj2tBmcVRnq9DAxpOeTgTUU2edZ8Mjb2s0djrAW5pvt1seVaUXUTHMZ0lGcOXgijhqrhIvaNe8KwKejteHpX/vRfr4bI/RNjr7OH+QPZGohqVn9SEYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711021141; c=relaxed/simple; bh=YR9q8iX1LsMRbqJycj05LpnC1vzuyORxCMBLEDPHkzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SK1ht8eMhRuWqJ9H7wcRP0CFdVyHacXFbJzGHtEqGs8vZWIt1224FFkNC6cjwXZzEXblW+IeQtAZ6KS7iGKVIaiqo4ri4X4lRefH42t50SHslaLFgqsObDoDzFRdHjZuj0Y4eCm730i/7Nawn/35JFvDwarD7lpaA3AvXWbJFrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=ymD8F85R; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=wuaX50Yn; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=zBpTmHrT; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=/XrvFpRf; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A6EAF372DF; Thu, 21 Mar 2024 11:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711021136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt3+2/nDTFR616tg5a69R25p8gHMQ8L45m+oyGrsQFM=; b=ymD8F85RIUZAxh/l7P9lYEmI0mPCxwGXdPCf3MkKG7U9ujXTLCodUPVWtT+F7gh3XB/yPq jC/cr1RMa9YSFSm5d4PZ6YCxWR065UVlnUnQXMpShGqZRHd/NpEzrvqflVCBcOVtpxR5WP hk3wOCkVlk6JcPG/Nqx1kqXVLAGppq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711021136; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt3+2/nDTFR616tg5a69R25p8gHMQ8L45m+oyGrsQFM=; b=wuaX50YnFTJqwgi41Fj0EU6hhYRJw8uHlbqlduAsulFpP06KU8NmZwXbLWxAsUJdJEUALe JqaTToDNcVkkX+BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711021133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt3+2/nDTFR616tg5a69R25p8gHMQ8L45m+oyGrsQFM=; b=zBpTmHrTdPQOEMrXGSmHyxDxWSCZKqO54njWMUR/WJTe+ImBjeMlAO2gMFyEgUEU6pE6Mx nPNgi/x98bA4oVV0GP1MA4g1jek17RSig/i7eWdz/8ryJzD/c4snWDVQsmZhI+mtbgndF0 Wfk7sYuJuZUOvWlj23Kfo9iP4bwZi8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711021133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pt3+2/nDTFR616tg5a69R25p8gHMQ8L45m+oyGrsQFM=; b=/XrvFpRfPYITHNqpD+ls/w3AGp7UQfUAtaYfMJwvy90ZS5uGJW9HW5qM67PFdFmn6qCj5S rA/FslVbKfLFliBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9C8D513976; Thu, 21 Mar 2024 11:38:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zjczJk0c/GVzNQAAD6G6ig (envelope-from ); Thu, 21 Mar 2024 11:38:53 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 44C52A080F; Thu, 21 Mar 2024 12:38:49 +0100 (CET) Date: Thu, 21 Mar 2024 12:38:49 +0100 From: Jan Kara To: Joel Granados Cc: Jan Kara , wenyang.linux@foxmail.com, "Eric W . Biederman" , Luis Chamberlain , Kees Cook , Christian Brauner , Dave Young , "Darrick J. Wong" , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary static variables it_zero and it_int_max Message-ID: <20240321113849.hfzmnz6p3cjbmmwt@quack3> References: <26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@foxmail.com> <20240320103603.u6uqhk6viu4qkaht@quack3> <20240321105555.f4qg5g3wbe57mzzx@joelS2.panther.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321105555.f4qg5g3wbe57mzzx@joelS2.panther.com> X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zBpTmHrT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/XrvFpRf" X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.12 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[foxmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[10]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_CC(0.00)[suse.cz,foxmail.com,xmission.com,kernel.org,chromium.org,redhat.com,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.11)[95.72%] X-Spam-Score: -3.12 X-Rspamd-Queue-Id: A6EAF372DF X-Spam-Flag: NO On Thu 21-03-24 11:55:55, Joel Granados wrote: > On Wed, Mar 20, 2024 at 11:36:03AM +0100, Jan Kara wrote: > > On Tue 19-03-24 23:57:49, wenyang.linux@foxmail.com wrote: > > > From: Wen Yang > > > > > > Delete unnecessary static variables (it_zero and it_int_max) > > > and encode them directly in the table entry. > > > > > > Signed-off-by: Wen Yang > > > Cc: Eric W. Biederman > > > Cc: Luis Chamberlain > > > Cc: Kees Cook > > > Cc: Joel Granados > > > Cc: Christian Brauner > > > Cc: Jan Kara > > > Cc: "Darrick J. Wong" > > > Cc: linux-kernel@vger.kernel.org > > > > This looks as a sensible cleanup but I don't see the first patch in the > > series (and neither it is archived at lore.kernel.org) so I cannot really > > verify whether your conversion is correct... > This was my original comment. If you want to see the cover letter > look for this mail ID tencent_06797E65CFC655DCD4F0414B9380E95ECC08@qq.com > > Not sure why it separates the cover letter from the rest of the patches. No, that is actually a different email :) Based on lore the message ID should be: 26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@foxmail.com but the email is not in the archive... Honza -- Jan Kara SUSE Labs, CR