Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp409377lqp; Thu, 21 Mar 2024 05:18:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmgOr58NOE3MJ0R1au22ztVoDwdrPanSfoQZa4esPu8lM2uYWcbZNZnv60T98BkKm/krHBDbzNk5vIthz92PduAfdmCqAuRQLquk1+DA== X-Google-Smtp-Source: AGHT+IHyUCpny0tYueaxx4DClzoxZflCNaLhNhUqjjLhOBO9E7G11H/FPLBSheJz4Zi5w+7CRNfY X-Received: by 2002:a05:6870:36d2:b0:222:7273:a0a6 with SMTP id u18-20020a05687036d200b002227273a0a6mr1951586oak.49.1711023512065; Thu, 21 Mar 2024 05:18:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711023512; cv=pass; d=google.com; s=arc-20160816; b=GFThVjuHvONWEanO/C60efkCILIfgPxh6cfUu98QFMmGu91LMLpF1nAnykyYcFn59C eIE6gl36kYQwnCPqv4w0weshM3N9QLiWjR0jwUTkDnv+cR+gUw8IJV3ePf0m15gC9rgc Bt7e4NzVNZzjlzVAVtEaSkyW2LEI17iEJqhYs9OQHg+BcITwAWlm4fCOBNq74yCfbvuu ViuMvUsVAPSyU2wlqFifjFEXmNjFQVgij711IiCnUj7awGASSNmqrwln1iZwaLamlvk0 d9LeldhCwzELudrKfPClxftikrPa5DhS6vKiEbEIjSpmd08Kd6ar739e4sMUdCiSwaym N33g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=T2M6hSR/eu2/ketykPJ1Cw1XadExmhkdOAt+Vsehf/s=; fh=NIr3VFtlS+jvY9kf2SB0bSiFDOPUW4GkBu4r2LVdt2o=; b=OLobE+ekRxWisCkZMVrtRHXyyyYC7x4dRykX8p6KZejpKIWXBRxlbbkhVvDqidYKHu RmSRYrQI6dYlh4Wc+V7HUmJo36pTf4H+0A3kAG14fXlKWVEBeax3DSDbcpmQ1Z1j3S8N 2atu+3HnxSb6E2HE4eaAxKGAssAWV9sykOCLTR6Uzak+mpp3s/MmtbNYA9ePHiRhk+oF rJZcUXTUlq6fTMtLv2L4Mmo1jz2rn+tAo4yGO31w+3n6vWoAtrp4h8SA6uHYDfR731Gu 21k66JgRM7fYveg1HKVl3eZuimCOW7rZDHlhHe9vGE/GltgCGynYDIZZtNBuh5xyixf4 xoeg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KUvM0v5a; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110016-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g25-20020a633759000000b005dc4219ac31si14449430pgn.139.2024.03.21.05.18.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 05:18:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KUvM0v5a; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110016-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A3A86281709 for ; Thu, 21 Mar 2024 12:18:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2C357604E; Thu, 21 Mar 2024 12:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KUvM0v5a" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C23F7603F; Thu, 21 Mar 2024 12:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711023501; cv=none; b=MABGfib69/K5m+y/Zm2Po+1FWBt8QH1BM2lrthPgUI2WJ5upaRfjghCB6GZqfgndjWCJTQRfTW7T5zwOdT6+A0H0cRj3wvI3b7QZpOyIU97ZvxZRC+tfXjtvuIZ7uv/I1lkU8zpMkrZMbq0ANJFkzoVjJxjsTAsrw9zkYPku4L4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711023501; c=relaxed/simple; bh=UBRSx9f1gMDeY6MJdKKzXRvqJDl/ks1aEcmhdUtM2Vs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tbemrIoHF3Km1hyhR3rbBYSep6vidTBrBN795lpzAwirVb0bmlGNROXsFcrjJR/fUtGXlvomuunRtMBVmqDBuLqLcdzJydaYTRf1jye0SLMXMU5fPl2bx76CBbeJi8lKkzyRftQ01oa0QugOdTVdd3WzrDFEFLlWZrYskO73VKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KUvM0v5a; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49544C433F1; Thu, 21 Mar 2024 12:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711023500; bh=UBRSx9f1gMDeY6MJdKKzXRvqJDl/ks1aEcmhdUtM2Vs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KUvM0v5a2FH0U+EDGdJ3KqZ/zNp1vGL51E7Vvquu1AwsXsW1QzbaWneLQtngs33l0 JqCkyT+MKy1b474b2bpj20AepKpwfwJwJZsH/vznmAyX2oKZuMgVw6lcO3wgRubjL1 LnPg/id3mfN8MuAhAqhI1HiCXyn740cq8wfWzgWCwdjJGp2HxwzUcaI3vAyIPIs94j SB4CaSBgGI9wH7tEiuXjN+LDx44LuGssrrPUsev/Yiv3wG+F+nnpGzIPaT0GQm3DFy QpqRJmJV70aTU0si8sMecAVV2xHcvLHtD/059KFin1vKZjbil69yIaT4KYOmilemvG xP52JxwCZoO3g== Message-ID: Date: Thu, 21 Mar 2024 13:18:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage To: Luiz Angelo Daros de Luca Cc: Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240310-realtek-led-v1-0-4d9813ce938e@gmail.com> <20240310-realtek-led-v1-1-4d9813ce938e@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/03/2024 12:56, Luiz Angelo Daros de Luca wrote: > >> >>> + >>> + patternProperties: >>> + '^led@[a-f0-9]+$': >> >> [0-3] > > leds are already defined for a port. I'm just trying to add a > restriction to allow only 0-3 leds and use that to identify the group. Where is the restriction, in your original patch? > These suggestions will redefine the leds property, forcing me to How? I really do not see it. > declare #address-cells, #size-cells for leds and reference the led > schema in led@[0-3]. Is there a way to just add a constraint to what > is already present? I don't follow. > >> >>> + type: object >>> + additionalProperties: true >> >> This cannot be 'true'. Which then will point you to errors and missing >> ref to leds schema and need to use unevaluatedProperties: false. Best regards, Krzysztof