Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp431695lqp; Thu, 21 Mar 2024 05:59:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW38pNEbgOtonvQkP6XfaW3SXzAjFCJ40Og9Z0ogIm0JeTSDo1IpalxVzV9RoWr02fUcsvuWiPP2ABcgKnLkZNhnPn3ToXJvEuZrEviJg== X-Google-Smtp-Source: AGHT+IH4RrMq6WOOwcwnlPSJnGnAwLdNmusd37kDKWSnFIufjqAGhLg8SB1AxAmkbv3ofJ2Ty4HX X-Received: by 2002:a17:90a:f007:b0:29c:7690:2724 with SMTP id bt7-20020a17090af00700b0029c76902724mr4533425pjb.16.1711025995718; Thu, 21 Mar 2024 05:59:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711025995; cv=pass; d=google.com; s=arc-20160816; b=Fmrhrlcpo477Qj0FNF5IxDechLTu+DMbFcaGa+IqXzqlnygkVPdN5UEpOVU5vt3PD4 XR8g8sl70t/WEgjG8k6JBdMO8dk5xvOcQUCsgrThP0FaGFDR3quoQAyBKQ4ObAsioSCb kaXr37XCTQ/Le6WLK7ZBQmcEE2TgqqOu6VVkojxhio0qLEIa7FxRvlFhycQmuSUPw/q9 +IV3XFzRVN/+44aDBOMiDBtfeumbyADuaVU0gkbpAmnzz8++QbdRtbJpQHJN6y1CbQbH A4dShdJouypG7r3DABGGZetbjX8hAiw4o0Ia05JKRX+kBYSwUpa6naYw0ogqiEWZ1cpH fLAg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FxKexvjqGONynQt44Y9rSDCAnO+Fy2GIKAYEJV6ohYQ=; fh=lY3h23jRVJHLNZ8jkvWb29O3v/PZTHiYAOsU2LAz144=; b=kLdneo/NysPG41tRSrQvwRwZERl4nKpQ6vj3B74PHOwxh2ajHDJt3fetrtlxDOEbLC ni8YshRrXIQ81diFY2dBkSSmlVpDEuQnj0E9cCpCvCmNJKQbDcfmtZCfbDB/SPKpdGLN uy4GpddVntWm7PP8SPi4mpYJ4S+Xfwg8QeZWeFVdsDpVbk7Fsy4vWu/qDqZesimPXbc+ +ZAtA+42kxmAqIXmHAR14tNN7VoXMdQ1S7oYId2+eWIWjHee8TzgxPcgjJ7D/ZJe3qXc GM7U9mmmO16KaSR1Af0DoJ0vDCQI5YXD152hexjyxTHXMRvte6S1JwG6k0AFxHEqDccj xA8A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=foPd5OhR; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-110062-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id np4-20020a17090b4c4400b002a023821d9fsi1043570pjb.165.2024.03.21.05.59.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 05:59:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110062-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=foPd5OhR; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-110062-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 617BE28212B for ; Thu, 21 Mar 2024 12:59:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D28484038; Thu, 21 Mar 2024 12:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="foPd5OhR" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6732679B8E; Thu, 21 Mar 2024 12:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711025983; cv=none; b=K/C3XrgajfPt8xPtFi3JXXHpkXoXrISBoSwpX3NsLYaq6cNAH5gDCItNB2CWjgCjAhN/0gXHykPXlyVmgwhDXhZEBo2eOqxh34pmwOqFQ3OzbgjjSTGVAgLfSWugIb+7Iv5chjLs428Op0t3QA16x/2TSB5Puqk3P6mcKl5LIl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711025983; c=relaxed/simple; bh=KHjmAyhrr6qV9dltsOKbiT+xGu3n4aULT3NAPZOj7xc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TMrSwbQXnAfyOLMCNqCZtjzMI420e0hUjo98WLFF6JwfiJk8S9IC1RPF3uSJaMb+qkcAJWImfKq+vIg2Zcr0Zl8rgpJm/qRpfKaunQ8Jfyth6jRZK1lDixGiHEZqXhRcZe4mBf/XIH9E2Kbt4rzRZHhG/87qTs3C47YPk+2CTds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=foPd5OhR; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8490CC433F1; Thu, 21 Mar 2024 12:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711025982; bh=KHjmAyhrr6qV9dltsOKbiT+xGu3n4aULT3NAPZOj7xc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=foPd5OhRJil3riBqj3QjGquPL3UqI2aWKCEZpF8u1hmHdbmjhTkqluXwyBUZCVj5r WoHO2lLEAh/J56HKrE/jZhz4oVz3Ly3vluFyrG9Cwfu0BMxkmf9TGya7dLsss7T/vx g7IUZCepnAIg4tiO78L2Y4b7wCglfq6y+eI1DxRo= Date: Thu, 21 Mar 2024 13:59:40 +0100 From: Greg KH To: Oliver Neukum Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+9665bf55b1c828bbcd8a@syzkaller.appspotmail.com Subject: Re: [PATCH net-next] usbnet: fix cyclical race on disconnect with work queue Message-ID: <2024032125-repent-wafer-51fc@gregkh> References: <20240321124758.6302-1-oneukum@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321124758.6302-1-oneukum@suse.com> On Thu, Mar 21, 2024 at 01:46:41PM +0100, Oliver Neukum wrote: > The work can submit URBs and the URBs can schedule the work. > This cycle needs to be broken, when a device is to be stopped. > Use a flag to do so. > > Fixes: f29fc259976e9 ("[PATCH] USB: usbnet (1/9) clean up framing") > Reported-by: syzbot+9665bf55b1c828bbcd8a@syzkaller.appspotmail.com > Signed-off-by: Oliver Neukum > --- > drivers/net/usb/usbnet.c | 37 ++++++++++++++++++++++++++++--------- > include/linux/usb/usbnet.h | 18 ++++++++++++++++++ > 2 files changed, 46 insertions(+), 9 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot