Received-SPF: pass (google.com: domain of linux-kernel+bounces-110072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Song, Xiongwei" <Xiongwei.Song@windriver.com>
To: Xiu Jianfeng <xiujianfeng@huaweicloud.com>, "cl@linux.com" <cl@linux.com>,
        "penberg@kernel.org" <penberg@kernel.org>,
        "rientjes@google.com"
	<rientjes@google.com>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "vbabka@suse.cz"
	<vbabka@suse.cz>,
        "roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
        "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>
CC: "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "xiujianfeng@huawei.com"
	<xiujianfeng@huawei.com>
Subject: RE: [PATCH -next] mm/slub: remove dummy slabinfo functions
Thread-Topic: [PATCH -next] mm/slub: remove dummy slabinfo functions
Thread-Index: AQHae2zR49nd4JIODEC+LaQAnyvx1LFCHC3A
Date: Thu, 21 Mar 2024 12:20:39 +0000
Message-ID: 
 <PH0PR11MB51924AC8A58ABB22B8015296EC322@PH0PR11MB5192.namprd11.prod.outlook.com>
References: <20240321084415.265643-1-xiujianfeng@huaweicloud.com>
In-Reply-To: <20240321084415.265643-1-xiujianfeng@huaweicloud.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?HiGgwaCSlXfDfY+w0Eq7osQV9CZmZq0ZfF/fmmXJBUSvMxaGYxLckvphjojj?=
 =?us-ascii?Q?GqyEQn7l7Di9Dbm3DxyvTGvi+HhAqLUPKD1uGo/gJX3glIBh/dU7aXKx1tLO?=
 =?us-ascii?Q?VyjhBzOrwMBR7tYgB4moEwZOWjDv+MgAwQtQr1pZl+Fxoko/zHADjWfra5rK?=
 =?us-ascii?Q?l6Y7R6rdKMwY+z5k2LmPI0ftm7tE+DdOWVWgt7mnv6Jvw2FGceuwLLkmIKAe?=
 =?us-ascii?Q?syAQ9IPoBpQN/85mEZAOdTVeQD7mqjXuPzcqR5xyuUDjiof+Ks6JO5W2F/1F?=
 =?us-ascii?Q?3UX4eO54O80F/PwtnOD+plv8d91o7bA2r3n+r27KjjryPuGRVAiPofgwBQvi?=
 =?us-ascii?Q?Mh8Q19oZ5S1kGDBNqIEznvJg/zOSSL/n37Ld9oayPUM8yfVVmdHy2625ro/w?=
 =?us-ascii?Q?TaF0Zrys+xzSqJMDCOVc2Zldca+b2rrhUt2yZsv2d71QZZsqcgSmpHQobyIc?=
 =?us-ascii?Q?0lPYicqBmgViCQT31TDCy23j+yh2GQ78sWCcDIeW40XJARNkyX59yaj2DgQr?=
 =?us-ascii?Q?EI4lYsh0huiNBY/K+m0UGNBOahumGCJY9W6bat/7D3hU/sPA/nYUYDH/g9Ek?=
 =?us-ascii?Q?fkr1P6PaXWNyYYa7R2jRcHiHbA88tFaCFOCB3C9MnPK5q9AHyzY1KWqGhUY2?=
 =?us-ascii?Q?rpamc0XVgr0K5u0ZHEuLdjhb0jCUjJ3r1RnkiqlpHPAN12bj8jfzdDLVTN7l?=
 =?us-ascii?Q?iFOrc5B4wHTqeV+G/LWmDVfPb46SsVq3XVEcjfoMbYQghmQhnRfEn1olwHWB?=
 =?us-ascii?Q?fiJSzngxBgF9vUnF4Yhs3DciIfqR5mSS84E4LC9AQpr4mYz8DtnQt9dhR5o3?=
 =?us-ascii?Q?tdkD2266MuRJz7IM82Khm1VJ/oY5VmTYFFzig1FDvc0g9i7c0KFiiY7W918J?=
 =?us-ascii?Q?KINw0HZto9/moi8xGxDLnxLZZyeJ9SrfQ3dpzW9y9yu534052P0fU5n5141D?=
 =?us-ascii?Q?mx2Pwv03DxIXQvWDl8v5l8xOLT7AdUHaDiE/epFysBKduHN4ysPS4lUgVJ3/?=
 =?us-ascii?Q?GHbhtCCA/sZeM/m8TGPhWsiXngtNHf0UaSgXgeRywdgL285xLLD8PUSj0fpe?=
 =?us-ascii?Q?LCWlNTaT2+1HW+iQ8RtCdjfBMXQM52EDwqAmpZFuh/3o1wiNtjvn5yjg1jcm?=
 =?us-ascii?Q?RymPtckI91mpxVCDOqDrkMJvpApe3aU94/agYo5RwG2C6h7dfN2deoJX/lAa?=
 =?us-ascii?Q?6glFwp4QwHhW+1ulXgtIVme0s9eXBfYklGNNUe9tEZ3CVogjqRiyFauZ/Zq0?=
 =?us-ascii?Q?SFtA/OAh92SsPcMUuWmC9pqHawiQstZGxOiZxuYmwj5s3W7MW7xz9OukM6YS?=
 =?us-ascii?Q?pVIMPv5y9G/yya5FC0W2uLlZnDkjJljfteJEHgGOh/2Kme9wNTFNpzanEfIm?=
 =?us-ascii?Q?/3M8a6bmKZEOB83WJH1ruI2cDPObM/ZHTgkP/BzY5tqLqp5rB+n+ufq1zwDZ?=
 =?us-ascii?Q?fCr1nF1V11K4M2EVwwhi63PfLWUUcpwBsmq34SGRs3VjE5/6MB8JC28zsS2q?=
 =?us-ascii?Q?IvIq27HRQ9pz+SDJbp2/kcG41jNUruFpPGCgWtQ3Ea8OjGohDqTjVMzNYbLd?=
 =?us-ascii?Q?qlKl5OezoqSNRB4yAmqLC/dIEpIErH3glivOXPC7AC0qQnnH2PuwmoCxIb7/?=
 =?us-ascii?Q?yw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5192.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c87ae28-2f0d-4b7b-742c-08dc49a151f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 12:20:39.3042
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: khHHCmhC+J94QE2DWkxQV0x5xZiNiyimyxzxA30V1I+Lx1bToyfQFabpvoik9oRN25IU1h0vq47PKaZPoDCgEkqveZ+AmUIIif4ahdt4miw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7458
X-Proofpoint-GUID: lVY5Qkp8LwdW4dn-AqR-AprlqgkIE15B
X-Proofpoint-ORIG-GUID: lVY5Qkp8LwdW4dn-AqR-AprlqgkIE15B
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-21_08,2024-03-18_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 malwarescore=0 mlxscore=0 clxscore=1011 mlxlogscore=999
 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2403140001 definitions=main-2403210086


> From: Xiu Jianfeng <xiujianfeng@huawei.com>
>=20
> Slab has been removed since 6.5, so there is no other versions of

Removed since 6.8. The changes looks good.

Regards,
Xiongwei

> slabinfo_show_stats() and slabinfo_write(), then we can remove these
> two dummy functions.
>=20
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
>  mm/slab.h        |  3 ---
>  mm/slab_common.c |  2 --
>  mm/slub.c        | 10 ----------
>  3 files changed, 15 deletions(-)
>=20
> diff --git a/mm/slab.h b/mm/slab.h
> index d2bc9b191222..78e205b46e19 100644
> --- a/mm/slab.h
> +++ b/mm/slab.h
> @@ -496,9 +496,6 @@ struct slabinfo {
>  };
>=20
>  void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo);
> -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s);
> -ssize_t slabinfo_write(struct file *file, const char __user *buffer,
> -                      size_t count, loff_t *ppos);
>=20
>  #ifdef CONFIG_SLUB_DEBUG
>  #ifdef CONFIG_SLUB_DEBUG_ON
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index f5234672f03c..67c03d6bd26c 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1078,7 +1078,6 @@ static void cache_show(struct kmem_cache *s, struct=
 seq_file *m)
>                    sinfo.limit, sinfo.batchcount, sinfo.shared);
>         seq_printf(m, " : slabdata %6lu %6lu %6lu",
>                    sinfo.active_slabs, sinfo.num_slabs, sinfo.shared_avai=
l);
> -       slabinfo_show_stats(m, s);
>         seq_putc(m, '\n');
>  }
>=20
> @@ -1155,7 +1154,6 @@ static const struct proc_ops slabinfo_proc_ops =3D =
{
>         .proc_flags     =3D PROC_ENTRY_PERMANENT,
>         .proc_open      =3D slabinfo_open,
>         .proc_read      =3D seq_read,
> -       .proc_write     =3D slabinfo_write,
>         .proc_lseek     =3D seq_lseek,
>         .proc_release   =3D seq_release,
>  };
> diff --git a/mm/slub.c b/mm/slub.c
> index 1bb2a93cf7b6..cc7e68fbdbba 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -7099,14 +7099,4 @@ void get_slabinfo(struct kmem_cache *s, struct sla=
binfo *sinfo)
>         sinfo->objects_per_slab =3D oo_objects(s->oo);
>         sinfo->cache_order =3D oo_order(s->oo);
>  }
> -
> -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s)
> -{
> -}
> -
> -ssize_t slabinfo_write(struct file *file, const char __user *buffer,
> -                      size_t count, loff_t *ppos)
> -{
> -       return -EIO;
> -}
>  #endif /* CONFIG_SLUB_DEBUG */
> --
> 2.34.1
>=20