Received-SPF: pass (google.com: domain of linux-kernel+bounces-110073-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Claus Hansen Ries <chr@terma.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "michal.simek@amd.com"
	<michal.simek@amd.com>, "wei.fang@nxp.com" <wei.fang@nxp.com>,
	"yangyingliang@huawei.com" <yangyingliang@huawei.com>, "robh@kernel.org"
	<robh@kernel.org>, "harini.katakam@amd.com" <harini.katakam@amd.com>,
	"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"wanghai38@huawei.com" <wanghai38@huawei.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Simon Horman <horms@kernel.org>
Subject: [PATCH net v3] net: ll_temac: platform_get_resource replaced by wrong
 function
Thread-Topic: [PATCH net v3] net: ll_temac: platform_get_resource replaced by
 wrong function
Thread-Index: AQHae5DvcBQGjutR3k6qenCAG00K5Q==
Date: Thu, 21 Mar 2024 13:08:59 +0000
Message-ID: <cca18f9c630a41c18487729770b492bb@terma.com>
References: <f512ff25a2cd484791757c18facb526c@terma.com>
In-Reply-To: <f512ff25a2cd484791757c18facb526c@terma.com>
Accept-Language: en-150, en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Authenticated_ID: smtp.out@terma.com
X-VIPRE-Scanners:virus_clamav;virus_bd;
X-PolicySMART: 6001202, 19049467
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=terma.com; s=mailanyone20180424;h=MIME-Version:In-Reply-To:References:Message-ID:Date:To:From; bh=IDfZnO7QGbsU29t2V7zzkrAVifHGRoHP+pRJ13Ln7PY=;b=fVzMyOFI8+XHvlRrj+xR0VnXD4btKfoLyjx5VIpYGOxLTZCwK8LWKXKOvt97iSiT0JSSc0Oymy8VJMXSdKD99mB5N0Cg/0yN2XVSgb8UFVHLJUBEkv7i71eTJ6TFOsOYZSTmbaZvA1Z9IPirWs/nQsF2Qfosrjk4BTGq9Jq3Rotv28+AFzMU8pASm5d4xwqVkX5N2ntWiHiRI7J139GRuVIaz3bp/uCsvj6N0UqQ/qnNpas4raxzCz9m9s7vqa/N9D5gKlhiRz6KCRf7Qp3F3y59GcNRfs/bjG0Q/Mws4xgc+sy1s9PHnWE0e3OEz3s8dE/iM8pQ4cZnjoEfjuxNNQ==;
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467
X-PolicySMART: 6001202, 19049467

The function platform_get_resource was replaced with=20
devm_platform_ioremap_resource_byname and is called using 0 as name.=20

This eventually ends up in platform_get_resource_byname in the call=20
stack, where it causes a null pointer in strcmp.

	if (type =3D=3D resource_type(r) && !strcmp(r->name, name))

It should have been replaced with devm_platform_ioremap_resource.

Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byn=
ame()")
Signed-off-by: Claus Hansen Ries <chr@terma.com>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
---
v3:
  - Cleanup of patch message
v2: https://marc.info/?l=3Dlinux-netdev&m=3D171094427802626&w=3D2
  - fix accidently converting tabs to spaces and wording in commit message
v1: https://marc.info/?l=3Dlinux-netdev&m=3D171087828129633&w=3D2

 drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethe=
rnet/xilinx/ll_temac_main.c
index 9df39cf8b097..1072e2210aed 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
 	}
=20
 	/* map device registers */
-	lp->regs =3D devm_platform_ioremap_resource_byname(pdev, 0);
+	lp->regs =3D devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(lp->regs)) {
 		dev_err(&pdev->dev, "could not map TEMAC registers\n");
 		return -ENOMEM;

base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d
--=20
2.39.3 (Apple Git-146)