Received-SPF: pass (google.com: domain of linux-kernel+bounces-110114-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 21 Mar 2024 08:55:02 -0500
From: Rob Herring <robh@kernel.org>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: pavel@ucw.cz, lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for
 mobile network
Message-ID: <20240321135502.GA1637678-robh@kernel.org>
References: <20240320124431.221-1-musashino.open@gmail.com>
 <20240320124431.221-2-musashino.open@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240320124431.221-2-musashino.open@gmail.com>

On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection.
> As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal,
> too low, low, good) of mobile network connection via dongle connected
> to USB port.
> 
> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
>  include/dt-bindings/leds/common.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index ecea167930d9..d4b8498bde7f 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -91,6 +91,7 @@
>  #define LED_FUNCTION_LAN "lan"
>  #define LED_FUNCTION_MAIL "mail"
>  #define LED_FUNCTION_MTD "mtd"
> +#define LED_FUNCTION_MOBILE "mobile"

Why doesn't "wan" work?

>  #define LED_FUNCTION_PANIC "panic"
>  #define LED_FUNCTION_PROGRAMMING "programming"
>  #define LED_FUNCTION_RX "rx"
> -- 
> 2.25.1
>