Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp528334lqp; Thu, 21 Mar 2024 08:09:46 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWtOPBeTbuRnjgC5+3VnMbKZPvtliHrGqQbtUbz/VDyd5jh3M818/iJJZc6cwtsKRin/4RZCxaFUqGuNIAkkpu/to64W5vzLsF2Wbs8zA== X-Google-Smtp-Source: AGHT+IFoAqQC9KLWB0+1qXo7l187iUEhc+eAey/n1xCFxqqz60Ld/trZGDwGC9WQ+CGpMy7NhCCl X-Received: by 2002:a17:906:1796:b0:a46:5e38:29d7 with SMTP id t22-20020a170906179600b00a465e3829d7mr7452900eje.10.1711033786629; Thu, 21 Mar 2024 08:09:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711033786; cv=pass; d=google.com; s=arc-20160816; b=PDK9/HRtnHZhJOAboP88H8rjNEM8TuEXhxn+QcxzWG74zXkCSfBHKtM/difyLIfrYO Dl+y48iNYS22fET+eCEZV5tlYF5uFPvWrDDostq9zEl7VDQ2I73YdHZz4Uxibwz/lZkl 7Zs44BOvPeDUVu3qzvqGOC7RbWvNs5lN6/yKun2knMWLsjQZLParNwGDci4BtvpxMo0Y m6T4wnN/+BxcEpquUUoZaEbLPMpvQXW+HZlx/kbFdNQ4Wb89KmvwmBregGRMg1yB4wdF aEYUGr1Nz3G4ni1OaMK++OSeQs4Hwpz4uq9PWTG/CIg2C686mCXJ0ehOtMti9gsxftay 1zjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Ss+YU1Vv8nTsZE4tq2yaIEECtnSmtlcJ8d4BM8M2KZA=; fh=n4il5lRbH0lBmk2Oh8Hb74iYFeMUQoXh6iLuzfBVbHE=; b=aFoz+bRkreVDxhH7vGzhFmkI33y7hwq5sPWxwd1ScfuZODve/s24FYJ0qUaWwE31j9 DKG6gQ05idHvlUf6luPIeE+rRCM04lgNAj4JNnjI9t7eeqiyZPDncxCxUx/SxmbQdrez p968d09MdkOuSekWzoYacmsADAGbGzxFNFeOgcAEs0iy/kARlHiceIkfJicrm6oHA5nn Q/3qbcFxqQGcBo62OoreuwTgTGOSFTQmMvATKvY733Ma+7tp/vJbtD7+G30oxl3xv+Aj 6WqZADtqwAfF/kUOn8fOxzRusBfhzYBs/wJw80bvDCd9UNyhp2QU2u3cryqM5UDuxKrw xv1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhF4jUSr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110200-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t17-20020a17090616d100b00a4635cbd07dsi15416ejd.101.2024.03.21.08.09.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 08:09:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhF4jUSr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-110200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110200-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5B5721F239EC for ; Thu, 21 Mar 2024 15:09:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CDDFC86245; Thu, 21 Mar 2024 15:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UhF4jUSr" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011AE85943; Thu, 21 Mar 2024 15:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711033777; cv=none; b=X2apdffCrs1yvSwrgeJ9X8GeWlGJJqE9J01Jq7nIAcx6srflqyleERwlL95jUe9qpPwB8YL7t6HCoN2YHHaAfs5YJRopsLIbc7VFT+vxZ1g8MF/zR+XuAtn0xO6THdODk7ZDW7pryi9pn8c6r2lcaJ4zbMk3JG8L/5EzuzNh2mE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711033777; c=relaxed/simple; bh=G6NTJt7joh2QpS7GqQPcdEuL7u8Et9P+QNk32/jLYpU=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=QF8olpmMttj89M+GKeuCaxJl56bM3Uh5yXaBecdE7MMfnLHd2zhjWyDHGA3k+/DCM1T2kVLxvFAB6qY+aXXxN6rQa94Dm2kyA1QMZpnNBLbyrCiVRAeqOC+WNRd66ikjJSHaA0DTR6OU7nkKoco9D4qNu9+Lrtn9fSnZLNN1Sc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UhF4jUSr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15787C433F1; Thu, 21 Mar 2024 15:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711033776; bh=G6NTJt7joh2QpS7GqQPcdEuL7u8Et9P+QNk32/jLYpU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=UhF4jUSrSYeHjbQJYC6o8CrUYZzhIXPYMqF2agwKGGPwKAvgjwXmg4k/3SP1aZY9y M3UlBEyWsshsaL564wcKgUTrxx6Ogi+MudSF7fWrz37OcS3PZu4aF+sESH7h9tqJGX sWP5NR2w4TZ7dquuQGjRTU/zaXSuE2OIaG+KP1tngGSsNc9Zn5ykSFiqXW0kVvtz8C 5CgasnTuVk7i0BlEsunY0mNWOQAktV0Kh5haPE8fI1Hya0ThYEi0QNtSB7OjbJ49ph 75AlOTMX307Py4sfpTUP0xlQy20SPjPcPUIlbt3uQ5hz3TzPS8UzP5cKsJ926NtKmJ Ptuatsy0cm51A== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: qtnfmac: allocate dummy net_device dynamically From: Kalle Valo In-Reply-To: <20240319172634.894327-1-leitao@debian.org> References: <20240319172634.894327-1-leitao@debian.org> To: Breno Leitao Cc: Igor Mitsyanko , Sergey Matyukevich , kuba@kernel.org, keescook@chromium.org, linux-wireless@vger.kernel.org (open list:QUANTENNA QTNFMAC WIRELESS DRIVER), linux-kernel@vger.kernel.org (open list) User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171103377318.103792.6654245785464194890.kvalo@kernel.org> Date: Thu, 21 Mar 2024 15:09:34 +0000 (UTC) Breno Leitao wrote: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct qtnf_bus by converting it > into a pointer. Then use the leverage alloc_netdev() to allocate the > net_device object at qtnf_pcie_probe(). The free of the device occurs at > qtnf_pcie_remove(). > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > > Signed-off-by: Breno Leitao Patch applied to wireless-next.git, thanks. 61cdb09ff760 wifi: qtnfmac: allocate dummy net_device dynamically -- https://patchwork.kernel.org/project/linux-wireless/patch/20240319172634.894327-1-leitao@debian.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches