Received-SPF: pass (google.com: domain of linux-kernel+bounces-110211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 21 Mar 2024 16:21:43 +0100
From: Joel Granados <j.granados@samsung.com>
To: <wenyang.linux@foxmail.com>
CC: "Eric W . Biederman" <ebiederm@xmission.com>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>, Christian Brauner
	<brauner@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/9] encode the values directly in the table entry
Message-ID: <20240321152143.yxoonjy3m6bdddkf@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="rhtofu2dfldrnkgy"
Content-Disposition: inline
In-Reply-To: <tencent_C5E6023F97E7CC2A046AAEA09BC9ACF43907@qq.com>
CMS-TYPE: 201P
References: <CGME20240309103209eucas1p25311b485e321e701eeacbdb3e2ba8758@eucas1p2.samsung.com>
	<tencent_C5E6023F97E7CC2A046AAEA09BC9ACF43907@qq.com>

--rhtofu2dfldrnkgy
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 09, 2024 at 06:31:17PM +0800, wenyang.linux@foxmail.com wrote:
> From: Wen Yang <wenyang.linux@foxmail.com>
>=20
> The boundary check of multiple modules uses these static variables (such =
as
> two_five_five, n_65535, ue_int_max, etc), and they are also not changed.
This message is a bit cryptic. I had to do a fair amount of research to
get what you meant here. Having the context in front is OK with me, but
I would add a bit more information so the reader does not have to go to
the code and grep for the variables that you mean. Something like this:
"When using a sysctl proc_handler that requires a boundary check (like
proce_dointvec_minmax) it is common to use a const variable like n_65535
in net/rxrpc/sysctl.c or OTHER EXAMPLES...). This is suboptimal because
YOUR REASONS HERE"


>=20
> Eric points out: "by turning .extra1 and .extra2 into longs instead of
> keeping them as pointers and needing constants to be pointed at somewhere
> ... The only people I can see who find a significant benefit by
> consolidating all of the constants into one place are people who know how
> to stomp kernel memory."
I think it would be better to just link to the lore discussion.=20

>=20
> This patch series achieves direct encoding values in table entries and st=
ill
> maintains compatibility with existing extra1/extra2 pointers.
> Afterwards, we can remove these unnecessary static variables progressivel=
y and
> also gradually kill the shared const array.
Two things:
1. Please name the const array: sysctl_vals
2. What is missing from this patchset to completely kill sysctl_vals?

>=20
> Wen Yang (9):
>   sysctl: support encoding values directly in the table entry
>   kernel/sysctl-test: add some kunit test cases for min/max detection
>   rxrpc: delete these unnecessary static variables n_65535, four,
>     max_500, etc
>   net: ipv6: delete these unnecessary static variables two_five_five and
>     minus_one
>   svcrdma: delete these unnecessary static variables min_ord, max_ord,
>     etc
>   sysctl: delete these unnecessary static variables i_zero and
>     i_one_hundred
>   epoll: delete these unnecessary static variables long_zero and
>     long_max
>   fs: inotify: delete these unnecessary static variables it_zero and
>     it_int_max
>   ucounts: delete these unnecessary static variables ue_zero and
>     ue_int_max
>=20
>  fs/eventpoll.c                   |  19 +-
>  fs/notify/inotify/inotify_user.c |  49 +++--
>  include/linux/sysctl.h           | 108 ++++++++++-
>  kernel/sysctl-test.c             | 300 +++++++++++++++++++++++++++++++
>  kernel/sysctl.c                  |  61 +++++--
>  kernel/ucount.c                  |   8 +-
>  lib/test_sysctl.c                |  12 +-
>  net/ipv6/addrconf.c              |  15 +-
>  net/rxrpc/sysctl.c               | 169 ++++++++---------
>  net/sunrpc/xprtrdma/svc_rdma.c   |  21 +--
>  10 files changed, 571 insertions(+), 191 deletions(-)
>=20
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Joel Granados <j.granados@samsung.com>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: linux-kernel@vger.kernel.org
>=20
> --=20
> 2.25.1
>=20

--=20

Joel Granados

--rhtofu2dfldrnkgy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX8UIYACgkQupfNUreW
QU8J2gv/Wn96kRUWj6M/Gm9p4gkRJQnz6ahfI8r0J3+R4q3wadjt0PQKuOMdozaG
ld8xIwkJE5EFU8ZUAtEfA6e4wWuiDYP51C2xAmXMys1ZGLwpkikq75ZEJWdGBypO
pFlv9n/XbJh0rgz6ArJ5p7X46h3oo0P7ad5OPsKC/hHvJGw9dhIfPRskNi9yMjQ2
O63HjrVg67eLviSklenG0bNlSjZS+3IsgqjSMV5yHxeqA7SfIegFkQUB2WN5he1k
Pbcu0CQ3oPYZT/cBMPOzDHg5Q0/CdfjBOPCqVInluHzXJYYtOm32ybkPuKu6aJEY
ErYBabw96H+dNU5b4GK2NxGBT42iCsWv+CmxTmgFCVJXekcSs0B7dLyyiOb5Wrn9
MxvCpB5g2fIoKHo6btbHi+Clcrc0zwthe45LVuCfd+rUGs0SMyvLJB5nPfCPGdLG
JaPL+UQzV77SR/3qQ5XuCxdtgZjeMmFiBACMZmtQLKhW1hoqF2SXQnp+vunfyksK
WiHPHbPP
=aSag
-----END PGP SIGNATURE-----

--rhtofu2dfldrnkgy--