Received-SPF: pass (google.com: domain of linux-kernel+bounces-110286-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i7158435c:Fastmail
Date: Thu, 21 Mar 2024 15:53:59 +0000
From: Tony Finch <dot@dotat.at>
To: Arnd Bergmann <arnd@kernel.org>
cc: Sam Ravnborg <sam@ravnborg.org>, Arnd Bergmann <arnd@arndb.de>, 
    Masahiro Yamada <masahiroy@kernel.org>, 
    Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, 
    linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/unifdef: avoid constexpr keyword
In-Reply-To: <20240320180134.100863-1-arnd@kernel.org>
Message-ID: <196e71e0-6b17-f970-c034-4452e0c44052@dotat.at>
References: <20240320180134.100863-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Arnd Bergmann <arnd@kernel.org> wrote:
>
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:

So it is! Can you please incorporate the fixup patch below? Other than
that, LGTM.

Reviewed-By: Tony Finch <dot@dotat.at>

PS. I've been reviewing some other details of C23 recently. According to
the Editor's Report https://open-std.org/jtc1/sc22/wg14/www/docs/n3221.htm
the working draft that is closest to the official C23 Draft International
Standard is https://open-std.org/jtc1/sc22/wg14/www/docs/n3220.pdf
(There were significant changes and fixes even quite late in the process
so don't rely on earlier versions - I encoutered a bug when I did!)


--- scripts/unifdef.c
+++ scripts/unifdef.c
@@ -819,7 +819,7 @@ static const struct ops {
 /*
  * Function for evaluating the innermost parts of expressions,
  * viz. !expr (expr) number defined(symbol) symbol
- * We reset the constexpr flag in the last two cases.
+ * We reset the constexpression flag in the last two cases.
  */
 static Linetype
 eval_unary(const struct ops *ops, int *valp, const char **cpp)


-- 
Tony Finch  <dot@dotat.at>  https://dotat.at/
South Utsire: Variable 2 to 4 becoming south or southwest 5 to 7.
Moderate or rough. Rain or showers. Moderate or good, occasionally
poor.