Received-SPF: pass (google.com: domain of linux-kernel+bounces-110322-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 21 Mar 2024 17:15:24 +0100
From: Kory Maincent <kory.maincent@bootlin.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Luis Chamberlain
 <mcgrof@kernel.org>, Russ Weight <russ.weight@linux.dev>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki"
 <rafael@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Mark Brown <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com>,
 Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
 Russell King <linux@armlinux.org.uk>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
 devicetree@vger.kernel.org, Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
 within PSE framework
Message-ID: <20240321171524.0b04bfcc@kmaincent-XPS-13-7390>
In-Reply-To: <ZeWi90H-B4XeSkFs@pengutronix.de>
References: <20240227-feature_poe-v5-0-28f0aa48246d@bootlin.com>
	<20240227-feature_poe-v5-13-28f0aa48246d@bootlin.com>
	<ZeObuKHkPN3tiWz_@pengutronix.de>
	<20240304102708.5bb5d95c@kmaincent-XPS-13-7390>
	<ZeWi90H-B4XeSkFs@pengutronix.de>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Oleksij,

On Mon, 4 Mar 2024 11:31:19 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> >   =20
> > > Should be tested, but if, instead of "vin-supply", we will use
> > > "pse-supply" it will make most part of pse_regulator.c obsolete. =20
> >=20
> > Don't know, if it is done at the pse-pi node level it may not break
> > pse_regulator.c. Not sure about it. =20
>=20
> me too. Before your patch set, the regulator topology for PoDL PSE was
> following:
> power-source
>   fixed-regulator
>      PoDL_PSE-consumer
>=20
> Now it will be:
> power-source
>   fixed-regulator
>      PoDL_PSE-consumer
>        PSE-PI-provider
>          PSE-PI-consumer
>=20
> By porting porting PSE framework to regulator, probably it make sense to
> remove two levels of regulators?
> power-source
>   fixed-regulator
>      PSE-PI-consumer

Sorry, I forgot to reply about this.
This is specific to pse_regulator driver. Could we tackle this change in an=
other
patch series when the current patch series got applied?
Also I don't have the hardware to test it.

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com