Received-SPF: pass (google.com: domain of linux-kernel+bounces-110333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Grochowski, Maciej" <Maciej.Grochowski@sony.com>
To: Christoph Hellwig <hch@infradead.org>,
        Kelvin Cao
	<kelvin.cao@microchip.com>
CC: "vkoul@kernel.org" <vkoul@kernel.org>,
        "dmaengine@vger.kernel.org"
	<dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "logang@deltatee.com" <logang@deltatee.com>,
        "George.Ge@microchip.com" <George.Ge@microchip.com>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>
Subject: RE: [PATCH v8 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA
 engine PCI driver
Thread-Topic: [PATCH v8 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA
 engine PCI driver
Thread-Index: AQHaeV2YY1aquyBOkEWbZoiwjQWrUbE/0DqAgAKSLVA=
Date: Thu, 21 Mar 2024 16:21:19 +0000
Message-ID: 
 <CY4PR1301MB20711EDCA46D098C54A9961F81322@CY4PR1301MB2071.namprd13.prod.outlook.com>
References: <20240318163313.236948-1-kelvin.cao@microchip.com>
 <20240318163313.236948-2-kelvin.cao@microchip.com>
 <Zfo0Ta9cbD5PEO3g@infradead.org>
In-Reply-To: <Zfo0Ta9cbD5PEO3g@infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?p9SsG1mkr9kmrNIOYNngyo6+dBqgWJYUa6OiVKOAs2F1mFCoGXApvvMWtGF1?=
 =?us-ascii?Q?lZ+Lm/HEpa9E+dMm+SO05whYkVsYoZFyBkEurnRuFgNkohBF3EITcyR+ZZrZ?=
 =?us-ascii?Q?Doijb3FDlFh607jZQKKiEF8P3L/c4aZCJv5DmqHV1dycsA4RUVl1xyt83dtt?=
 =?us-ascii?Q?VJI+RkbcxgXauP/RIK2bE6HMqRN5Z7MooiMhFUO0OFf8xrBOmW4U6m6WhVZH?=
 =?us-ascii?Q?HUO/G+YcRRHVn965jg8/ynKFdxpSrXGHO8Glh5a6EGZN+GHTsYKeZD4OR2Bs?=
 =?us-ascii?Q?Kjze4n2jufWT6xl/uQc1QYiBMoylOiZQ9cTEUZS1EDE9U8RcbB/wPqJX7TTM?=
 =?us-ascii?Q?91BrwG5/2hcVvYmJCzYtbkupzz4Q8ucObMKXe9ktFmnD/TV1pQ9vJ5m+uhF4?=
 =?us-ascii?Q?uuXPQCwdAU17eqF7fDDgVRR+Hupn+54mbVpG9PsBr6PJrGeIEOXN+8hyG770?=
 =?us-ascii?Q?Yj8eI0T9Q62KEmJ0JsEoAAR00bWJbGZe16WUHfMQd7Q/N10n90J5oUjbmyRe?=
 =?us-ascii?Q?M1GTCEtIriLpqtFr8cDSvWtJ1SLkOWHqSwCfpUoQ1Jc9B+hdLjbqDdWddM4H?=
 =?us-ascii?Q?WJ1jQHdzf2a87pPjXSU3HTVzK8Vi5Mkwl6Dk/9SS49VPxIVtIm4wo0TYuIJd?=
 =?us-ascii?Q?QWbf6jMFYG1DlAoM7BCwOhNfs0SZ0DAm9ndTg+/ZQVRBniDw8QOI874J3EsS?=
 =?us-ascii?Q?hdNTKS1uLmBpHVUL+RCQG7ZnUmCofXr901k/ahkMfyPeHqUJmGCsUmfvWkqA?=
 =?us-ascii?Q?1dRG5azV4r1mCWSvc0rQS0Q1KXPxi49Th2pw29PUfxRHGqS4htDNYeXux5Wf?=
 =?us-ascii?Q?qXUKafmg4D9FNjYMCXLCGoOIal/pu+DQWdJOWHhcandTIQnqQXKyPssv8skB?=
 =?us-ascii?Q?fKYjVb6wzknIzG9A66N8Z4Rgh3IHBwE5nek8DIhzBLwe2WY9+6KOYycujcxU?=
 =?us-ascii?Q?EYq4eBPkEuFKOg+vam+1l5snd9c6YDvUryGpmmbK6VcJfelf2MeJW+uLWI1R?=
 =?us-ascii?Q?YiCcVVYSvEd38yhktfA+QDNc+5xoszLkw/jhVFHlhrRiRsVFitRVdz195Lmm?=
 =?us-ascii?Q?M3HptE0SDENqPPRwvHgt1eVpS4wbg970yia6OaGEnSwITedOLMPVYgnaW9fO?=
 =?us-ascii?Q?JBdzHQRmc/0amcKaPfQraj04mH/oW0umB3ut8Y4qTjS55M/dUbvfAmweQFSl?=
 =?us-ascii?Q?JdOLgv+fs10EbnGrThyMQKsEVcAPy8tMuEOYamOj/R0jKltF5NUdDseRPRxQ?=
 =?us-ascii?Q?OR2J/dZjySXBes5Oe/oD+8SuPL0s1boPjJpPwjPjJ/xJveRv8rrghouyIBC+?=
 =?us-ascii?Q?JLioVWc5mj3dPS2y5dt+nmX6xxnbI4UVS0pBBLJrvYQehnfNMudUMARrhFHZ?=
 =?us-ascii?Q?utXi6wEeyc2JhH2kJWF3UNn+WcitXAo7zZvvlkxUewkx5VQUbQ2141ut3BTm?=
 =?us-ascii?Q?kU69Fh7qR3twLq+roCiV6kb+CUm/1yV76PN+dCOEf+JOwwxgQbZO4ugDtTMf?=
 =?us-ascii?Q?HPdyfzkajQw0ws9TUTYFv38SDQpzr8zadg5gkFt7+RnMkPxj7+PA4XJ28jr6?=
 =?us-ascii?Q?BDSJPsF7NmSSU1CpR3lT4+JwuBHAw6LEzqpTHpIk?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	d7lvm4DnPbD7edkzi0yhLgkkjwhiCoxX519T1uOHvdrmXBT9v2/Yeb4N1S7ckh5qHySVp4vjKNapW4c6KF/zxyWAmCp2i61kSpIVRQ4x44Zam/DJCzbxbkDBaC50tDwXm/Ca/rs5Hru3196Bbxwpf5Z7SUZD/hVL0mZz9Ocz3N22eaa8iUPvtbjgHfj6Y/eC0GsG+25gYUqov46/q4Q0F3Yco4u1RxTcVEiFt9Y+nXi5MF2e+8vBM2unTXnZtzXxWD87Wd9iruPaLErSSFImnH8iCwQCXmo3VBXSWbB+FkdN7gRiVazbC/6um8JitJ+G/XvT5AqxVSX0t3+BvoZkpGmxTAMDODUYS0O3+GOqjprI1x+mhAk4uLx/auKq+fStTntMSL9EklWlYGUnvuQYgskGGSlMmiJ+5WDBGg/G3hDOgH/oPl7pC0sMzHQmVh+gedRRYHjOh2sZ8VXZkW/dfPxI8zHtb+E3uihBPGPw38PqSUWljPk4rd5+3aGnRNus3h8HCJx6UXqfnXKriZUbsK3zpO8wb4gHaCB6VbnhFuH4psWhA0hSfnjEUi5/uFop4iau9vs+P5QZ6W5l0wWVS+pE0G4j/OPeUDOaY3thCo8P1lM+Asv3qNPSPolZ0hec
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1301MB2071.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae89937-296d-4d6c-c67e-08dc49c2f0b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 16:21:19.0366
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jt7PozHYGHZrf3HuN2231RkSvg6ntXxkWGmoXAysk8NfN0Qzcvn3AvddXMei/0uqQUCvufWww5aoJU2tvEDXZD87eEpX3DYzD6SOFTFc880=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5179
X-Proofpoint-ORIG-GUID: 0RerBBDLNsOnRiihI3kSthVMufV-zoKe
X-Proofpoint-GUID: 0RerBBDLNsOnRiihI3kSthVMufV-zoKe
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: 0RerBBDLNsOnRiihI3kSthVMufV-zoKe
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-21_10,2024-03-21_01,2023-05-22_02

Hi Kelvin,

I have noticed lockdep_rcu complaining about suspicious rcu_dereference ins=
ide: switchtec_dma_chans_enumerate and switchtec_dma_chan_free functions

In the switchtec_dma_chans_enumerate:
```
static int switchtec_dma_chans_enumerate(struct switchtec_dma_dev *swdma_de=
v,
                                          int chan_cnt)
 {
         struct dma_device *dma =3D &swdma_dev->dma_dev;
         struct pci_dev *pdev =3D rcu_dereference(swdma_dev->pdev);	<<< sus=
picious RCU usage
         int base;
         int cnt;
         int rc;
         int i;
```
And inside switchtec_dma_chan_free
```
static int switchtec_dma_chan_free(struct switchtec_dma_chan
 *swdma_chan) {
         struct pci_dev *pdev =3D rcu_dereference(swdma_chan->swdma_dev->pd=
ev);  <<< suspicious RCU usage

         spin_lock_bh(&swdma_chan->submit_lock);
         swdma_chan->ring_active =3D false;
         spin_unlock_bh(&swdma_chan->submit_lock);
```

Is going to trigger lockdep_rcu below log from my system:
```
[  296.678725] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
[  296.682890] WARNING: suspicious RCU usage
[  296.687017] 6.8.0-rc4+ #2 Tainted: G            E
[  296.687028] -----------------------------
[  296.691166] drivers/dma/switchtec_dma.c:1256 suspicious rcu_dereference_=
check() usage!
[  296.699263]
               other info that might help us debug this:

[  296.707446]
               rcu_scheduler_active =3D 2, debug_locks =3D 1
[  296.714142] 1 lock held by insmod/1536:
[  296.714153]  #0: ffff8881191d91b0 (&dev->mutex){....}-{4:4}, at: __drive=
r_attach+0x172/0x3b0
[  296.714207]
               stack backtrace:
[  296.718689] CPU: 45 PID: 1536 Comm: insmod Tainted: G            E      =
6.8.0-rc4+ #2
[  296.718710] Call Trace:
[  296.718720]  <TASK>
[  296.718731]  dump_stack_lvl+0xac/0xc0
[  296.718750]  lockdep_rcu_suspicious+0x1dd/0x380
[  296.718782]  switchtec_dma_probe+0xf0a/0x1400 [switchtec_dma]
[  296.718819]  ? _raw_spin_unlock_irqrestore+0x66/0x80
```

I think it should be also guarded by rcu_read_lock/unlock in order to avoid=
 such situations.