Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp586639lqp; Thu, 21 Mar 2024 09:31:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2wrKi5qPejd4nZHikC9ZqscaHhY3vtaikNdN/UtkcTocKlPUqyLQMh9d8MtpSf4LJVGUjmYtsd0ucqCqZR1QY8DIBnh2Gi3SJ71ZOjA== X-Google-Smtp-Source: AGHT+IGXY99p7liYYJV0s6g6HRctmjZcHLH/gLpx39f+EjsTbFag/pBVzdKxl6sK8yHnbD+SxpG/ X-Received: by 2002:a17:90b:1644:b0:2a0:2f8e:76fc with SMTP id il4-20020a17090b164400b002a02f8e76fcmr864957pjb.28.1711038690629; Thu, 21 Mar 2024 09:31:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711038690; cv=pass; d=google.com; s=arc-20160816; b=dZhDm61Cw/mLJElyQA6NisNNlTXl79tYMQ5boRH6Bjb5ig7ozZD1bAXGG6e+VF6dh0 svKKhzsCVHLwAag6sDLsByEAIswkVbEs+DcccCteGLhpR7MCFK8MxWlZDppiqVDUm7q7 xmAQqCJSdFDwPHLILq94x1vwW10hKJtrTPHR8Oa+mKvQSkxZpZy3n8AcITLhpcZZgC1Y 9TDzmVS6js30lqLBfN2f6nvseNAOYPeYMnmXyP9n2YoN6+0c32SnwrojOzOeyEshIUng RFN4nFEN9DXUMhdEBIYaFxG7/cx1IlysO42zfqIUkthh1b+07seVE25kgR7TPH6N6tF0 TvBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=eaZDthvjTCr27uNVlVx72OiuFYi3ERv2MkUarW6WjxE=; fh=Wo+OB/zUZLgwxDoUM7qi03HsXRpQXETWUIrp0+6tqck=; b=nQZq/894pAZvnYBtErrjiuJ+/k9q+uvI1HX4DQCRlTMWS2CEEXRylwx2ug/7RT59Un FOd4EeFBZV7MTFjh04gOs1lhmtEjpJHUHbyFrLbZweNVwL+3XLl/9LbTjSQl116r0Epg oAsEPsRH6g7JzDiuz4asHE9GZUw0/Xff0JGu9CezP8G89EBbjXNe1d9uNFoR57YJ9tzx r56k7COOhf2iBgfugbkOdy2FYbwpGXCW3iSLPmuk45vEFOaMY3oHHqogXtfLX838qX7A pNysCRwLvp6KGT+dmkQuQ3Fi+6seAeXn6hy9kOTQggoRK1B5EqySGnoKLT4zcjOhTFyq trBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=odhXariL; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-110341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110341-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t5-20020a17090aba8500b0029c7873de80si161935pjr.8.2024.03.21.09.31.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 09:31:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-110341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=odhXariL; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-110341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-110341-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4BC0328485D for ; Thu, 21 Mar 2024 16:31:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A0D5762E8; Thu, 21 Mar 2024 16:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="odhXariL" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B28E132493 for ; Thu, 21 Mar 2024 16:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711038678; cv=none; b=kV8a+/UHj0GbSwI2nEF5rW3SnW92RFS2BeMUDLHEuZ+KORTGwO97nQ9tiCzL2D/MlpL9nTg7Cq0mn78P8rqKKb6m/HRyJMCyTUa/GQJQ0dqNfQQLqd569YQI/XpTh4wGBtiJFQv/4VMvN3caOgpMEN6rfYSRNRL8J2K/dpf1adY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711038678; c=relaxed/simple; bh=lXo1rQc6MtQsZ+k/JkJu9FHmX1nIfKfYoOVOD3ov3ws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nfL+YddKMSBP2yJ4iuxm8CX4tWlHmHlefDri3iLLxenpD0a/W6ivG19gnzbh9aIa+qJeTLaizJPQdJEE//EiWasWcVMDMPkcF0C5HxDX3qOFFG4nzywGUvWn1BjTfkewTm8jAf+xUdiKaqP0d7EIYHFRUIxz/uXvUIq0PPSIGbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=odhXariL; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from [192.168.88.20] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 945BE7E9; Thu, 21 Mar 2024 17:30:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711038646; bh=lXo1rQc6MtQsZ+k/JkJu9FHmX1nIfKfYoOVOD3ov3ws=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=odhXariLwUyoW+4tIZ/DzRQ9V67ESMFriO9QE7P6DoQAcSsl3PO6iJrxzZceDJZiw GrnSL7yjlGlfl1E8jKnx8FheYYK/SgS1W2BGFKWc1XKyWMu0JQKoZ3DmRwLJiH0MfG 5liA4+EgVWaeki/y6MM/L9zlXIHU7ngTops/OeO8= Message-ID: Date: Thu, 21 Mar 2024 18:31:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing Content-Language: en-US To: Sean Anderson Cc: Michal Simek , David Airlie , linux-kernel@vger.kernel.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20240319225122.3048400-1-sean.anderson@linux.dev> <20240319225122.3048400-9-sean.anderson@linux.dev> <7aa16340-6a87-4110-8114-c1b863b100c9@ideasonboard.com> <76831c1e-216f-430b-bacd-2d50f352e61f@linux.dev> From: Tomi Valkeinen Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <76831c1e-216f-430b-bacd-2d50f352e61f@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/03/2024 18:08, Sean Anderson wrote: > On 3/20/24 03:49, Tomi Valkeinen wrote: >> On 20/03/2024 00:51, Sean Anderson wrote: >> >>> +/** >>> + * enum test_pattern - Test patterns for test testing >> >> "for test testing"? =) >> >>> @@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct work_struct *work) >>> u8 status[DP_LINK_STATUS_SIZE + 2]; >>> int err; >>> + if (READ_ONCE(dp->ignore_hpd)) >>> + return; >>> + >>> mutex_lock(&dp->lock); >>> err = drm_dp_dpcd_read(&dp->aux, DP_SINK_COUNT, status, >>> DP_LINK_STATUS_SIZE + 2); >> >> Why do you need READ/WRITE_ONCE() for ignore_hpd? > > It's not protected by dp->lock so we don't have to take it for > zynqmp_dp_hpd_work_func. Although maybe we should make a version of > zynqmp_dp_bridge_detect which assumes we already hold the lock. Does using the macros solve some potential issue, or is it just for documenting that this variable is accessed without lock? Tomi