Received-SPF: pass (google.com: domain of linux-kernel+bounces-110344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 21 Mar 2024 17:32:18 +0100
From: Joel Granados <j.granados@samsung.com>
To: Wen Yang <wenyang.linux@foxmail.com>
CC: Jan Kara <jack@suse.cz>, "Eric W . Biederman" <ebiederm@xmission.com>,
	Luis Chamberlain <mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	Christian Brauner <brauner@kernel.org>, Dave Young <dyoung@redhat.com>,
	"Darrick J. Wong" <djwong@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary
 static variables it_zero and it_int_max
Message-ID: <20240321163218.6bqvs2f2ick7lltg@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="kwjstpfzr53dfx5y"
Content-Disposition: inline
In-Reply-To: <tencent_5C3A21886D522B5D9DF9CAAFF499AB6A9805@qq.com>
CMS-TYPE: 201P
References: <26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@foxmail.com>
	<tencent_3066A7AB308FF9F53E3B5639514306914D0A@qq.com>
	<CGME20240320103608eucas1p235f843330beda0c826ab3cc1709c65e6@eucas1p2.samsung.com>
	<20240320103603.u6uqhk6viu4qkaht@quack3>
	<20240321105555.f4qg5g3wbe57mzzx@joelS2.panther.com>
	<20240321113849.hfzmnz6p3cjbmmwt@quack3>
	<tencent_5C3A21886D522B5D9DF9CAAFF499AB6A9805@qq.com>

--kwjstpfzr53dfx5y
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 21, 2024 at 10:41:26PM +0800, Wen Yang wrote:
>=20
>=20
> On 2024/3/21 19:38, Jan Kara wrote:
> > On Thu 21-03-24 11:55:55, Joel Granados wrote:
> >> On Wed, Mar 20, 2024 at 11:36:03AM +0100, Jan Kara wrote:
> >>> On Tue 19-03-24 23:57:49, wenyang.linux@foxmail.com wrote:
> >>>> From: Wen Yang <wenyang.linux@foxmail.com>
> >>>>
> >>>> Delete unnecessary static variables (it_zero and it_int_max)
> >>>> and encode them directly in the table entry.
> >>>>
> >>>> Signed-off-by: Wen Yang <wenyang.linux@foxmail.com>
> >>>> Cc: Eric W. Biederman <ebiederm@xmission.com>
> >>>> Cc: Luis Chamberlain <mcgrof@kernel.org>
> >>>> Cc: Kees Cook <keescook@chromium.org>
> >>>> Cc: Joel Granados <j.granados@samsung.com>
> >>>> Cc: Christian Brauner <brauner@kernel.org>
> >>>> Cc: Jan Kara <jack@suse.cz>
> >>>> Cc: "Darrick J. Wong" <djwong@kernel.org>
> >>>> Cc: linux-kernel@vger.kernel.org
> >>>
> >>> This looks as a sensible cleanup but I don't see the first patch in t=
he
> >>> series (and neither it is archived at lore.kernel.org) so I cannot re=
ally
> >>> verify whether your conversion is correct...
> >> This was my original comment. If you want to see the cover letter
> >> look for this mail ID tencent_06797E65CFC655DCD4F0414B9380E95ECC08@qq.=
com
> >>
> >> Not sure why it separates the cover letter from the rest of the patche=
s.
> >=20
> > No, that is actually a different email :) Based on lore the message ID
> > should be:
> > 26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@f=
oxmail.com
> >=20
> > but the email is not in the archive...
> >=20
> > 								Honza
>=20
> Sorry, my email box changed the message ID when sending, but it can be=20
> found in lcore:
>=20
>=20
> or
> https://lore.kernel.org/all/tencent_0D6ABA209A4980742DE6003FBFE7FE2A3207@=
qq.com/
>=20
>=20
> If it causes any inconvenience to you, I can resend it. After some=20
> experiments, I have finally found a way to send them in a thread.
Before resending it, please read my comments to your original patchset.

--=20

Joel Granados

--kwjstpfzr53dfx5y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmX8YRIACgkQupfNUreW
QU/xfQv+MZ561xgb6+R6JgcECKyr5wWcBtLS9B7I110XN/4kgn06e3KDA6fq0s0y
Z7iWVW80AsEk8JLkoNDx7RKirnpW4TTA6qBR0PlFBZYr92L8d9Bhr2sUVt8MPYbF
5g6AYkeJ+xJjT01k53krNVXNVQd23RyocnLoUc74nJ8QMuy+YkhGLd7daYPWzguW
BEGHbNo8FqLI3TVQZ98LuXYg3LMKs/NXTLDFiNx4MmCfqU79yK86uCVtN5jiOvuC
UzCYtua/ihbnzB44vmWTnwnsfOc8TcmzeJ3mDKEnvQ1w4tUNBjSYdz1KwQatk/Pa
1E7KLyKx5+06+UKNey35KjMO4On4hy9O5zhFQ8wNVTs+WLWCzz6OFZu2qIoj81Ze
2GRvRBgBlewRG27JJLSdbWJNM2QWz0B5QVNr0JiKpFT+4s9PRw0pWpAr3t61I73Z
dbkIVYry6WmtDT1Kna5jNiHShh+a7jg/CpV0f+sTnEzJ6qEmGFS+NBf30z6yJujQ
9zAb7zth
=RfXT
-----END PGP SIGNATURE-----

--kwjstpfzr53dfx5y--