Received-SPF: pass (google.com: domain of linux-kernel+bounces-110456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Mar 2024 16:58:44 +0000
From: Mark Brown <broonie@kernel.org>
To: Karel Balej <balejk@matfyz.cz>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC
Message-ID: <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk>
References: <20240311160110.32185-1-karelb@gimli.ms.mff.cuni.cz>
 <20240311160110.32185-3-karelb@gimli.ms.mff.cuni.cz>
 <20240321154211.GA13211@google.com>
 <CZZK759UU6G7.MFPYOI0HBB6I@matfyz.cz>
 <20240321162045.GC13211@google.com>
 <CZZL3MNOT0QG.2WDSNX9XD2RET@matfyz.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XkucS5hq8f1KJRxO"
Content-Disposition: inline
In-Reply-To: <CZZL3MNOT0QG.2WDSNX9XD2RET@matfyz.cz>


--XkucS5hq8f1KJRxO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote:
> Lee Jones, 2024-03-21T16:20:45+00:00:
> > On Thu, 21 Mar 2024, Karel Balej wrote:

> > > > > +static const struct regmap_config pm886_i2c_regmap = {
> > > > > +	.reg_bits = 8,
> > > > > +	.val_bits = 8,
> > > > > +	.max_register = PM886_REGMAP_CONF_MAX_REG,
> > > > > +};

> > > > Why is this in here?

> > > Because since I moved the regulators regmap initialization into the
> > > regulators driver, I need to access it from there.

> > So move it into the regulators driver?

> It is used in the MFD driver too for the base regmap.

You shouldn't be creating two regmaps for the same set of registers,
that just opens the potential for confusion.

--XkucS5hq8f1KJRxO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX8Z0MACgkQJNaLcl1U
h9CAcwf/UU9whJTldKYf2Umup+pvhQQafpsIdaLAKZdVwH/4F27rS8pRMp1Cp4n6
nfCNwWaCrnRt8iHni5jzqgtroLfbIjeC5t4MMjvElqtkNTQ2hmGCKFAkofIA/KWk
BcKU+0N9riQ8OeUaf2VgxlaMKLP7DZUFV2ln6AeGRZUS5hzZENPn8RrLhIhhM+5m
6VqIssfMZ+gTc4dyrRuVy9X1tn+xIGxEJQuNSSsPP/yTMKgtrufRGztUlBuAoHk2
pzGryzuraqhgU++fHB652FuHhxfQ9MACAH8KXDEzHtgYcSb7eJ6FcjMCqvbPGAb6
kBruh2gv2bEw/5pteRoKXtYkcu8pvA==
=RfEQ
-----END PGP SIGNATURE-----

--XkucS5hq8f1KJRxO--