Received-SPF: pass (google.com: domain of linux-kernel+bounces-110467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 21 Mar 2024 17:10:48 +0000
From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
	Samuel Holland <samuel@sholland.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Chris Morgan <macromorgan@hotmail.com>,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 0/4] regulator: Add X-Powers AXP717 PMIC support
Message-ID: <20240321171048.GD13211@google.com>
References: <20240310010211.28653-1-andre.przywara@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240310010211.28653-1-andre.przywara@arm.com>

On Sun, 10 Mar 2024, Andre Przywara wrote:

> This patch series adds support for the X-Powers AXP717 PMIC, which is 
> used recently on new boards with Allwinner SoCs.
> Allwinner's BSP code often speaks of the AXP2202, this seems to be the
> same chip, at least a boot0 AXP2202 driver happily drove a chip labelled
> AXP717.
> 
> Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just
> realised that during some copy&paste action. It's just an identifier
> rename, so not a backport candidate, I'd say.
> Patch 2 adds the compatible string to the binding document.
> Patch 3 is the MFD part, describing the regmap and all the interrupts.
> So far we support the regulator and power key devices, the USB and
> charging devices will follow later.
> Patch 4 adds the voltage regulator rails, this part is crucial to enable
> any board using this PMIC, as we depend on those rails even for basic
> devices.
> 
> Please note that I could not test this driver myself, but had success
> messages from others. It would be good to hear from Ryan and Chris
> here on the list, with a Tested-by: tag.
> 
> This series is based on next-20240308 for now. I will send a rebased
> update after the merge window, but wanted to start discussion and review
> now.
> 
> Please have a look!
> 
> Cheers,
> Andre
> 
> Andre Przywara (4):
>   regulator: axp20x: fix typo-ed identifier
>   dt-bindings: mfd: x-powers,axp152: document AXP717
>   mfd: axp20x: add support for AXP717 PMIC
>   regulator: axp20x: add support for the AXP717
> 
>  .../bindings/mfd/x-powers,axp152.yaml         |  2 +
>  drivers/mfd/axp20x-i2c.c                      |  2 +
>  drivers/mfd/axp20x-rsb.c                      |  1 +
>  drivers/mfd/axp20x.c                          | 90 +++++++++++++++++
>  drivers/regulator/axp20x-regulator.c          | 94 +++++++++++++++++-
>  include/linux/mfd/axp20x.h                    | 98 ++++++++++++++++++-
>  6 files changed, 277 insertions(+), 10 deletions(-)

All applied and sent for build testing.  If everything works out, I'll
send out a pull-request to an immutable branch shortly.

-- 
Lee Jones [李琼斯]