Received-SPF: pass (google.com: domain of linux-kernel+bounces-110478-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Mar 2024 17:17:40 +0000
From: Mark Brown <broonie@kernel.org>
To: Karel Balej <balejk@matfyz.cz>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC
Message-ID: <45079e37-dde9-4310-a112-7af49f35ac77@sirena.org.uk>
References: <20240311160110.32185-1-karelb@gimli.ms.mff.cuni.cz>
 <20240311160110.32185-3-karelb@gimli.ms.mff.cuni.cz>
 <20240321154211.GA13211@google.com>
 <CZZK759UU6G7.MFPYOI0HBB6I@matfyz.cz>
 <20240321162045.GC13211@google.com>
 <CZZL3MNOT0QG.2WDSNX9XD2RET@matfyz.cz>
 <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk>
 <CZZLDK79D5VK.2VK3X59OHIY2Z@matfyz.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oJHv45Mb4kHzpP0z"
Content-Disposition: inline
In-Reply-To: <CZZLDK79D5VK.2VK3X59OHIY2Z@matfyz.cz>


--oJHv45Mb4kHzpP0z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote:
> Mark Brown, 2024-03-21T16:58:44+00:00:

> > > > > > > +static const struct regmap_config pm886_i2c_regmap = {
> > > > > > > +	.reg_bits = 8,
> > > > > > > +	.val_bits = 8,
> > > > > > > +	.max_register = PM886_REGMAP_CONF_MAX_REG,
> > > > > > > +};

..

> > You shouldn't be creating two regmaps for the same set of registers,
> > that just opens the potential for confusion.

> Just the regmap config is the same. Otherwise, each regmap lives at a
> different I2C address.

Do they both genuinely have the same maximum register?

--oJHv45Mb4kHzpP0z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX8a7QACgkQJNaLcl1U
h9AzgQf/ZFwxdRh8PV6KEsERNGwwS8v1mrS7lrZyYJ3WLjvxLW4IGIhGJlvYT0QK
6qY1L7OPpALhBqB9PJOMmzj25gYUrH0G7Xm/mgNLHGUfcziiy+aYFK+qMJz+WhmA
4jJZonmfKnPo14Q3P0BTRbQ31Sea749XWHsBX6Lj35znOawhFuAveCYPFnmkXV8z
IGGDK1JzLfPpzqIAt4sQSAK4IxcVZlhW431iWlsOjT6fGjUoCYJ024vfjt/Qe5a9
LV21+ek3qXEgkiHcJN4J4hVDwm2yQ/+AbTPPjwu1zWmSDWGu9GURK3MJaJYw4xQ0
8xeNT4PV3q7NHyFblyIuRyKnCJRIXg==
=XIFj
-----END PGP SIGNATURE-----

--oJHv45Mb4kHzpP0z--